cmd_fetch_pack(): return early if finish_connect() fails

diff --git a/builtin/var.c b/builtin/var.c
index 22805181900c3cd33da0b92a2560b19a0cf68842..aedbb53a2da5e02b2c8fc29a1a4dc22dc76fbefb 100644 (file)
--- a/builtin/var.c
+++ b/builtin/var.c
@@ -3,16 +3,15 @@
  *
  * Copyright (C) Eric Biederman, 2005
  */
-#include "cache.h"
-#include "exec_cmd.h"
+#include "builtin.h"
 
-static const char var_usage[] = "git var [-l | <variable>]";
+static const char var_usage[] = "git var (-l | <variable>)";
 
 static const char *editor(int flag)
 {
        const char *pgm = git_editor();
 
-       if (!pgm && flag & IDENT_ERROR_ON_NO_NAME)
+       if (!pgm && flag & IDENT_STRICT)
                die("Terminal is dumb, but EDITOR unset");
 
        return pgm;
@@ -20,7 +19,7 @@ static const char *editor(int flag)
 
 static const char *pager(int flag)
 {
-       const char *pgm = git_pager();
+       const char *pgm = git_pager(1);
 
        if (!pgm)
                pgm = "cat";
@@ -56,7 +55,7 @@ static const char *read_var(const char *var)
        val = NULL;
        for (ptr = git_vars; ptr->read; ptr++) {
                if (strcmp(var, ptr->name) == 0) {
-                       val = ptr->read(IDENT_ERROR_ON_NO_NAME);
+                       val = ptr->read(IDENT_STRICT);
                        break;
                }
        }
@@ -74,14 +73,9 @@ static int show_config(const char *var, const char *value, void *cb)
 
 int cmd_var(int argc, const char **argv, const char *prefix)
 {
-       const char *val;
-       int nongit;
-       if (argc != 2) {
+       const char *val = NULL;
+       if (argc != 2)
                usage(var_usage);
-       }
-
-       setup_git_directory_gently(&nongit);
-       val = NULL;
 
        if (strcmp(argv[1], "-l") == 0) {
                git_config(show_config, NULL);