Elaborate on why ':' is a bad idea in a ref name.

diff --git a/update-ref.c b/update-ref.c
index e6fbddbab6939023c4bbea9e0b685904dc6ba0b0..fd487421cd36763dd94f5439b3c40d0ed97c2c96 100644 (file)
--- a/update-ref.c
+++ b/update-ref.c
@@ -25,16 +25,17 @@ int main(int argc, char **argv)
        int fd, written;
 
        setup_git_directory();
+       git_config(git_default_config);
        if (argc < 3 || argc > 4)
                usage(git_update_ref_usage);
 
        refname = argv[1];
        value = argv[2];
        oldval = argv[3];
-       if (get_sha1(value, sha1) < 0)
+       if (get_sha1(value, sha1))
                die("%s: not a valid SHA1", value);
        memset(oldsha1, 0, 20);
-       if (oldval && get_sha1(oldval, oldsha1) < 0)
+       if (oldval && get_sha1(oldval, oldsha1))
                die("%s: not a valid old SHA1", oldval);
 
        path = resolve_ref(git_path("%s", refname), currsha1, !!oldval);