[PATCH] Make git-format-patch's signoff option more consistent

diff --git a/read-cache.c b/read-cache.c
index f448ab17e279d2fb4e2cfa91cfc61be6f91128db..5820f18d9a79fd83ff5a418a5dfc68bbf7c5c354 100644 (file)
--- a/read-cache.c
+++ b/read-cache.c
@@ -392,7 +392,7 @@ int read_cache(void)
                return (errno == ENOENT) ? 0 : error("open failed");
 
        size = 0; // avoid gcc warning
-       map = (void *)-1;
+       map = MAP_FAILED;
        if (!fstat(fd, &st)) {
                size = st.st_size;
                errno = EINVAL;
@@ -400,7 +400,7 @@ int read_cache(void)
                        map = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_PRIVATE, fd, 0);
        }
        close(fd);
-       if (-1 == (int)(long)map)
+       if (map == MAP_FAILED)
                return error("mmap failed");
 
        hdr = map;