Keep the parents in order when parsing commits

diff --git a/tag.c b/tag.c
index 9eade750d373791420739e494b8f0f0d7367675f..4041af2572a4427a03bc8955137b7d2211f9d770 100644 (file)
--- a/tag.c
+++ b/tag.c
@@ -3,7 +3,7 @@
 
 const char *tag_type = "tag";
 
-struct tag *lookup_tag(unsigned char *sha1)
+struct tag *lookup_tag(const unsigned char *sha1)
 {
         struct object *obj = lookup_object(sha1);
         if (!obj) {
@@ -13,6 +13,8 @@ struct tag *lookup_tag(unsigned char *sha1)
                 ret->object.type = tag_type;
                 return ret;
         }
+       if (!obj->type)
+               obj->type = tag_type;
         if (obj->type != tag_type) {
                 error("Object %s is a %s, not a tree", 
                       sha1_to_hex(sha1), obj->type);
@@ -21,11 +23,8 @@ struct tag *lookup_tag(unsigned char *sha1)
         return (struct tag *) obj;
 }
 
-int parse_tag(struct tag *item)
+int parse_tag_buffer(struct tag *item, void *data, unsigned long size)
 {
-        char type[20];
-        void *data, *bufptr;
-        unsigned long size;
        int typelen, taglen;
        unsigned char object[20];
        const char *type_line, *tag_line, *sig_line;
@@ -33,48 +32,59 @@ int parse_tag(struct tag *item)
         if (item->object.parsed)
                 return 0;
         item->object.parsed = 1;
-        data = bufptr = read_sha1_file(item->object.sha1, type, &size);
-        if (!data)
-                return error("Could not read %s",
-                             sha1_to_hex(item->object.sha1));
-        if (strcmp(type, tag_type)) {
-               free(data);
-                return error("Object %s not a tag",
-                             sha1_to_hex(item->object.sha1));
-       }
 
        if (size < 64)
-               goto err;
+               return -1;
        if (memcmp("object ", data, 7) || get_sha1_hex(data + 7, object))
-               goto err;
+               return -1;
 
        item->tagged = parse_object(object);
+       if (item->tagged)
+               add_ref(&item->object, item->tagged);
 
        type_line = data + 48;
        if (memcmp("\ntype ", type_line-1, 6))
-               goto err;
+               return -1;
 
        tag_line = strchr(type_line, '\n');
        if (!tag_line || memcmp("tag ", ++tag_line, 4))
-               goto err;
+               return -1;
 
        sig_line = strchr(tag_line, '\n');
        if (!sig_line)
-               goto err;
+               return -1;
        sig_line++;
 
        typelen = tag_line - type_line - strlen("type \n");
        if (typelen >= 20)
-               goto err;
+               return -1;
        taglen = sig_line - tag_line - strlen("tag \n");
        item->tag = xmalloc(taglen + 1);
        memcpy(item->tag, tag_line + 4, taglen);
        item->tag[taglen] = '\0';
 
-       free(data);
        return 0;
+}
 
-err:
+int parse_tag(struct tag *item)
+{
+       char type[20];
+       void *data;
+       unsigned long size;
+       int ret;
+
+       if (item->object.parsed)
+               return 0;
+       data = read_sha1_file(item->object.sha1, type, &size);
+       if (!data)
+               return error("Could not read %s",
+                            sha1_to_hex(item->object.sha1));
+       if (strcmp(type, tag_type)) {
+               free(data);
+               return error("Object %s not a tag",
+                            sha1_to_hex(item->object.sha1));
+       }
+       ret = parse_tag_buffer(item, data, size);
        free(data);
-       return -1;
+       return ret;
 }