git-gui: Improve our labeling of blame annotation types
[gitweb.git] / lib / blame.tcl
index 54a1ce5b45b4d65472412e6013c20af514e02ceb..0400d6effeca05aae2c0e49fd4036acbb93968aa 100644 (file)
@@ -26,8 +26,8 @@ field old_height ; # last known height of $w.file_pane
 
 # Tk UI colors
 #
-field active_color #c0edc5
-field group_colors {
+variable active_color #c0edc5
+variable group_colors {
        #d6d6d6
        #e1e1e1
        #ececec
@@ -42,11 +42,9 @@ field current_fd        {} ; # background process running
 field highlight_line    -1 ; # current line selected
 field highlight_column  {} ; # current commit column selected
 field highlight_commit  {} ; # sha1 of commit selected
-field old_bgcolor       {} ; # background of current selection
 
 field total_lines       0  ; # total length of file
 field blame_lines       0  ; # number of lines computed
-field have_commit          ; # array commit -> 1
 field amov_data            ; # list of {commit origfile origline}
 field asim_data            ; # list of {commit origfile origline}
 
@@ -56,12 +54,14 @@ field r_final_line         ; # final line number
 field r_line_count         ; # lines in this region
 
 field tooltip_wm        {} ; # Current tooltip toplevel, if open
+field tooltip_t         {} ; # Text widget in $tooltip_wm
 field tooltip_timer     {} ; # Current timer event for our tooltip
-field tooltip_commit    {} ; # Commit in tooltip
-field tooltip_text      {} ; # Text in current tooltip
+field tooltip_commit    {} ; # Commit(s) in tooltip
 
 constructor new {i_commit i_path} {
        global cursor_ptr
+       variable active_color
+       variable group_colors
 
        set commit $i_commit
        set path   $i_path
@@ -250,6 +250,10 @@ constructor new {i_commit i_path} {
                -command [cb _copycommit]
 
        foreach i $w_columns {
+               for {set g 0} {$g < [llength $group_colors]} {incr g} {
+                       $i tag conf color$g -background [lindex $group_colors $g]
+               }
+
                $i conf -cursor $cursor_ptr
                $i conf -yscrollcommand [list many2scrollbar \
                        $w_columns yview $w.file_pane.out.sby]
@@ -310,10 +314,12 @@ constructor new {i_commit i_path} {
        bind $w.file_pane <Configure> \
        "if {{$w.file_pane} eq {%W}} {[cb _resize %h]}"
 
-       _load $this
+       _load $this {}
 }
 
-method _load {} {
+method _load {jump} {
+       variable group_colors
+
        _hide_tooltip $this
 
        if {$total_lines != 0 || $current_fd ne {}} {
@@ -325,17 +331,22 @@ method _load {} {
                foreach i $w_columns {
                        $i conf -state normal
                        $i delete 0.0 end
-                       foreach cmit [array names have_commit] {
-                               $i tag delete g$cmit
+                       foreach g [$i tag names] {
+                               if {[regexp {^g[0-9a-f]{40}$} $g]} {
+                                       $i tag delete $g
+                               }
                        }
                        $i conf -state disabled
                }
 
+               $w_cviewer conf -state normal
+               $w_cviewer delete 0.0 end
+               $w_cviewer conf -state disabled
+
                set highlight_line -1
                set highlight_column {}
                set highlight_commit {}
                set total_lines 0
-               array unset have_commit
        }
 
        if {[winfo exists $w.status.c]} {
@@ -356,7 +367,6 @@ method _load {} {
        } else {
                $w_back conf -state normal
        }
-       lappend history [list $commit $path]
 
        # Index 0 is always empty.  There is never line 0 as
        # we use only 1 based lines, as that matches both with
@@ -374,7 +384,7 @@ method _load {} {
                set fd [open "| $cmd" r]
        }
        fconfigure $fd -blocking 0 -translation lf -encoding binary
-       fileevent $fd readable [cb _read_file $fd]
+       fileevent $fd readable [cb _read_file $fd $jump]
        set current_fd $fd
 }
 
@@ -386,7 +396,7 @@ method _history_menu {} {
                menu $m -tearoff 0
        }
 
-       for {set i [expr {[llength $history] - 2}]
+       for {set i [expr {[llength $history] - 1}]
                } {$i >= 0} {incr i -1} {
                set e [lindex $history $i]
                set c [lindex $e 0]
@@ -406,21 +416,22 @@ method _history_menu {} {
                        }
                }
 
-               $m add command -label $t -command [cb _goback $i $c $f]
+               $m add command -label $t -command [cb _goback $i]
        }
        set X [winfo rootx $w_back]
        set Y [expr {[winfo rooty $w_back] + [winfo height $w_back]}]
        tk_popup $m $X $Y
 }
 
-method _goback {i c f} {
+method _goback {i} {
+       set dat [lindex $history $i]
        set history [lrange $history 0 [expr {$i - 1}]]
-       set commit $c
-       set path $f
-       _load $this
+       set commit [lindex $dat 0]
+       set path [lindex $dat 1]
+       _load $this [lrange $dat 2 5]
 }
 
-method _read_file {fd} {
+method _read_file {fd jump} {
        if {$fd ne $current_fd} {
                catch {close $fd}
                return
@@ -450,7 +461,25 @@ method _read_file {fd} {
 
        if {[eof $fd]} {
                close $fd
-               _exec_blame $this $w_asim @asim_data [list] {}
+
+               # If we don't force Tk to update the widgets *right now*
+               # none of our jump commands will cause a change in the UI.
+               #
+               update
+
+               if {[llength $jump] == 1} {
+                       set highlight_line [lindex $jump 0]
+                       $w_file see "$highlight_line.0"
+               } elseif {[llength $jump] == 4} {
+                       set highlight_column [lindex $jump 0]
+                       set highlight_line [lindex $jump 1]
+                       $w_file xview moveto [lindex $jump 2]
+                       $w_file yview moveto [lindex $jump 3]
+               }
+
+               _exec_blame $this $w_asim @asim_data \
+                       [list] \
+                       { copy/move tracking}
        }
 } ifdeleted { catch {close $fd} }
 
@@ -474,6 +503,7 @@ method _exec_blame {cur_w cur_d options cur_s} {
 
 method _read_blame {fd cur_w cur_d cur_s} {
        upvar #0 $cur_d line_data
+       variable group_colors
 
        if {$fd ne $current_fd} {
                catch {close $fd}
@@ -488,20 +518,11 @@ method _read_blame {fd cur_w cur_d cur_s} {
                        set r_orig_line  $original_line
                        set r_final_line $final_line
                        set r_line_count $line_count
-
-                       if {[catch {set g $have_commit($cmit)}]} {
-                               set bg [lindex $group_colors 0]
-                               set group_colors [lrange $group_colors 1 end]
-                               lappend group_colors $bg
-                               foreach i $w_columns {
-                                       $i tag conf g$cmit -background $bg
-                               }
-                               set have_commit($cmit) 1
-                       }
                } elseif {[string match {filename *} $line]} {
                        set file [string range $line 9 end]
                        set n    $r_line_count
                        set lno  $r_final_line
+                       set oln  $r_orig_line
                        set cmit $r_commit
 
                        if {[regexp {^0{40}$} $cmit]} {
@@ -542,6 +563,30 @@ method _read_blame {fd cur_w cur_d cur_s} {
                                incr first_lno -1
                        }
 
+                       set color {}
+                       if {$first_lno < $lno} {
+                               foreach g [$w_file tag names $first_lno.0] {
+                                       if {[regexp {^color[0-9]+$} $g]} {
+                                               set color $g
+                                               break
+                                       }
+                               }
+                       } else {
+                               set i [lsort [concat \
+                                       [$w_file tag names "[expr {$first_lno - 1}].0"] \
+                                       [$w_file tag names "[expr {$lno + $n}].0"] \
+                                       ]]
+                               for {set g 0} {$g < [llength $group_colors]} {incr g} {
+                                       if {[lsearch -sorted -exact $i color$g] == -1} {
+                                               set color color$g
+                                               break
+                                       }
+                               }
+                       }
+                       if {$color eq {}} {
+                               set color color0
+                       }
+
                        while {$n > 0} {
                                set lno_e "$lno.0 lineend + 1c"
                                if {[lindex $line_data $lno] ne {}} {
@@ -550,7 +595,7 @@ method _read_blame {fd cur_w cur_d cur_s} {
                                                $i tag remove g$g $lno.0 $lno_e
                                        }
                                }
-                               lset line_data $lno [list $cmit $file]
+                               lset line_data $lno [list $cmit $file $oln]
 
                                $cur_w delete $lno.0 "$lno.0 lineend"
                                if {$lno == $first_lno} {
@@ -562,6 +607,14 @@ method _read_blame {fd cur_w cur_d cur_s} {
                                }
 
                                foreach i $w_columns {
+                                       if {$cur_w eq $w_amov} {
+                                               for {set g 0} \
+                                                       {$g < [llength $group_colors]} \
+                                                       {incr g} {
+                                                       $i tag remove color$g $lno.0 $lno_e
+                                               }
+                                               $i tag add $color $lno.0 $lno_e
+                                       }
                                        $i tag add g$cmit $lno.0 $lno_e
                                }
 
@@ -578,6 +631,7 @@ method _read_blame {fd cur_w cur_d cur_s} {
 
                                incr n -1
                                incr lno
+                               incr oln
                                incr blame_lines
                        }
 
@@ -594,6 +648,18 @@ method _read_blame {fd cur_w cur_d cur_s} {
                                } else {
                                        $cur_w insert $lno.0 { |}
                                }
+
+                               if {$cur_w eq $w_amov} {
+                                       foreach i $w_columns {
+                                               for {set g 0} \
+                                                       {$g < [llength $group_colors]} \
+                                                       {incr g} {
+                                                       $i tag remove color$g $lno.0 $lno_e
+                                               }
+                                               $i tag add $color $lno.0 $lno_e
+                                       }
+                               }
+
                                incr lno
                        }
 
@@ -608,7 +674,7 @@ method _read_blame {fd cur_w cur_d cur_s} {
                if {$cur_w eq $w_asim} {
                        _exec_blame $this $w_amov @amov_data \
                                [list -M -C -C] \
-                               { move/copy tracking}
+                               { original location}
                } else {
                        set current_fd {}
                        set status {Annotation complete.}
@@ -641,18 +707,27 @@ method _load_commit {cur_w cur_d pos} {
        set lno [lindex [split [$cur_w index $pos] .] 0]
        set dat [lindex $line_data $lno]
        if {$dat ne {}} {
+               lappend history [list \
+                       $commit $path \
+                       $highlight_column \
+                       $highlight_line \
+                       [lindex [$w_file xview] 0] \
+                       [lindex [$w_file yview] 0] \
+                       ]
                set commit [lindex $dat 0]
                set path   [lindex $dat 1]
-               _load $this
+               _load $this [list [lindex $dat 2]]
        }
 }
 
 method _showcommit {cur_w lno} {
        global repo_config
+       variable active_color
 
        if {$highlight_commit ne {}} {
                foreach i $w_columns {
-                       $i tag conf g$highlight_commit -background $old_bgcolor
+                       $i tag conf g$highlight_commit -background {}
+                       $i tag lower g$highlight_commit
                }
        }
 
@@ -674,9 +749,9 @@ method _showcommit {cur_w lno} {
                set cmit [lindex $dat 0]
                set file [lindex $dat 1]
 
-               set old_bgcolor [$w_file tag cget g$cmit -background]
                foreach i $w_columns {
                        $i tag conf g$cmit -background $active_color
+                       $i tag raise g$cmit
                }
 
                set author_name {}
@@ -746,7 +821,7 @@ method _showcommit {cur_w lno} {
        set highlight_line $lno
        set highlight_commit $cmit
 
-       if {$highlight_commit eq $tooltip_commit} {
+       if {[lsearch -exact $tooltip_commit $highlight_commit] != -1} {
                _hide_tooltip $this
        }
 }
@@ -765,26 +840,7 @@ method _copycommit {} {
 }
 
 method _show_tooltip {cur_w pos} {
-       set lno [lindex [split [$cur_w index $pos] .] 0]
-       if {$cur_w eq $w_amov} {
-               set dat [lindex $amov_data $lno]
-       } else {
-               set dat [lindex $asim_data $lno]
-       }
-       if {$dat eq {}} {
-               _hide_tooltip $this
-               return
-       }
-       set cmit [lindex $dat 0]
-
-       if {$cmit eq $highlight_commit} {
-               _hide_tooltip $this
-               return
-       }
-
-       if {$cmit eq $tooltip_commit} {
-               _position_tooltip $this
-       } elseif {$tooltip_wm ne {}} {
+       if {$tooltip_wm ne {}} {
                _open_tooltip $this $cur_w
        } elseif {$tooltip_timer eq {}} {
                set tooltip_timer [after 1000 [cb _open_tooltip $cur_w]]
@@ -800,70 +856,101 @@ method _open_tooltip {cur_w} {
                return
        }
 
+       if {$tooltip_wm ne "$cur_w.tooltip"} {
+               _hide_tooltip $this
+
+               set tooltip_wm [toplevel $cur_w.tooltip -borderwidth 1]
+               wm overrideredirect $tooltip_wm 1
+               wm transient $tooltip_wm [winfo toplevel $cur_w]
+               set tooltip_t $tooltip_wm.label
+               text $tooltip_t \
+                       -takefocus 0 \
+                       -highlightthickness 0 \
+                       -relief flat \
+                       -borderwidth 0 \
+                       -wrap none \
+                       -background lightyellow \
+                       -foreground black
+               $tooltip_t tag conf section_header -font font_uibold
+               pack $tooltip_t
+       } else {
+               $tooltip_t conf -state normal
+               $tooltip_t delete 0.0 end
+       }
+
        set pos @[join [list \
                [expr {$pos_x - [winfo rootx $cur_w]}] \
                [expr {$pos_y - [winfo rooty $cur_w]}]] ,]
        set lno [lindex [split [$cur_w index $pos] .] 0]
        if {$cur_w eq $w_amov} {
                set dat [lindex $amov_data $lno]
+               set org {}
        } else {
                set dat [lindex $asim_data $lno]
+               set org [lindex $amov_data $lno]
        }
+
        set cmit [lindex $dat 0]
-       set file [lindex $dat 1]
+       set tooltip_commit [list $cmit]
 
        set author_name {}
-       set author_email {}
+       set summary     {}
        set author_time {}
        catch {set author_name $header($cmit,author)}
-       catch {set author_email $header($cmit,author-mail)}
+       catch {set summary     $header($cmit,summary)}
        catch {set author_time [clock format \
                $header($cmit,author-time) \
                -format {%Y-%m-%d %H:%M:%S}
        ]}
 
-       set committer_name {}
-       set committer_email {}
-       set committer_time {}
-       catch {set committer_name $header($cmit,committer)}
-       catch {set committer_email $header($cmit,committer-mail)}
-       catch {set committer_time [clock format \
-               $header($cmit,committer-time) \
-               -format {%Y-%m-%d %H:%M:%S}
-       ]}
+       $tooltip_t insert end "commit $cmit\n"
+       $tooltip_t insert end "$author_name  $author_time\n"
+       $tooltip_t insert end "$summary"
 
-       set summary {}
-       catch {set summary $header($cmit,summary)}
+       if {$org ne {} && [lindex $org 0] ne $cmit} {
+               $tooltip_t insert 0.0 "Copied/Moved Here By:\n" section_header
+               set cmit [lindex $org 0]
+               set file [lindex $org 1]
+               lappend tooltip_commit $cmit
 
-       set tooltip_commit $cmit
-       set tooltip_text "commit $cmit
-$author_name $author_email  $author_time
-$summary"
+               set author_name {}
+               set summary     {}
+               set author_time {}
+               catch {set author_name $header($cmit,author)}
+               catch {set summary     $header($cmit,summary)}
+               catch {set author_time [clock format \
+                       $header($cmit,author-time) \
+                       -format {%Y-%m-%d %H:%M:%S}
+               ]}
 
-       if {$file ne $path} {
-               append tooltip_text "
+               $tooltip_t insert end "\n\n"
+               $tooltip_t insert end "Originally By:\n" section_header
+               $tooltip_t insert end "commit $cmit\n"
+               $tooltip_t insert end "$author_name  $author_time\n"
+               $tooltip_t insert end "$summary"
 
-Original File: $file"
+               if {$file ne $path} {
+                       $tooltip_t insert end "\n"
+                       $tooltip_t insert end "In File: " section_header
+                       $tooltip_t insert end $file
+               }
        }
 
-       if {$tooltip_wm ne "$cur_w.tooltip"} {
-               _hide_tooltip $this
-
-               set tooltip_wm [toplevel $cur_w.tooltip -borderwidth 1]
-               wm overrideredirect $tooltip_wm 1
-               wm transient $tooltip_wm [winfo toplevel $cur_w]
-               pack [label $tooltip_wm.label \
-                       -background lightyellow \
-                       -foreground black \
-                       -textvariable @tooltip_text \
-                       -justify left]
-       }
+       $tooltip_t conf -state disabled
        _position_tooltip $this
 }
 
 method _position_tooltip {} {
-       set req_w [winfo reqwidth  $tooltip_wm.label]
-       set req_h [winfo reqheight $tooltip_wm.label]
+       set max_h [lindex [split [$tooltip_t index end] .] 0]
+       set max_w 0
+       for {set i 1} {$i <= $max_h} {incr i} {
+               set c [lindex [split [$tooltip_t index "$i.0 lineend"] .] 1]
+               if {$c > $max_w} {set max_w $c}
+       }
+       $tooltip_t conf -width $max_w -height $max_h
+
+       set req_w [winfo reqwidth  $tooltip_t]
+       set req_h [winfo reqheight $tooltip_t]
        set pos_x [expr {[winfo pointerx .] +  5}]
        set pos_y [expr {[winfo pointery .] + 10}]