alloc_ref_from_str(): factor out a common pattern of alloc_ref from string

diff --git a/builtin-diff-files.c b/builtin-diff-files.c
index 6cb30c8e12488f42521df71a844a86a2e9a968c7..e2306c162a55df30042a0bf87c9a60a1e02f5396 100644 (file)
--- a/builtin-diff-files.c
+++ b/builtin-diff-files.c
@@ -16,12 +16,12 @@ COMMON_DIFF_OPTIONS_HELP;
 int cmd_diff_files(int argc, const char **argv, const char *prefix)
 {
        struct rev_info rev;
-       int nongit = 0;
+       int nongit;
        int result;
 
        prefix = setup_git_directory_gently(&nongit);
        init_revisions(&rev, prefix);
-       git_config(git_default_config); /* no "diff" UI options */
+       git_config(git_diff_basic_config); /* no "diff" UI options */
        rev.abbrev = 0;
 
        if (!setup_diff_no_index(&rev, argc, argv, nongit, prefix))
@@ -31,5 +31,5 @@ int cmd_diff_files(int argc, const char **argv, const char *prefix)
        if (!rev.diffopt.output_format)
                rev.diffopt.output_format = DIFF_FORMAT_RAW;
        result = run_diff_files_cmd(&rev, argc, argv);
-       return rev.diffopt.exit_with_status ? rev.diffopt.has_changes: result;
+       return diff_result_code(&rev.diffopt, result);
 }