git-apply: consider it an error to apply no changes

diff --git a/cat-file.c b/cat-file.c
index 3829fb6097ad9840cca7654f0b8a718100d590ac..be41f516664bc96ebec77c9ab88c3ab8df02ddfa 100644 (file)
--- a/cat-file.c
+++ b/cat-file.c
@@ -12,23 +12,24 @@ int main(int argc, char **argv)
        void *buf;
        unsigned long size;
 
-       if (argc != 3 || get_sha1_hex(argv[2], sha1))
-               usage("cat-file: cat-file [-t | tagname] <sha1>");
-       buf = read_sha1_file(sha1, type, &size);
-       if (!buf) {
-               fprintf(stderr, "cat-file %s: bad file\n", argv[2]);
-               exit(1);
-       }
+       if (argc != 3 || get_sha1(argv[2], sha1))
+               usage("git-cat-file [-t | tagname] <sha1>");
+
        if (!strcmp("-t", argv[1])) {
-               buf = type;
-               size = strlen(type);
-               type[size] = '\n';
-               size++;
-       } else if (strcmp(type, argv[1])) {
-               fprintf(stderr, "cat-file %s: bad tag\n", argv[2]);
-               exit(1);        /* bad tag */
+               buf = read_sha1_file(sha1, type, &size);
+               if (buf) {
+                       buf = type;
+                       size = strlen(type);
+                       type[size] = '\n';
+                       size++;
+               }
+       } else {
+               buf = read_object_with_reference(sha1, argv[1], &size, NULL);
        }
 
+       if (!buf)
+               die("git-cat-file %s: bad file", argv[2]);
+
        while (size > 0) {
                long ret = write(1, buf, size);
                if (ret < 0) {
@@ -37,12 +38,9 @@ int main(int argc, char **argv)
                        /* Ignore epipe */
                        if (errno == EPIPE)
                                break;
-                       fprintf(stderr, "cat-file: %s\n", strerror(errno));
-                       exit(1);
-               }
-               if (!ret) {
-                       fprintf(stderr, "cat-file: disk full?");
-                       exit(1);
+                       die("git-cat-file: %s", strerror(errno));
+               } else if (!ret) {
+                       die("git-cat-file: disk full?");
                }
                size -= ret;
                buf += ret;