Revert "Merge branch 'ps/contains-id-error-message' into next"

diff --git a/builtin/tag.c b/builtin/tag.c
index ca9910ba5fc43a0a5e4e6a129e4cf8f40a23de07..da186691ed8853bc5848c4106c752b015756eda3 100644 (file)
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -402,10 +402,10 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
 
                OPT_GROUP(N_("Tag listing options")),
                OPT_COLUMN(0, "column", &colopts, N_("show tag list in columns")),
-               OPT_CONTAINS(&filter.with_commit_strs, N_("print only tags that contain the commit")),
-               OPT_NO_CONTAINS(&filter.no_commit_strs, N_("print only tags that don't contain the commit")),
-               OPT_WITH(&filter.with_commit_strs, N_("print only tags that contain the commit")),
-               OPT_WITHOUT(&filter.no_commit_strs, N_("print only tags that don't contain the commit")),
+               OPT_CONTAINS(&filter.with_commit, N_("print only tags that contain the commit")),
+               OPT_NO_CONTAINS(&filter.no_commit, N_("print only tags that don't contain the commit")),
+               OPT_WITH(&filter.with_commit, N_("print only tags that contain the commit")),
+               OPT_WITHOUT(&filter.no_commit, N_("print only tags that don't contain the commit")),
                OPT_MERGED(&filter, N_("print only tags that are merged")),
                OPT_NO_MERGED(&filter, N_("print only tags that are not merged")),
                OPT_CALLBACK(0 , "sort", sorting_tail, N_("key"),
@@ -441,8 +441,8 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
        if (!cmdmode) {
                if (argc == 0)
                        cmdmode = 'l';
-               else if (filter.points_at.nr || filter.merge_commit ||
-                        filter.with_commit_strs.nr || filter.no_commit_strs.nr ||
+               else if (filter.with_commit || filter.no_commit ||
+                        filter.points_at.nr || filter.merge_commit ||
                         filter.lines != -1)
                        cmdmode = 'l';
        }
@@ -479,9 +479,9 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
        }
        if (filter.lines != -1)
                die(_("-n option is only allowed in list mode"));
-       if (filter.with_commit_strs.nr)
+       if (filter.with_commit)
                die(_("--contains option is only allowed in list mode"));
-       if (filter.no_commit_strs.nr)
+       if (filter.no_commit)
                die(_("--no-contains option is only allowed in list mode"));
        if (filter.points_at.nr)
                die(_("--points-at option is only allowed in list mode"));