pull: check if in unresolved merge state

diff --git a/help.c b/help.c
index f81309319de1b4bc7f46f31d2a9e46f36cb5fd0b..80ca8ee68d5af25b43314d351bc7ad09d9d9d03b 100644 (file)
--- a/help.c
+++ b/help.c
@@ -218,17 +218,39 @@ void list_commands(unsigned int colopts,
        }
 }
 
+static int cmd_group_cmp(const void *elem1, const void *elem2)
+{
+       const struct cmdname_help *e1 = elem1;
+       const struct cmdname_help *e2 = elem2;
+
+       if (e1->group < e2->group)
+               return -1;
+       if (e1->group > e2->group)
+               return 1;
+       return strcmp(e1->name, e2->name);
+}
+
 void list_common_cmds_help(void)
 {
        int i, longest = 0;
+       int current_grp = -1;
 
        for (i = 0; i < ARRAY_SIZE(common_cmds); i++) {
                if (longest < strlen(common_cmds[i].name))
                        longest = strlen(common_cmds[i].name);
        }
 
-       puts(_("The most commonly used git commands are:"));
+       qsort(common_cmds, ARRAY_SIZE(common_cmds),
+               sizeof(common_cmds[0]), cmd_group_cmp);
+
+       puts(_("These are common Git commands used in various situations:"));
+
        for (i = 0; i < ARRAY_SIZE(common_cmds); i++) {
+               if (common_cmds[i].group != current_grp) {
+                       printf("\n%s\n", _(common_cmd_groups[common_cmds[i].group]));
+                       current_grp = common_cmds[i].group;
+               }
+
                printf("   %s   ", common_cmds[i].name);
                mput_char(' ', longest - strlen(common_cmds[i].name));
                puts(_(common_cmds[i].help));
@@ -407,7 +429,7 @@ struct similar_ref_cb {
        struct string_list *similar_refs;
 };
 
-static int append_similar_ref(const char *refname, const unsigned char *sha1,
+static int append_similar_ref(const char *refname, const struct object_id *oid,
                              int flags, void *cb_data)
 {
        struct similar_ref_cb *cb = (struct similar_ref_cb *)(cb_data);
@@ -425,12 +447,10 @@ static struct string_list guess_refs(const char *ref)
 {
        struct similar_ref_cb ref_cb;
        struct string_list similar_refs = STRING_LIST_INIT_NODUP;
-       struct each_ref_fn_sha1_adapter wrapped_append_similar_ref =
-               {append_similar_ref, &ref_cb};
 
        ref_cb.base_ref = ref;
        ref_cb.similar_refs = &similar_refs;
-       for_each_ref(each_ref_fn_adapter, &wrapped_append_similar_ref);
+       for_each_ref(append_similar_ref, &ref_cb);
        return similar_refs;
 }