diagnose_invalid_index_path: use strbuf to avoid strcpy/strcat

diff --git a/transport-helper.c b/transport-helper.c
index fd5723f5280577f66d2a03f13c50c7f5c6589b10..99f1ace1f2b56c359eba6736d1f0ab0fb49ba980 100644 (file)
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -489,7 +489,8 @@ static int fetch_with_import(struct transport *transport,
                else
                        private = xstrdup(name);
                if (private) {
-                       read_ref(private, posn->old_sha1);
+                       if (read_ref(private, posn->old_sha1) < 0)
+                               die("Could not read ref %s", private);
                        free(private);
                }
        }
@@ -1019,7 +1020,10 @@ static struct ref *get_refs_list(struct transport *transport, int for_push)
                if (eon) {
                        if (has_attribute(eon + 1, "unchanged")) {
                                (*tail)->status |= REF_STATUS_UPTODATE;
-                               read_ref((*tail)->name, (*tail)->old_sha1);
+                               if (read_ref((*tail)->name,
+                                            (*tail)->old_sha1) < 0)
+                                       die(N_("Could not read ref %s"),
+                                           (*tail)->name);
                        }
                }
                tail = &((*tail)->next);