Make fetch/pull scripts terminate cleanly on errors

diff --git a/rev-list.c b/rev-list.c
index cbfc5c439d7b40c6804356a8288735b241d51a2f..c27b138f3a16fbe689376959ffd62e898b4d8756 100644 (file)
--- a/rev-list.c
+++ b/rev-list.c
@@ -1,9 +1,9 @@
 #include "cache.h"
 #include "commit.h"
+#include "epoch.h"
 
 #define SEEN           (1u << 0)
 #define INTERESTING    (1u << 1)
-#define UNINTERESTING  (1u << 2)
 
 static const char rev_list_usage[] =
        "usage: git-rev-list [OPTION] commit-id <commit-id>\n"
@@ -11,19 +11,30 @@ static const char rev_list_usage[] =
                      "  --max-age=epoch\n"
                      "  --min-age=epoch\n"
                      "  --header\n"
-                     "  --pretty";
+                     "  --pretty\n"
+                     "  --merge-order [ --show-breaks ]";
 
 static int verbose_header = 0;
 static int show_parents = 0;
-static int pretty_print = 0;
 static int hdr_termination = 0;
 static const char *prefix = "";
 static unsigned long max_age = -1;
 static unsigned long min_age = -1;
 static int max_count = -1;
+static enum cmit_fmt commit_format = CMIT_FMT_RAW;
+static int merge_order = 0;
+static int show_breaks = 0;
 
 static void show_commit(struct commit *commit)
 {
+       if (show_breaks) {
+               prefix = "| ";
+               if (commit->object.flags & DISCONTINUITY) {
+                       prefix = "^ ";     
+               } else if (commit->object.flags & BOUNDARY) {
+                       prefix = "= ";
+               } 
+        }                      
        printf("%s%s", prefix, sha1_to_hex(commit->object.sha1));
        if (show_parents) {
                struct commit_list *parents = commit->parents;
@@ -34,14 +45,41 @@ static void show_commit(struct commit *commit)
        }
        putchar('\n');
        if (verbose_header) {
-               const char *buf = commit->buffer;
-               if (pretty_print) {
-                       static char pretty_header[16384];
-                       pretty_print_commit(commit->buffer, ~0, pretty_header, sizeof(pretty_header));
-                       buf = pretty_header;
-               }
-               printf("%s%c", buf, hdr_termination);
+               static char pretty_header[16384];
+               pretty_print_commit(commit_format, commit->buffer, ~0, pretty_header, sizeof(pretty_header));
+               printf("%s%c", pretty_header, hdr_termination);
+       }       
+}
+
+static int filter_commit(struct commit * commit)
+{
+       if (commit->object.flags & UNINTERESTING)
+               return CONTINUE;
+       if (min_age != -1 && (commit->date > min_age))
+               return CONTINUE;
+       if (max_age != -1 && (commit->date < max_age))
+               return STOP;
+       if (max_count != -1 && !max_count--)
+               return STOP;
+
+       return DO;
+}
+
+static int process_commit(struct commit * commit)
+{
+       int action=filter_commit(commit);
+
+       if (action == STOP) {
+               return STOP;
+       }
+
+       if (action == CONTINUE) {
+               return CONTINUE;
        }
+
+       show_commit(commit);
+
+       return CONTINUE;
 }
 
 static void show_commit_list(struct commit_list *list)
@@ -49,15 +87,8 @@ static void show_commit_list(struct commit_list *list)
        while (list) {
                struct commit *commit = pop_most_recent_commit(&list, SEEN);
 
-               if (commit->object.flags & UNINTERESTING)
-                       continue;
-               if (min_age != -1 && (commit->date > min_age))
-                       continue;
-               if (max_age != -1 && (commit->date < max_age))
-                       break;
-               if (max_count != -1 && !max_count--)
+               if (process_commit(commit) == STOP)
                        break;
-               show_commit(commit);
        }
 }
 
@@ -103,6 +134,20 @@ struct commit_list *limit_list(struct commit_list *list)
        return newlist;
 }
 
+static enum cmit_fmt get_commit_format(const char *arg)
+{
+       if (!*arg)
+               return CMIT_FMT_DEFAULT;
+       if (!strcmp(arg, "=raw"))
+               return CMIT_FMT_RAW;
+       if (!strcmp(arg, "=medium"))
+               return CMIT_FMT_MEDIUM;
+       if (!strcmp(arg, "=short"))
+               return CMIT_FMT_SHORT;
+       usage(rev_list_usage);  
+}                      
+
+
 int main(int argc, char **argv)
 {
        struct commit_list *list = NULL;
@@ -130,9 +175,9 @@ int main(int argc, char **argv)
                        verbose_header = 1;
                        continue;
                }
-               if (!strcmp(arg, "--pretty")) {
+               if (!strncmp(arg, "--pretty", 8)) {
+                       commit_format = get_commit_format(arg+8);
                        verbose_header = 1;
-                       pretty_print = 1;
                        hdr_termination = '\n';
                        prefix = "commit ";
                        continue;
@@ -141,6 +186,14 @@ int main(int argc, char **argv)
                        show_parents = 1;
                        continue;
                }
+               if (!strncmp(arg, "--merge-order", 13)) {
+                       merge_order = 1;
+                       continue;
+               }
+               if (!strncmp(arg, "--show-breaks", 13)) {
+                       show_breaks = 1;
+                       continue;
+               }
 
                flags = 0;
                if (*arg == '^') {
@@ -148,7 +201,7 @@ int main(int argc, char **argv)
                        arg++;
                        limited = 1;
                }
-               if (get_sha1(arg, sha1))
+               if (get_sha1(arg, sha1) || (show_breaks && !merge_order))
                        usage(rev_list_usage);
                commit = lookup_commit_reference(sha1);
                if (!commit || parse_commit(commit) < 0)
@@ -160,9 +213,19 @@ int main(int argc, char **argv)
        if (!list)
                usage(rev_list_usage);
 
-       if (limited)
-               list = limit_list(list);
+       if (!merge_order) {             
+       
+               if (limited) 
+                       list = limit_list(list);
+               show_commit_list(list);
+                       
+       } else {
+               
+               if (sort_list_in_merge_order(list, &process_commit)) {
+                         die("merge order sort failed\n");
+               }
+                                       
+       }
 
-       show_commit_list(list);
        return 0;
 }