Give no terminating LF to error() function.
[gitweb.git] / update-index.c
index a84836be4a0cd32a61d4ae35c8ce3b0108ad5a34..afec98dd48f59e095c0884c821c85b7228b45201 100644 (file)
@@ -256,35 +256,30 @@ static int verify_path(const char *path)
        }
 }
 
-static int add_cacheinfo(const char *arg1, const char *arg2, const char *arg3)
+static int add_cacheinfo(unsigned int mode, const unsigned char *sha1,
+                        const char *path, int stage)
 {
        int size, len, option;
-       unsigned int mode;
-       unsigned char sha1[20];
        struct cache_entry *ce;
 
-       if (sscanf(arg1, "%o", &mode) != 1)
-               return -1;
-       if (get_sha1_hex(arg2, sha1))
-               return -1;
-       if (!verify_path(arg3))
+       if (!verify_path(path))
                return -1;
 
-       len = strlen(arg3);
+       len = strlen(path);
        size = cache_entry_size(len);
        ce = xmalloc(size);
        memset(ce, 0, size);
 
        memcpy(ce->sha1, sha1, 20);
-       memcpy(ce->name, arg3, len);
-       ce->ce_flags = htons(len);
+       memcpy(ce->name, path, len);
+       ce->ce_flags = create_ce_flags(len, stage);
        ce->ce_mode = create_ce_mode(mode);
        option = allow_add ? ADD_CACHE_OK_TO_ADD : 0;
        option |= allow_replace ? ADD_CACHE_OK_TO_REPLACE : 0;
        if (add_cache_entry(ce, option))
                return error("%s: cannot add to the index - missing --add option?",
-                            arg3);
-       report("add '%s'", arg3);
+                            path);
+       report("add '%s'", path);
        return 0;
 }
 
@@ -338,22 +333,52 @@ static void read_index_info(int line_termination)
        struct strbuf buf;
        strbuf_init(&buf);
        while (1) {
-               char *ptr;
+               char *ptr, *tab;
                char *path_name;
                unsigned char sha1[20];
                unsigned int mode;
-
+               int stage;
+
+               /* This reads lines formatted in one of three formats:
+                *
+                * (1) mode         SP sha1          TAB path
+                * The first format is what "git-apply --index-info"
+                * reports, and used to reconstruct a partial tree
+                * that is used for phony merge base tree when falling
+                * back on 3-way merge.
+                *
+                * (2) mode SP type SP sha1          TAB path
+                * The second format is to stuff git-ls-tree output
+                * into the index file.
+                * 
+                * (3) mode         SP sha1 SP stage TAB path
+                * This format is to put higher order stages into the
+                * index file and matches git-ls-files --stage output.
+                */
                read_line(&buf, stdin, line_termination);
                if (buf.eof)
                        break;
 
                mode = strtoul(buf.buf, &ptr, 8);
-               if (ptr == buf.buf || *ptr != ' ' ||
-                   get_sha1_hex(ptr + 1, sha1) ||
-                   ptr[41] != '\t')
+               if (ptr == buf.buf || *ptr != ' ')
+                       goto bad_line;
+
+               tab = strchr(ptr, '\t');
+               if (!tab || tab - ptr < 41)
                        goto bad_line;
 
-               ptr += 42;
+               if (tab[-2] == ' ' && '0' <= tab[-1] && tab[-1] <= '3') {
+                       stage = tab[-1] - '0';
+                       ptr = tab + 1; /* point at the head of path */
+                       tab = tab - 2; /* point at tail of sha1 */
+               }
+               else {
+                       stage = 0;
+                       ptr = tab + 1; /* point at the head of path */
+               }
+
+               if (get_sha1_hex(tab - 40, sha1) || tab[-41] != ' ')
+                       goto bad_line;
 
                if (line_termination && ptr[0] == '"')
                        path_name = unquote_c_style(ptr, NULL);
@@ -379,7 +404,7 @@ static void read_index_info(int line_termination)
                         * ptr[-41] is at the beginning of sha1
                         */
                        ptr[-42] = ptr[-1] = 0;
-                       if (add_cacheinfo(buf.buf, ptr-41, path_name))
+                       if (add_cacheinfo(mode, sha1, path_name, stage))
                                die("git-update-index: unable to update %s",
                                    path_name);
                }
@@ -392,6 +417,9 @@ static void read_index_info(int line_termination)
        }
 }
 
+static const char update_index_usage[] =
+"git-update-index [-q] [--add] [--replace] [--remove] [--unmerged] [--refresh] [--cacheinfo] [--chmod=(+|-)x] [--info-only] [--force-remove] [--stdin] [--index-info] [--ignore-missing] [-z] [--verbose] [--] <file>...";
+
 int main(int argc, const char **argv)
 {
        int i, newfd, entries, has_errors = 0, line_termination = '\n';
@@ -443,10 +471,17 @@ int main(int argc, const char **argv)
                                continue;
                        }
                        if (!strcmp(path, "--cacheinfo")) {
+                               unsigned char sha1[20];
+                               unsigned int mode;
+
                                if (i+3 >= argc)
                                        die("git-update-index: --cacheinfo <mode> <sha1> <path>");
-                               if (add_cacheinfo(argv[i+1], argv[i+2], argv[i+3]))
-                                       die("git-update-index: --cacheinfo cannot add %s", argv[i+3]);
+
+                               if ((sscanf(argv[i+1], "%o", &mode) != 1) ||
+                                   get_sha1_hex(argv[i+2], sha1) ||
+                                   add_cacheinfo(mode, sha1, argv[i+3], 0))
+                                       die("git-update-index: --cacheinfo"
+                                           " cannot add %s", argv[i+3]);
                                i += 3;
                                continue;
                        }
@@ -489,6 +524,8 @@ int main(int argc, const char **argv)
                                verbose = 1;
                                continue;
                        }
+                       if (!strcmp(path, "-h") || !strcmp(path, "--help"))
+                               usage(update_index_usage);
                        die("unknown option %s", path);
                }
                update_one(path, prefix, prefix_length);
@@ -497,10 +534,17 @@ int main(int argc, const char **argv)
                struct strbuf buf;
                strbuf_init(&buf);
                while (1) {
+                       char *path_name;
                        read_line(&buf, stdin, line_termination);
                        if (buf.eof)
                                break;
-                       update_one(buf.buf, prefix, prefix_length);
+                       if (line_termination && buf.buf[0] == '"')
+                               path_name = unquote_c_style(buf.buf, NULL);
+                       else
+                               path_name = buf.buf;
+                       update_one(path_name, prefix, prefix_length);
+                       if (path_name != buf.buf)
+                               free(path_name);
                }
        }
        if (active_cache_changed) {