Merge branch 'js/diff-highlight-avoid-sigpipe'

diff --git a/builtin/prune-packed.c b/builtin/prune-packed.c
index fa6ce42f44f82d34299f2dc0109be4d831cb3d48..f24a2c2bdca81fd2cb6d7b4968e46ad6922a9c9f 100644 (file)
--- a/builtin/prune-packed.c
+++ b/builtin/prune-packed.c
@@ -10,59 +10,41 @@ static const char * const prune_packed_usage[] = {
 
 static struct progress *progress;
 
-static void prune_dir(int i, DIR *dir, char *pathname, int len, int opts)
+static int prune_subdir(int nr, const char *path, void *data)
 {
-       struct dirent *de;
-       char hex[40];
+       int *opts = data;
+       display_progress(progress, nr + 1);
+       if (!(*opts & PRUNE_PACKED_DRY_RUN))
+               rmdir(path);
+       return 0;
+}
+
+static int prune_object(const unsigned char *sha1, const char *path,
+                        void *data)
+{
+       int *opts = data;
 
-       sprintf(hex, "%02x", i);
-       while ((de = readdir(dir)) != NULL) {
-               unsigned char sha1[20];
-               if (strlen(de->d_name) != 38)
-                       continue;
-               memcpy(hex+2, de->d_name, 38);
-               if (get_sha1_hex(hex, sha1))
-                       continue;
-               if (!has_sha1_pack(sha1))
-                       continue;
-               memcpy(pathname + len, de->d_name, 38);
-               if (opts & PRUNE_PACKED_DRY_RUN)
-                       printf("rm -f %s\n", pathname);
-               else
-                       unlink_or_warn(pathname);
-               display_progress(progress, i + 1);
-       }
+       if (!has_sha1_pack(sha1))
+               return 0;
+
+       if (*opts & PRUNE_PACKED_DRY_RUN)
+               printf("rm -f %s\n", path);
+       else
+               unlink_or_warn(path);
+       return 0;
 }
 
 void prune_packed_objects(int opts)
 {
-       int i;
-       static char pathname[PATH_MAX];
-       const char *dir = get_object_directory();
-       int len = strlen(dir);
-
        if (opts & PRUNE_PACKED_VERBOSE)
-               progress = start_progress_delay("Removing duplicate objects",
+               progress = start_progress_delay(_("Removing duplicate objects"),
                        256, 95, 2);
 
-       if (len > PATH_MAX - 42)
-               die("impossible object directory");
-       memcpy(pathname, dir, len);
-       if (len && pathname[len-1] != '/')
-               pathname[len++] = '/';
-       for (i = 0; i < 256; i++) {
-               DIR *d;
+       for_each_loose_file_in_objdir(get_object_directory(),
+                                     prune_object, NULL, prune_subdir, &opts);
 
-               display_progress(progress, i + 1);
-               sprintf(pathname + len, "%02x/", i);
-               d = opendir(pathname);
-               if (!d)
-                       continue;
-               prune_dir(i, d, pathname, len + 3, opts);
-               closedir(d);
-               pathname[len + 2] = '\0';
-               rmdir(pathname);
-       }
+       /* Ensure we show 100% before finishing progress */
+       display_progress(progress, 256);
        stop_progress(&progress);
 }