test-lib: tests skipped by GIT_SKIP_TESTS say so

diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
index 10be52beedb4058318555e096d51517f1c30ad9f..ae8874e0b59a0e9ba57373a49b9f38c066135fc7 100755 (executable)
--- a/t/t0000-basic.sh
+++ b/t/t0000-basic.sh
@@ -41,20 +41,17 @@ test_expect_success '.git/objects should have 3 subdirectories' '
 test_expect_success 'success is reported like this' '
        :
 '
-test_expect_failure 'pretend we have a known breakage' '
-       false
-'
 
 run_sub_test_lib_test () {
        name="$1" descr="$2" # stdin is the body of the test code
        shift 2
        mkdir "$name" &&
        (
-               # Pretend we're a test harness.  This prevents
-               # test-lib from writing the counts to a file that will
-               # later be summarized, showing spurious "failed" tests
-               HARNESS_ACTIVE=t &&
-               export HARNESS_ACTIVE &&
+               # Pretend we're not running under a test harness, whether we
+               # are or not. The test-lib output depends on the setting of
+               # this variable, so we need a stable setting under which to run
+               # the sub-test.
+               sane_unset HARNESS_ACTIVE &&
                cd "$name" &&
                cat >"$name.sh" <<-EOF &&
                #!$SHELL_PATH
@@ -71,6 +68,8 @@ run_sub_test_lib_test () {
                cat >>"$name.sh" &&
                chmod +x "$name.sh" &&
                export TEST_DIRECTORY &&
+               TEST_OUTPUT_DIRECTORY=$(pwd) &&
+               export TEST_OUTPUT_DIRECTORY &&
                ./"$name.sh" "$@" >out 2>err
        )
 }
@@ -233,16 +232,13 @@ test_expect_success 'test --verbose' '
        grep -v "^Initialized empty" test-verbose/out+ >test-verbose/out &&
        check_sub_test_lib_test test-verbose <<-\EOF
        > expecting success: true
-       > Z
        > ok 1 - passing test
        > Z
        > expecting success: echo foo
        > foo
-       > Z
        > ok 2 - test with output
        > Z
        > expecting success: false
-       > Z
        > not ok 3 - failing test
        > #     false
        > Z
@@ -265,7 +261,6 @@ test_expect_success 'test --verbose-only' '
        > Z
        > expecting success: echo foo
        > foo
-       > Z
        > ok 2 - test with output
        > Z
        > not ok 3 - failing test
@@ -275,6 +270,69 @@ test_expect_success 'test --verbose-only' '
        EOF
 '
 
+test_expect_success 'GIT_SKIP_TESTS' "
+       GIT_SKIP_TESTS='git.2' \
+               run_sub_test_lib_test git-skip-tests-basic \
+               'GIT_SKIP_TESTS' <<-\\EOF &&
+       for i in 1 2 3
+       do
+               test_expect_success \"passing test #\$i\" 'true'
+       done
+       test_done
+       EOF
+       check_sub_test_lib_test git-skip-tests-basic <<-\\EOF
+       > ok 1 - passing test #1
+       > ok 2 # skip passing test #2 (GIT_SKIP_TESTS)
+       > ok 3 - passing test #3
+       > # passed all 3 test(s)
+       > 1..3
+       EOF
+"
+
+test_expect_success 'GIT_SKIP_TESTS several tests' "
+       GIT_SKIP_TESTS='git.2 git.5' \
+               run_sub_test_lib_test git-skip-tests-several \
+               'GIT_SKIP_TESTS several tests' <<-\\EOF &&
+       for i in 1 2 3 4 5 6
+       do
+               test_expect_success \"passing test #\$i\" 'true'
+       done
+       test_done
+       EOF
+       check_sub_test_lib_test git-skip-tests-several <<-\\EOF
+       > ok 1 - passing test #1
+       > ok 2 # skip passing test #2 (GIT_SKIP_TESTS)
+       > ok 3 - passing test #3
+       > ok 4 - passing test #4
+       > ok 5 # skip passing test #5 (GIT_SKIP_TESTS)
+       > ok 6 - passing test #6
+       > # passed all 6 test(s)
+       > 1..6
+       EOF
+"
+
+test_expect_success 'GIT_SKIP_TESTS sh pattern' "
+       GIT_SKIP_TESTS='git.[2-5]' \
+               run_sub_test_lib_test git-skip-tests-sh-pattern \
+               'GIT_SKIP_TESTS sh pattern' <<-\\EOF &&
+       for i in 1 2 3 4 5 6
+       do
+               test_expect_success \"passing test #\$i\" 'true'
+       done
+       test_done
+       EOF
+       check_sub_test_lib_test git-skip-tests-sh-pattern <<-\\EOF
+       > ok 1 - passing test #1
+       > ok 2 # skip passing test #2 (GIT_SKIP_TESTS)
+       > ok 3 # skip passing test #3 (GIT_SKIP_TESTS)
+       > ok 4 # skip passing test #4 (GIT_SKIP_TESTS)
+       > ok 5 # skip passing test #5 (GIT_SKIP_TESTS)
+       > ok 6 - passing test #6
+       > # passed all 6 test(s)
+       > 1..6
+       EOF
+"
+
 test_set_prereq HAVEIT
 haveit=no
 test_expect_success HAVEIT 'test runs if prerequisite is satisfied' '