tempfile: handle NULL tempfile pointers gracefully

diff --git a/gpg-interface.c b/gpg-interface.c
index d936f3a32fe5d38c2b41ae0488ac2c02250a1618..4ea2597ff4cb304c82419eb515b07a04673b7f5f 100644 (file)
--- a/gpg-interface.c
+++ b/gpg-interface.c
@@ -209,13 +209,13 @@ int verify_signed_buffer(const char *payload, size_t payload_size,
        fd = mks_tempfile_t(&temp, ".git_vtag_tmpXXXXXX");
        if (fd < 0)
                return error_errno(_("could not create temporary file"));
-       if (write_in_full(fd, signature, signature_size) < 0) {
+       if (write_in_full(fd, signature, signature_size) < 0 ||
+           close_tempfile_gently(&temp) < 0) {
                error_errno(_("failed writing detached signature to '%s'"),
                            temp.filename.buf);
                delete_tempfile(&temp);
                return -1;
        }
-       close(fd);
 
        argv_array_pushl(&gpg.args,
                         gpg_program,