Make git-rev-list and git-rev-parse argument parsing stricter

diff --git a/test-delta.c b/test-delta.c
index 8751e27c6b2acd875803402383e50dbab56d3e56..1be8ee0c721ec35372fee4e686d9664b143b4345 100644 (file)
--- a/test-delta.c
+++ b/test-delta.c
@@ -17,7 +17,7 @@
 #include <sys/mman.h>
 #include "delta.h"
 
-static const char *usage =
+static const char usage[] =
        "test-delta (-d|-p) <from_file> <data_file> <out_file>";
 
 int main(int argc, char *argv[])
@@ -41,6 +41,7 @@ int main(int argc, char *argv[])
        from_buf = mmap(NULL, from_size, PROT_READ, MAP_PRIVATE, fd, 0);
        if (from_buf == MAP_FAILED) {
                perror(argv[2]);
+               close(fd);
                return 1;
        }
        close(fd);
@@ -54,16 +55,19 @@ int main(int argc, char *argv[])
        data_buf = mmap(NULL, data_size, PROT_READ, MAP_PRIVATE, fd, 0);
        if (data_buf == MAP_FAILED) {
                perror(argv[3]);
+               close(fd);
                return 1;
        }
        close(fd);
 
        if (argv[1][1] == 'd')
                out_buf = diff_delta(from_buf, from_size,
-                                    data_buf, data_size, &out_size);
+                                    data_buf, data_size,
+                                    &out_size, 0);
        else
                out_buf = patch_delta(from_buf, from_size,
-                                     data_buf, data_size, &out_size);
+                                     data_buf, data_size,
+                                     &out_size);
        if (!out_buf) {
                fprintf(stderr, "delta operation failed (returned NULL)\n");
                return 1;