Fix potential command line overflow in hooks--update

diff --git a/var.c b/var.c
index 51cf86a5843acc3b6bc3d8c4be9fec0fdd0a0df5..e585e59d315061e2e82ea8a23843c128bcce2555 100644 (file)
--- a/var.c
+++ b/var.c
@@ -4,15 +4,12 @@
  * Copyright (C) Eric Biederman, 2005
  */
 #include "cache.h"
-#include <stdio.h>
-#include <errno.h>
-#include <string.h>
 
 static const char var_usage[] = "git-var [-l | <variable>]";
 
 struct git_var {
        const char *name;
-       char *(*read)(void);
+       const char *(*read)(int);
 };
 static struct git_var git_vars[] = {
        { "GIT_COMMITTER_IDENT", git_committer_info },
@@ -24,7 +21,7 @@ static void list_vars(void)
 {
        struct git_var *ptr;
        for(ptr = git_vars; ptr->read; ptr++) {
-               printf("%s=%s\n", ptr->name, ptr->read());
+               printf("%s=%s\n", ptr->name, ptr->read(0));
        }
 }
 
@@ -35,7 +32,7 @@ static const char *read_var(const char *var)
        val = NULL;
        for(ptr = git_vars; ptr->read; ptr++) {
                if (strcmp(var, ptr->name) == 0) {
-                       val = ptr->read();
+                       val = ptr->read(1);
                        break;
                }
        }
@@ -57,7 +54,8 @@ int main(int argc, char **argv)
        if (argc != 2) {
                usage(var_usage);
        }
-       setup_ident();
+
+       setup_git_directory();
        val = NULL;
 
        if (strcmp(argv[1], "-l") == 0) {