commit: --amend -m '' silently fails to wipe message

diff --git a/combine-diff.c b/combine-diff.c
index d777e92aa07019cb0f3f5ac79627c00ffe014dd7..5cae5fbd62180e08709d404cbf357adceb1d4d06 100644 (file)
--- a/combine-diff.c
+++ b/combine-diff.c
@@ -419,8 +419,10 @@ static void combine_diff(const unsigned char *parent, unsigned int mode,
        state.num_parent = num_parent;
        state.n = n;
 
-       xdi_diff_outf(&parent_file, result_file, consume_line, &state,
-                     &xpp, &xecfg);
+       if (xdi_diff_outf(&parent_file, result_file, consume_line, &state,
+                         &xpp, &xecfg))
+               die("unable to generate combined diff for %s",
+                   sha1_to_hex(parent));
        free(parent_file.ptr);
 
        /* Assign line numbers for this parent.