[PATCH] fetch.c: Remove some duplicated code in process()

diff --git a/daemon.c b/daemon.c
index eeff9e7b05fc9e84f8fef06a5322f9fbb3ec9eb2..5100cf2f44d735c0e46aba74dff1504cc3c36ec6 100644 (file)
--- a/daemon.c
+++ b/daemon.c
@@ -3,6 +3,7 @@
 #include <signal.h>
 #include <sys/wait.h>
 #include <sys/socket.h>
+#include <sys/time.h>
 #include <netdb.h>
 #include <netinet/in.h>
 
@@ -71,19 +72,19 @@ static int max_connections = 25;
 
 /* These are updated by the signal handler */
 static volatile unsigned int children_reaped = 0;
-pid_t dead_child[MAX_CHILDREN];
+static pid_t dead_child[MAX_CHILDREN];
 
 /* These are updated by the main loop */
 static unsigned int children_spawned = 0;
 static unsigned int children_deleted = 0;
 
-struct child {
+static struct child {
        pid_t pid;
-       socklen_t addrlen;
+       int addrlen;
        struct sockaddr_storage address;
 } live_child[MAX_CHILDREN];
 
-static void add_child(int idx, pid_t pid, struct sockaddr *addr, socklen_t addrlen)
+static void add_child(int idx, pid_t pid, struct sockaddr *addr, int addrlen)
 {
        live_child[idx].pid = pid;
        live_child[idx].addrlen = addrlen;
@@ -177,7 +178,7 @@ static void check_max_connections(void)
        }
 }
 
-static void handle(int incoming, struct sockaddr *addr, socklen_t addrlen)
+static void handle(int incoming, struct sockaddr *addr, int addrlen)
 {
        pid_t pid = fork();
 
@@ -294,8 +295,11 @@ static int serve(int port)
                fds = fds_init;
                
                if (select(maxfd + 1, &fds, NULL, NULL, NULL) < 0) {
-                       error("select failed, resuming: %s", strerror(errno));
-                       sleep(1);
+                       if (errno != EINTR) {
+                               error("select failed, resuming: %s",
+                                     strerror(errno));
+                               sleep(1);
+                       }
                        continue;
                }
 
@@ -304,7 +308,7 @@ static int serve(int port)
 
                        if (FD_ISSET(sockfd, &fds)) {
                                struct sockaddr_storage ss;
-                               socklen_t sslen = sizeof(ss);
+                               int sslen = sizeof(ss);
                                int incoming = accept(sockfd, (struct sockaddr *)&ss, &sslen);
                                if (incoming < 0) {
                                        switch (errno) {
@@ -349,8 +353,10 @@ int main(int argc, char **argv)
                usage(daemon_usage);
        }
 
-       if (inetd_mode)
+       if (inetd_mode) {
+               fclose(stderr); //FIXME: workaround
                return execute();
+       }
 
        return serve(port);
 }