gitweb: Handle non UTF-8 text better

diff --git a/copy.c b/copy.c
index e1cd5d06503d93f6b400a3911e6b61ff327190ca..d340bb253ec35af379c29e71f384e15d6822fb9a 100644 (file)
--- a/copy.c
+++ b/copy.c
@@ -3,35 +3,32 @@
 int copy_fd(int ifd, int ofd)
 {
        while (1) {
-               int len;
                char buffer[8192];
                char *buf = buffer;
-               len = read(ifd, buffer, sizeof(buffer));
+               ssize_t len = xread(ifd, buffer, sizeof(buffer));
                if (!len)
                        break;
                if (len < 0) {
                        int read_error;
-                       if (errno == EAGAIN)
-                               continue;
                        read_error = errno;
                        close(ifd);
                        return error("copy-fd: read returned %s",
                                     strerror(read_error));
                }
-               while (1) {
-                       int written = write(ofd, buf, len);
+               while (len) {
+                       int written = xwrite(ofd, buf, len);
                        if (written > 0) {
                                buf += written;
                                len -= written;
-                               if (!len)
-                                       break;
                        }
-                       if (!written)
+                       else if (!written) {
+                               close(ifd);
                                return error("copy-fd: write returned 0");
-                       if (errno == EAGAIN || errno == EINTR)
-                               continue;
-                       return error("copy-fd: write returned %s",
-                                    strerror(errno));
+                       } else {
+                               close(ifd);
+                               return error("copy-fd: write returned %s",
+                                            strerror(errno));
+                       }
                }
        }
        close(ifd);