shell: do not play duplicated definition games to shrink the executable

diff --git a/builtin-merge-file.c b/builtin-merge-file.c
index 6c4c3a351333b94ab62b77793b540af5c9bcaa3a..3605960c2d9692514a6df0f344f3c3269cf1de3c 100644 (file)
--- a/builtin-merge-file.c
+++ b/builtin-merge-file.c
@@ -1,29 +1,14 @@
+#include "builtin.h"
 #include "cache.h"
 #include "xdiff/xdiff.h"
+#include "xdiff-interface.h"
 
 static const char merge_file_usage[] =
 "git merge-file [-p | --stdout] [-q | --quiet] [-L name1 [-L orig [-L name2]]] file1 orig_file file2";
 
-static int read_file(mmfile_t *ptr, const char *filename)
+int cmd_merge_file(int argc, const char **argv, const char *prefix)
 {
-       struct stat st;
-       FILE *f;
-
-       if (stat(filename, &st))
-               return error("Could not stat %s", filename);
-       if ((f = fopen(filename, "rb")) == NULL)
-               return error("Could not open %s", filename);
-       ptr->ptr = xmalloc(st.st_size);
-       if (fread(ptr->ptr, st.st_size, 1, f) != 1)
-               return error("Could not read %s", filename);
-       fclose(f);
-       ptr->size = st.st_size;
-       return 0;
-}
-
-int cmd_merge_file(int argc, char **argv, char **envp)
-{
-       char *names[3];
+       const char *names[3];
        mmfile_t mmfs[3];
        mmbuffer_t result = {NULL, 0};
        xpparam_t xpp = {XDF_NEED_MINIMAL};
@@ -52,23 +37,28 @@ int cmd_merge_file(int argc, char **argv, char **envp)
        for (; i < 3; i++)
                names[i] = argv[i + 1];
 
-       for (i = 0; i < 3; i++)
-               if (read_file(mmfs + i, argv[i + 1]))
+       for (i = 0; i < 3; i++) {
+               if (read_mmfile(mmfs + i, argv[i + 1]))
                        return -1;
+               if (buffer_is_binary(mmfs[i].ptr, mmfs[i].size))
+                       return error("Cannot merge binary files: %s\n",
+                                       argv[i + 1]);
+       }
 
        ret = xdl_merge(mmfs + 1, mmfs + 0, names[0], mmfs + 2, names[2],
-                       &xpp, XDL_MERGE_ZEALOUS, &result);
+                       &xpp, XDL_MERGE_ZEALOUS_ALNUM, &result);
 
        for (i = 0; i < 3; i++)
                free(mmfs[i].ptr);
 
        if (ret >= 0) {
-               char *filename = argv[1];
+               const char *filename = argv[1];
                FILE *f = to_stdout ? stdout : fopen(filename, "wb");
 
                if (!f)
                        ret = error("Could not open %s for writing", filename);
-               else if (fwrite(result.ptr, result.size, 1, f) != 1)
+               else if (result.size &&
+                        fwrite(result.ptr, result.size, 1, f) != 1)
                        ret = error("Could not write to %s", filename);
                else if (fclose(f))
                        ret = error("Could not close %s", filename);