checkout: check_linked_checkout: simplify symref parsing
[gitweb.git] / builtin / checkout.c
index 162c822263a7988e223b4bae654d61c2c6e2e641..6f4e49232adc5d89850d6211b7cdf3c926821e7a 100644 (file)
@@ -19,8 +19,6 @@
 #include "ll-merge.h"
 #include "resolve-undo.h"
 #include "submodule.h"
-#include "argv-array.h"
-#include "sigchain.h"
 
 static const char * const checkout_usage[] = {
        N_("git checkout [options] <branch>"),
@@ -51,8 +49,6 @@ struct checkout_opts {
        struct pathspec pathspec;
        struct tree *source_tree;
 
-       const char *new_worktree;
-       const char **saved_argv;
        int new_worktree_mode;
 };
 
@@ -255,9 +251,6 @@ static int checkout_paths(const struct checkout_opts *opts,
                die(_("Cannot update paths and switch to branch '%s' at the same time."),
                    opts->new_branch);
 
-       if (opts->new_worktree)
-               die(_("'%s' cannot be used with updating paths"), "--to");
-
        if (opts->patch_mode)
                return run_add_interactive(revision, "--patch=checkout",
                                           &opts->pathspec);
@@ -825,144 +818,6 @@ static int switch_branches(const struct checkout_opts *opts,
        return ret || writeout_error;
 }
 
-static char *junk_work_tree;
-static char *junk_git_dir;
-static int is_junk;
-static pid_t junk_pid;
-
-static void remove_junk(void)
-{
-       struct strbuf sb = STRBUF_INIT;
-       if (!is_junk || getpid() != junk_pid)
-               return;
-       if (junk_git_dir) {
-               strbuf_addstr(&sb, junk_git_dir);
-               remove_dir_recursively(&sb, 0);
-               strbuf_reset(&sb);
-       }
-       if (junk_work_tree) {
-               strbuf_addstr(&sb, junk_work_tree);
-               remove_dir_recursively(&sb, 0);
-       }
-       strbuf_release(&sb);
-}
-
-static void remove_junk_on_signal(int signo)
-{
-       remove_junk();
-       sigchain_pop(signo);
-       raise(signo);
-}
-
-static int prepare_linked_checkout(const struct checkout_opts *opts,
-                                  struct branch_info *new)
-{
-       struct strbuf sb_git = STRBUF_INIT, sb_repo = STRBUF_INIT;
-       struct strbuf sb = STRBUF_INIT;
-       const char *path = opts->new_worktree, *name;
-       struct stat st;
-       struct child_process cp;
-       int counter = 0, len, ret;
-       unsigned char rev[20];
-
-       if (file_exists(path) && !is_empty_dir(path))
-               die(_("'%s' already exists"), path);
-
-       len = strlen(path);
-       while (len && is_dir_sep(path[len - 1]))
-               len--;
-
-       for (name = path + len - 1; name > path; name--)
-               if (is_dir_sep(*name)) {
-                       name++;
-                       break;
-               }
-       strbuf_addstr(&sb_repo,
-                     git_path("worktrees/%.*s", (int)(path + len - name), name));
-       len = sb_repo.len;
-       if (safe_create_leading_directories_const(sb_repo.buf))
-               die_errno(_("could not create leading directories of '%s'"),
-                         sb_repo.buf);
-       while (!stat(sb_repo.buf, &st)) {
-               counter++;
-               strbuf_setlen(&sb_repo, len);
-               strbuf_addf(&sb_repo, "%d", counter);
-       }
-       name = strrchr(sb_repo.buf, '/') + 1;
-
-       junk_pid = getpid();
-       atexit(remove_junk);
-       sigchain_push_common(remove_junk_on_signal);
-
-       if (mkdir(sb_repo.buf, 0777))
-               die_errno(_("could not create directory of '%s'"), sb_repo.buf);
-       junk_git_dir = xstrdup(sb_repo.buf);
-       is_junk = 1;
-
-       /*
-        * lock the incomplete repo so prune won't delete it, unlock
-        * after the preparation is over.
-        */
-       strbuf_addf(&sb, "%s/locked", sb_repo.buf);
-       write_file(sb.buf, 1, "initializing\n");
-
-       strbuf_addf(&sb_git, "%s/.git", path);
-       if (safe_create_leading_directories_const(sb_git.buf))
-               die_errno(_("could not create leading directories of '%s'"),
-                         sb_git.buf);
-       junk_work_tree = xstrdup(path);
-
-       strbuf_reset(&sb);
-       strbuf_addf(&sb, "%s/gitdir", sb_repo.buf);
-       write_file(sb.buf, 1, "%s\n", real_path(sb_git.buf));
-       write_file(sb_git.buf, 1, "gitdir: %s/worktrees/%s\n",
-                  real_path(get_git_common_dir()), name);
-       /*
-        * This is to keep resolve_ref() happy. We need a valid HEAD
-        * or is_git_directory() will reject the directory. Moreover, HEAD
-        * in the new worktree must resolve to the same value as HEAD in
-        * the current tree since the command invoked to populate the new
-        * worktree will be handed the branch/ref specified by the user.
-        * For instance, if the user asks for the new worktree to be based
-        * at HEAD~5, then the resolved HEAD~5 in the new worktree must
-        * match the resolved HEAD~5 in the current tree in order to match
-        * the user's expectation.
-        */
-       if (!resolve_ref_unsafe("HEAD", 0, rev, NULL))
-               die(_("unable to resolve HEAD"));
-       strbuf_reset(&sb);
-       strbuf_addf(&sb, "%s/HEAD", sb_repo.buf);
-       write_file(sb.buf, 1, "%s\n", sha1_to_hex(rev));
-       strbuf_reset(&sb);
-       strbuf_addf(&sb, "%s/commondir", sb_repo.buf);
-       write_file(sb.buf, 1, "../..\n");
-
-       if (!opts->quiet)
-               fprintf_ln(stderr, _("Enter %s (identifier %s)"), path, name);
-
-       setenv("GIT_CHECKOUT_NEW_WORKTREE", "1", 1);
-       setenv(GIT_DIR_ENVIRONMENT, sb_git.buf, 1);
-       setenv(GIT_WORK_TREE_ENVIRONMENT, path, 1);
-       memset(&cp, 0, sizeof(cp));
-       cp.git_cmd = 1;
-       cp.argv = opts->saved_argv;
-       ret = run_command(&cp);
-       if (!ret) {
-               is_junk = 0;
-               free(junk_work_tree);
-               free(junk_git_dir);
-               junk_work_tree = NULL;
-               junk_git_dir = NULL;
-       }
-       strbuf_reset(&sb);
-       strbuf_addf(&sb, "%s/locked", sb_repo.buf);
-       unlink_or_warn(sb.buf);
-       strbuf_release(&sb);
-       strbuf_release(&sb_repo);
-       strbuf_release(&sb_git);
-       return ret;
-}
-
 static int git_checkout_config(const char *var, const char *value, void *cb)
 {
        if (!strcmp(var, "diff.ignoresubmodules")) {
@@ -1018,27 +873,29 @@ static const char *unique_tracking_name(const char *name, unsigned char *sha1)
        return NULL;
 }
 
-static void check_linked_checkout(struct branch_info *new, const char *id)
+static void check_linked_checkout(const char *branch, const char *id)
 {
        struct strbuf sb = STRBUF_INIT;
        struct strbuf path = STRBUF_INIT;
        struct strbuf gitdir = STRBUF_INIT;
-       const char *start, *end;
 
+       /*
+        * $GIT_COMMON_DIR/HEAD is practically outside
+        * $GIT_DIR so resolve_ref_unsafe() won't work (it
+        * uses git_path). Parse the ref ourselves.
+        */
        if (id)
                strbuf_addf(&path, "%s/worktrees/%s/HEAD", get_git_common_dir(), id);
        else
                strbuf_addf(&path, "%s/HEAD", get_git_common_dir());
 
-       if (strbuf_read_file(&sb, path.buf, 0) < 0 ||
-           !skip_prefix(sb.buf, "ref:", &start))
+       if (strbuf_read_file(&sb, path.buf, 0) >= 0 &&
+           starts_with(sb.buf, "ref:")) {
+               strbuf_remove(&sb, 0, strlen("ref:"));
+               strbuf_trim(&sb);
+       } else
                goto done;
-       while (isspace(*start))
-               start++;
-       end = start;
-       while (*end && !isspace(*end))
-               end++;
-       if (strncmp(start, new->path, end - start) || new->path[end - start] != '\0')
+       if (strcmp(sb.buf, branch))
                goto done;
        if (id) {
                strbuf_reset(&path);
@@ -1048,38 +905,34 @@ static void check_linked_checkout(struct branch_info *new, const char *id)
                strbuf_rtrim(&gitdir);
        } else
                strbuf_addstr(&gitdir, get_git_common_dir());
-       die(_("'%s' is already checked out at '%s'"), new->name, gitdir.buf);
+       skip_prefix(branch, "refs/heads/", &branch);
+       strbuf_strip_suffix(&gitdir, ".git");
+       die(_("'%s' is already checked out at '%s'"), branch, gitdir.buf);
 done:
        strbuf_release(&path);
        strbuf_release(&sb);
        strbuf_release(&gitdir);
 }
 
-static void check_linked_checkouts(struct branch_info *new)
+static void die_if_checked_out(const char *branch)
 {
        struct strbuf path = STRBUF_INIT;
        DIR *dir;
        struct dirent *d;
 
+       check_linked_checkout(branch, NULL);
+
        strbuf_addf(&path, "%s/worktrees", get_git_common_dir());
-       if ((dir = opendir(path.buf)) == NULL) {
-               strbuf_release(&path);
+       dir = opendir(path.buf);
+       strbuf_release(&path);
+       if (!dir)
                return;
-       }
-
-       /*
-        * $GIT_COMMON_DIR/HEAD is practically outside
-        * $GIT_DIR so resolve_ref_unsafe() won't work (it
-        * uses git_path). Parse the ref ourselves.
-        */
-       check_linked_checkout(new, NULL);
 
        while ((d = readdir(dir)) != NULL) {
                if (!strcmp(d->d_name, ".") || !strcmp(d->d_name, ".."))
                        continue;
-               check_linked_checkout(new, d->d_name);
+               check_linked_checkout(branch, d->d_name);
        }
-       strbuf_release(&path);
        closedir(dir);
 }
 
@@ -1290,23 +1143,17 @@ static int checkout_branch(struct checkout_opts *opts,
                die(_("Cannot switch branch to a non-commit '%s'"),
                    new->name);
 
-       if (new->path && !opts->force_detach && !opts->new_branch) {
+       if (new->path && !opts->force_detach && !opts->new_branch &&
+           !opts->ignore_other_worktrees) {
                unsigned char sha1[20];
                int flag;
                char *head_ref = resolve_refdup("HEAD", 0, sha1, &flag);
                if (head_ref &&
-                   (!(flag & REF_ISSYMREF) || strcmp(head_ref, new->path)) &&
-                   !opts->ignore_other_worktrees)
-                       check_linked_checkouts(new);
+                   (!(flag & REF_ISSYMREF) || strcmp(head_ref, new->path)))
+                       die_if_checked_out(new->path);
                free(head_ref);
        }
 
-       if (opts->new_worktree) {
-               if (!new->commit)
-                       die(_("no branch specified"));
-               return prepare_linked_checkout(opts, new);
-       }
-
        if (!new->commit && opts->new_branch) {
                unsigned char rev[20];
                int flag;
@@ -1349,8 +1196,6 @@ int cmd_checkout(int argc, const char **argv, const char *prefix)
                         N_("do not limit pathspecs to sparse entries only")),
                OPT_HIDDEN_BOOL(0, "guess", &dwim_new_local_branch,
                                N_("second guess 'git checkout no-such-branch'")),
-               OPT_FILENAME(0, "to", &opts.new_worktree,
-                          N_("check a branch out in a separate working directory")),
                OPT_BOOL(0, "ignore-other-worktrees", &opts.ignore_other_worktrees,
                         N_("do not check if another worktree is holding the given ref")),
                OPT_END(),
@@ -1361,9 +1206,6 @@ int cmd_checkout(int argc, const char **argv, const char *prefix)
        opts.overwrite_ignore = 1;
        opts.prefix = prefix;
 
-       opts.saved_argv = xmalloc(sizeof(const char *) * (argc + 2));
-       memcpy(opts.saved_argv, argv, sizeof(const char *) * (argc + 1));
-
        gitmodules_config();
        git_config(git_checkout_config, &opts);
 
@@ -1372,13 +1214,7 @@ int cmd_checkout(int argc, const char **argv, const char *prefix)
        argc = parse_options(argc, argv, prefix, options, checkout_usage,
                             PARSE_OPT_KEEP_DASHDASH);
 
-       /* recursive execution from checkout_new_worktree() */
        opts.new_worktree_mode = getenv("GIT_CHECKOUT_NEW_WORKTREE") != NULL;
-       if (opts.new_worktree_mode)
-               opts.new_worktree = NULL;
-
-       if (!opts.new_worktree)
-               setup_work_tree();
 
        if (conflict_style) {
                opts.merge = 1; /* implied */