Merge branch 'cb/uname-in-untracked'
[gitweb.git] / builtin / checkout.c
index 162c822263a7988e223b4bae654d61c2c6e2e641..f71844a23a9d4bda0664bec709648911bc0f2609 100644 (file)
 #include "ll-merge.h"
 #include "resolve-undo.h"
 #include "submodule.h"
-#include "argv-array.h"
-#include "sigchain.h"
 
 static const char * const checkout_usage[] = {
-       N_("git checkout [options] <branch>"),
-       N_("git checkout [options] [<branch>] -- <file>..."),
+       N_("git checkout [<options>] <branch>"),
+       N_("git checkout [<options>] [<branch>] -- <file>..."),
        NULL,
 };
 
@@ -51,8 +49,6 @@ struct checkout_opts {
        struct pathspec pathspec;
        struct tree *source_tree;
 
-       const char *new_worktree;
-       const char **saved_argv;
        int new_worktree_mode;
 };
 
@@ -68,23 +64,41 @@ static int post_checkout_hook(struct commit *old, struct commit *new,
 
 }
 
-static int update_some(const unsigned char *sha1, const char *base, int baselen,
+static int update_some(const unsigned char *sha1, struct strbuf *base,
                const char *pathname, unsigned mode, int stage, void *context)
 {
        int len;
        struct cache_entry *ce;
+       int pos;
 
        if (S_ISDIR(mode))
                return READ_TREE_RECURSIVE;
 
-       len = baselen + strlen(pathname);
+       len = base->len + strlen(pathname);
        ce = xcalloc(1, cache_entry_size(len));
        hashcpy(ce->sha1, sha1);
-       memcpy(ce->name, base, baselen);
-       memcpy(ce->name + baselen, pathname, len - baselen);
+       memcpy(ce->name, base->buf, base->len);
+       memcpy(ce->name + base->len, pathname, len - base->len);
        ce->ce_flags = create_ce_flags(0) | CE_UPDATE;
        ce->ce_namelen = len;
        ce->ce_mode = create_ce_mode(mode);
+
+       /*
+        * If the entry is the same as the current index, we can leave the old
+        * entry in place. Whether it is UPTODATE or not, checkout_entry will
+        * do the right thing.
+        */
+       pos = cache_name_pos(ce->name, ce->ce_namelen);
+       if (pos >= 0) {
+               struct cache_entry *old = active_cache[pos];
+               if (ce->ce_mode == old->ce_mode &&
+                   !hashcmp(ce->sha1, old->sha1)) {
+                       old->ce_flags |= CE_UPDATE;
+                       free(ce);
+                       return 0;
+               }
+       }
+
        add_cache_entry(ce, ADD_CACHE_OK_TO_ADD | ADD_CACHE_OK_TO_REPLACE);
        return 0;
 }
@@ -255,9 +269,6 @@ static int checkout_paths(const struct checkout_opts *opts,
                die(_("Cannot update paths and switch to branch '%s' at the same time."),
                    opts->new_branch);
 
-       if (opts->new_worktree)
-               die(_("'%s' cannot be used with updating paths"), "--to");
-
        if (opts->patch_mode)
                return run_add_interactive(revision, "--patch=checkout",
                                           &opts->pathspec);
@@ -684,10 +695,10 @@ static void update_refs_for_switch(const struct checkout_opts *opts,
 }
 
 static int add_pending_uninteresting_ref(const char *refname,
-                                        const unsigned char *sha1,
+                                        const struct object_id *oid,
                                         int flags, void *cb_data)
 {
-       add_pending_sha1(cb_data, refname, sha1, UNINTERESTING);
+       add_pending_sha1(cb_data, refname, oid->hash, UNINTERESTING);
        return 0;
 }
 
@@ -742,10 +753,17 @@ static void suggest_reattach(struct commit *commit, struct rev_info *revs)
 
        if (advice_detached_head)
                fprintf(stderr,
-                       _(
+                       Q_(
+                       /* The singular version */
+                       "If you want to keep it by creating a new branch, "
+                       "this may be a good time\nto do so with:\n\n"
+                       " git branch <new-branch-name> %s\n\n",
+                       /* The plural version */
                        "If you want to keep them by creating a new branch, "
                        "this may be a good time\nto do so with:\n\n"
-                       " git branch new_branch_name %s\n\n"),
+                       " git branch <new-branch-name> %s\n\n",
+                       /* Give ngettext() the count */
+                       lost),
                        find_unique_abbrev(commit->object.sha1, DEFAULT_ABBREV));
 }
 
@@ -825,144 +843,6 @@ static int switch_branches(const struct checkout_opts *opts,
        return ret || writeout_error;
 }
 
-static char *junk_work_tree;
-static char *junk_git_dir;
-static int is_junk;
-static pid_t junk_pid;
-
-static void remove_junk(void)
-{
-       struct strbuf sb = STRBUF_INIT;
-       if (!is_junk || getpid() != junk_pid)
-               return;
-       if (junk_git_dir) {
-               strbuf_addstr(&sb, junk_git_dir);
-               remove_dir_recursively(&sb, 0);
-               strbuf_reset(&sb);
-       }
-       if (junk_work_tree) {
-               strbuf_addstr(&sb, junk_work_tree);
-               remove_dir_recursively(&sb, 0);
-       }
-       strbuf_release(&sb);
-}
-
-static void remove_junk_on_signal(int signo)
-{
-       remove_junk();
-       sigchain_pop(signo);
-       raise(signo);
-}
-
-static int prepare_linked_checkout(const struct checkout_opts *opts,
-                                  struct branch_info *new)
-{
-       struct strbuf sb_git = STRBUF_INIT, sb_repo = STRBUF_INIT;
-       struct strbuf sb = STRBUF_INIT;
-       const char *path = opts->new_worktree, *name;
-       struct stat st;
-       struct child_process cp;
-       int counter = 0, len, ret;
-       unsigned char rev[20];
-
-       if (file_exists(path) && !is_empty_dir(path))
-               die(_("'%s' already exists"), path);
-
-       len = strlen(path);
-       while (len && is_dir_sep(path[len - 1]))
-               len--;
-
-       for (name = path + len - 1; name > path; name--)
-               if (is_dir_sep(*name)) {
-                       name++;
-                       break;
-               }
-       strbuf_addstr(&sb_repo,
-                     git_path("worktrees/%.*s", (int)(path + len - name), name));
-       len = sb_repo.len;
-       if (safe_create_leading_directories_const(sb_repo.buf))
-               die_errno(_("could not create leading directories of '%s'"),
-                         sb_repo.buf);
-       while (!stat(sb_repo.buf, &st)) {
-               counter++;
-               strbuf_setlen(&sb_repo, len);
-               strbuf_addf(&sb_repo, "%d", counter);
-       }
-       name = strrchr(sb_repo.buf, '/') + 1;
-
-       junk_pid = getpid();
-       atexit(remove_junk);
-       sigchain_push_common(remove_junk_on_signal);
-
-       if (mkdir(sb_repo.buf, 0777))
-               die_errno(_("could not create directory of '%s'"), sb_repo.buf);
-       junk_git_dir = xstrdup(sb_repo.buf);
-       is_junk = 1;
-
-       /*
-        * lock the incomplete repo so prune won't delete it, unlock
-        * after the preparation is over.
-        */
-       strbuf_addf(&sb, "%s/locked", sb_repo.buf);
-       write_file(sb.buf, 1, "initializing\n");
-
-       strbuf_addf(&sb_git, "%s/.git", path);
-       if (safe_create_leading_directories_const(sb_git.buf))
-               die_errno(_("could not create leading directories of '%s'"),
-                         sb_git.buf);
-       junk_work_tree = xstrdup(path);
-
-       strbuf_reset(&sb);
-       strbuf_addf(&sb, "%s/gitdir", sb_repo.buf);
-       write_file(sb.buf, 1, "%s\n", real_path(sb_git.buf));
-       write_file(sb_git.buf, 1, "gitdir: %s/worktrees/%s\n",
-                  real_path(get_git_common_dir()), name);
-       /*
-        * This is to keep resolve_ref() happy. We need a valid HEAD
-        * or is_git_directory() will reject the directory. Moreover, HEAD
-        * in the new worktree must resolve to the same value as HEAD in
-        * the current tree since the command invoked to populate the new
-        * worktree will be handed the branch/ref specified by the user.
-        * For instance, if the user asks for the new worktree to be based
-        * at HEAD~5, then the resolved HEAD~5 in the new worktree must
-        * match the resolved HEAD~5 in the current tree in order to match
-        * the user's expectation.
-        */
-       if (!resolve_ref_unsafe("HEAD", 0, rev, NULL))
-               die(_("unable to resolve HEAD"));
-       strbuf_reset(&sb);
-       strbuf_addf(&sb, "%s/HEAD", sb_repo.buf);
-       write_file(sb.buf, 1, "%s\n", sha1_to_hex(rev));
-       strbuf_reset(&sb);
-       strbuf_addf(&sb, "%s/commondir", sb_repo.buf);
-       write_file(sb.buf, 1, "../..\n");
-
-       if (!opts->quiet)
-               fprintf_ln(stderr, _("Enter %s (identifier %s)"), path, name);
-
-       setenv("GIT_CHECKOUT_NEW_WORKTREE", "1", 1);
-       setenv(GIT_DIR_ENVIRONMENT, sb_git.buf, 1);
-       setenv(GIT_WORK_TREE_ENVIRONMENT, path, 1);
-       memset(&cp, 0, sizeof(cp));
-       cp.git_cmd = 1;
-       cp.argv = opts->saved_argv;
-       ret = run_command(&cp);
-       if (!ret) {
-               is_junk = 0;
-               free(junk_work_tree);
-               free(junk_git_dir);
-               junk_work_tree = NULL;
-               junk_git_dir = NULL;
-       }
-       strbuf_reset(&sb);
-       strbuf_addf(&sb, "%s/locked", sb_repo.buf);
-       unlink_or_warn(sb.buf);
-       strbuf_release(&sb);
-       strbuf_release(&sb_repo);
-       strbuf_release(&sb_git);
-       return ret;
-}
-
 static int git_checkout_config(const char *var, const char *value, void *cb)
 {
        if (!strcmp(var, "diff.ignoresubmodules")) {
@@ -1301,12 +1181,6 @@ static int checkout_branch(struct checkout_opts *opts,
                free(head_ref);
        }
 
-       if (opts->new_worktree) {
-               if (!new->commit)
-                       die(_("no branch specified"));
-               return prepare_linked_checkout(opts, new);
-       }
-
        if (!new->commit && opts->new_branch) {
                unsigned char rev[20];
                int flag;
@@ -1348,9 +1222,7 @@ int cmd_checkout(int argc, const char **argv, const char *prefix)
                OPT_BOOL(0, "ignore-skip-worktree-bits", &opts.ignore_skipworktree,
                         N_("do not limit pathspecs to sparse entries only")),
                OPT_HIDDEN_BOOL(0, "guess", &dwim_new_local_branch,
-                               N_("second guess 'git checkout no-such-branch'")),
-               OPT_FILENAME(0, "to", &opts.new_worktree,
-                          N_("check a branch out in a separate working directory")),
+                               N_("second guess 'git checkout <no-such-branch>'")),
                OPT_BOOL(0, "ignore-other-worktrees", &opts.ignore_other_worktrees,
                         N_("do not check if another worktree is holding the given ref")),
                OPT_END(),
@@ -1361,9 +1233,6 @@ int cmd_checkout(int argc, const char **argv, const char *prefix)
        opts.overwrite_ignore = 1;
        opts.prefix = prefix;
 
-       opts.saved_argv = xmalloc(sizeof(const char *) * (argc + 2));
-       memcpy(opts.saved_argv, argv, sizeof(const char *) * (argc + 1));
-
        gitmodules_config();
        git_config(git_checkout_config, &opts);
 
@@ -1372,13 +1241,7 @@ int cmd_checkout(int argc, const char **argv, const char *prefix)
        argc = parse_options(argc, argv, prefix, options, checkout_usage,
                             PARSE_OPT_KEEP_DASHDASH);
 
-       /* recursive execution from checkout_new_worktree() */
        opts.new_worktree_mode = getenv("GIT_CHECKOUT_NEW_WORKTREE") != NULL;
-       if (opts.new_worktree_mode)
-               opts.new_worktree = NULL;
-
-       if (!opts.new_worktree)
-               setup_work_tree();
 
        if (conflict_style) {
                opts.merge = 1; /* implied */