avoid accessing _all_ loose refs in git-show-ref --verify

diff --git a/builtin-add.c b/builtin-add.c
index 096b611b5b0eef1c5a96dcaddc21aa874bdaee29..b3f920676a958e581c55dcca48e9a8f01b43859b 100644 (file)
--- a/builtin-add.c
+++ b/builtin-add.c
@@ -70,7 +70,6 @@ static void fill_directory(struct dir_struct *dir, const char **pathspec)
        base = "";
        if (baselen) {
                char *common = xmalloc(baselen + 1);
-               common = xmalloc(baselen + 1);
                memcpy(common, *pathspec, baselen);
                common[baselen] = 0;
                path = base = common;
@@ -93,12 +92,7 @@ int cmd_add(int argc, const char **argv, const char *prefix)
 
        git_config(git_default_config);
 
-       newfd = hold_lock_file_for_update(&lock_file, get_index_file());
-       if (newfd < 0)
-               die("unable to create new index file");
-
-       if (read_cache() < 0)
-               die("index file corrupt");
+       newfd = hold_lock_file_for_update(&lock_file, get_index_file(), 1);
 
        for (i = 1; i < argc; i++) {
                const char *arg = argv[i];
@@ -134,6 +128,9 @@ int cmd_add(int argc, const char **argv, const char *prefix)
                return 0;
        }
 
+       if (read_cache() < 0)
+               die("index file corrupt");
+
        for (i = 0; i < dir.nr; i++)
                add_file_to_index(dir.entries[i]->name, verbose);