do_for_each_reflog(): use a strbuf to hold logfile name

diff --git a/t/t0004-unwritable.sh b/t/t0004-unwritable.sh
index 9255c63c08f06399525ca098d0374ad7d197e0b7..e3137d638ee5bb07b9278c1a9b90a207ad024a08 100755 (executable)
--- a/t/t0004-unwritable.sh
+++ b/t/t0004-unwritable.sh
@@ -8,60 +8,37 @@ test_expect_success setup '
 
        >file &&
        git add file &&
+       test_tick &&
        git commit -m initial &&
        echo >file &&
        git add file
 
 '
 
-test_expect_success 'write-tree should notice unwritable repository' '
-
-       (
-               chmod a-w .git/objects
-               test_must_fail git write-tree
-       )
-       status=$?
-       chmod 775 .git/objects
-       (exit $status)
-
+test_expect_success POSIXPERM,SANITY 'write-tree should notice unwritable repository' '
+       test_when_finished "chmod 775 .git/objects .git/objects/??" &&
+       chmod a-w .git/objects .git/objects/?? &&
+       test_must_fail git write-tree
 '
 
-test_expect_success 'commit should notice unwritable repository' '
-
-       (
-               chmod a-w .git/objects
-               test_must_fail git commit -m second
-       )
-       status=$?
-       chmod 775 .git/objects
-       (exit $status)
-
+test_expect_success POSIXPERM,SANITY 'commit should notice unwritable repository' '
+       test_when_finished "chmod 775 .git/objects .git/objects/??" &&
+       chmod a-w .git/objects .git/objects/?? &&
+       test_must_fail git commit -m second
 '
 
-test_expect_success 'update-index should notice unwritable repository' '
-
-       (
-               echo a >file &&
-               chmod a-w .git/objects
-               test_must_fail git update-index file
-       )
-       status=$?
-       chmod 775 .git/objects
-       (exit $status)
-
+test_expect_success POSIXPERM,SANITY 'update-index should notice unwritable repository' '
+       test_when_finished "chmod 775 .git/objects .git/objects/??" &&
+       echo 6O >file &&
+       chmod a-w .git/objects .git/objects/?? &&
+       test_must_fail git update-index file
 '
 
-test_expect_success 'add should notice unwritable repository' '
-
-       (
-               echo b >file &&
-               chmod a-w .git/objects
-               test_must_fail git add file
-       )
-       status=$?
-       chmod 775 .git/objects
-       (exit $status)
-
+test_expect_success POSIXPERM,SANITY 'add should notice unwritable repository' '
+       test_when_finished "chmod 775 .git/objects .git/objects/??" &&
+       echo b >file &&
+       chmod a-w .git/objects .git/objects/?? &&
+       test_must_fail git add file
 '
 
 test_done