Elaborate on why ':' is a bad idea in a ref name.

diff --git a/tree.c b/tree.c
index 043f032151cbca16dc144f9128b6327c755bcedd..d599fb5e1a8b689460c1e53b319f88aeda9a4c89 100644 (file)
--- a/tree.c
+++ b/tree.c
@@ -1,8 +1,8 @@
+#include "cache.h"
 #include "tree.h"
 #include "blob.h"
 #include "commit.h"
 #include "tag.h"
-#include "cache.h"
 #include <stdlib.h>
 
 const char *tree_type = "tree";
@@ -18,9 +18,7 @@ static int read_one_entry(unsigned char *sha1, const char *base, int baselen, co
 
        len = strlen(pathname);
        size = cache_entry_size(baselen + len);
-       ce = xmalloc(size);
-
-       memset(ce, 0, size);
+       ce = xcalloc(1, size);
 
        ce->ce_mode = create_ce_mode(mode);
        ce->ce_flags = create_ce_flags(baselen + len, stage);
@@ -74,27 +72,24 @@ static int match_tree_entry(const char *base, int baselen, const char *path, uns
        return 0;
 }
 
-int read_tree_recursive(void *buffer, unsigned long size,
+int read_tree_recursive(struct tree *tree,
                        const char *base, int baselen,
                        int stage, const char **match,
                        read_tree_fn_t fn)
 {
-       while (size) {
-               int len = strlen(buffer)+1;
-               unsigned char *sha1 = buffer + len;
-               char *path = strchr(buffer, ' ')+1;
-               unsigned int mode;
-
-               if (size < len + 20 || sscanf(buffer, "%o", &mode) != 1)
-                       return -1;
-
-               buffer = sha1 + 20;
-               size -= len + 20;
-
-               if (!match_tree_entry(base, baselen, path, mode, match))
+       struct tree_entry_list *list;
+       if (parse_tree(tree))
+               return -1;
+       list = tree->entries;
+       while (list) {
+               struct tree_entry_list *current = list;
+               list = list->next;
+               if (!match_tree_entry(base, baselen, current->name,
+                                     current->mode, match))
                        continue;
 
-               switch (fn(sha1, base, baselen, path, mode, stage)) {
+               switch (fn(current->item.any->sha1, base, baselen,
+                          current->name, current->mode, stage)) {
                case 0:
                        continue;
                case READ_TREE_RECURSIVE:
@@ -102,28 +97,19 @@ int read_tree_recursive(void *buffer, unsigned long size,
                default:
                        return -1;
                }
-               if (S_ISDIR(mode)) {
+               if (current->directory) {
                        int retval;
-                       int pathlen = strlen(path);
+                       int pathlen = strlen(current->name);
                        char *newbase;
-                       void *eltbuf;
-                       char elttype[20];
-                       unsigned long eltsize;
 
-                       eltbuf = read_sha1_file(sha1, elttype, &eltsize);
-                       if (!eltbuf || strcmp(elttype, "tree")) {
-                               if (eltbuf) free(eltbuf);
-                               return -1;
-                       }
                        newbase = xmalloc(baselen + 1 + pathlen);
                        memcpy(newbase, base, baselen);
-                       memcpy(newbase + baselen, path, pathlen);
+                       memcpy(newbase + baselen, current->name, pathlen);
                        newbase[baselen + pathlen] = '/';
-                       retval = read_tree_recursive(eltbuf, eltsize,
+                       retval = read_tree_recursive(current->item.tree,
                                                     newbase,
                                                     baselen + pathlen + 1,
                                                     stage, match, fn);
-                       free(eltbuf);
                        free(newbase);
                        if (retval)
                                return -1;
@@ -133,17 +119,16 @@ int read_tree_recursive(void *buffer, unsigned long size,
        return 0;
 }
 
-int read_tree(void *buffer, unsigned long size, int stage, const char **match)
+int read_tree(struct tree *tree, int stage, const char **match)
 {
-       return read_tree_recursive(buffer, size, "", 0, stage, match, read_one_entry);
+       return read_tree_recursive(tree, "", 0, stage, match, read_one_entry);
 }
 
 struct tree *lookup_tree(const unsigned char *sha1)
 {
        struct object *obj = lookup_object(sha1);
        if (!obj) {
-               struct tree *ret = xmalloc(sizeof(struct tree));
-               memset(ret, 0, sizeof(struct tree));
+               struct tree *ret = xcalloc(1, sizeof(struct tree));
                created_object(sha1, &ret->object);
                ret->object.type = tree_type;
                return ret;
@@ -200,7 +185,6 @@ int parse_tree_buffer(struct tree *item, void *buffer, unsigned long size)
                }
                if (obj)
                        n_refs++;
-               entry->parent = NULL; /* needs to be filled by the user */
                *list_p = entry;
                list_p = &entry->next;
        }