Merge branch 'jh/filter-empty-contents' into maint

diff --git a/send-pack.c b/send-pack.c
index 9d2b0c52ed8235425795772db99fc14ea9c2bf2b..2e07ac3339bce870b12e0023dc985929a277ebef 100644 (file)
--- a/send-pack.c
+++ b/send-pack.c
@@ -308,6 +308,28 @@ static int atomic_push_failure(struct send_pack_args *args,
                     failing_ref->name, failing_ref->status);
 }
 
+#define NONCE_LEN_LIMIT 256
+
+static void reject_invalid_nonce(const char *nonce, int len)
+{
+       int i = 0;
+
+       if (NONCE_LEN_LIMIT <= len)
+               die("the receiving end asked to sign an invalid nonce <%.*s>",
+                   len, nonce);
+
+       for (i = 0; i < len; i++) {
+               int ch = nonce[i] & 0xFF;
+               if (isalnum(ch) ||
+                   ch == '-' || ch == '.' ||
+                   ch == '/' || ch == '+' ||
+                   ch == '=' || ch == '_')
+                       continue;
+               die("the receiving end asked to sign an invalid nonce <%.*s>",
+                   len, nonce);
+       }
+}
+
 int send_pack(struct send_pack_args *args,
              int fd[], struct child_process *conn,
              struct ref *remote_refs,
@@ -354,6 +376,7 @@ int send_pack(struct send_pack_args *args,
                push_cert_nonce = server_feature_value("push-cert", &len);
                if (!push_cert_nonce)
                        die(_("the receiving end does not support --signed push"));
+               reject_invalid_nonce(push_cert_nonce, len);
                push_cert_nonce = xmemdupz(push_cert_nonce, len);
        }
 
@@ -363,7 +386,7 @@ int send_pack(struct send_pack_args *args,
                return 0;
        }
        if (args->atomic && !atomic_supported)
-               die(_("server does not support --atomic push"));
+               die(_("the receiving end does not support --atomic push"));
 
        use_atomic = atomic_supported && args->atomic;