git-gui: Refactored diff line display formatting logic.
[gitweb.git] / git-gui
diff --git a/git-gui b/git-gui
index c2b4dd70676103db57dea0fa748b7cad0ddfa0c2..a2a76c11dda447b97903c938857a6b6154e07ba1 100755 (executable)
--- a/git-gui
+++ b/git-gui
@@ -1,4 +1,3 @@
-#!/bin/sh
 # Tcl ignores the next line -*- tcl -*- \
 exec wish "$0" -- "$@"
 
@@ -211,7 +210,7 @@ proc lock_index {type} {
                        uplevel #0 $w disabled
                }
                return 1
-       } elseif {$index_lock_type eq {begin-update} && $type eq {update}} {
+       } elseif {$index_lock_type eq "begin-$type"} {
                set index_lock_type $type
                return 1
        }
@@ -369,11 +368,14 @@ proc read_diff_index {fd after} {
                set z2 [string first "\0" $buf_rdi $z1]
                if {$z2 == -1} break
 
+               incr c
+               set i [split [string range $buf_rdi $c [expr {$z1 - 2}]] { }]
+               merge_state \
+                       [string range $buf_rdi $z1 [expr {$z2 - 1}]] \
+                       [lindex $i 4]? \
+                       [list [lindex $i 0] [lindex $i 2]] \
+                       [list]
                set c $z2
-               incr z2 -1
-               display_file \
-                       [string range $buf_rdi $z1 $z2] \
-                       [string index $buf_rdi [expr {$z1 - 2}]]?
                incr c
        }
        if {$c < $n} {
@@ -398,11 +400,14 @@ proc read_diff_files {fd after} {
                set z2 [string first "\0" $buf_rdf $z1]
                if {$z2 == -1} break
 
+               incr c
+               set i [split [string range $buf_rdf $c [expr {$z1 - 2}]] { }]
+               merge_state \
+                       [string range $buf_rdf $z1 [expr {$z2 - 1}]] \
+                       ?[lindex $i 4] \
+                       [list] \
+                       [list [lindex $i 0] [lindex $i 2]]
                set c $z2
-               incr z2 -1
-               display_file \
-                       [string range $buf_rdf $z1 $z2] \
-                       ?[string index $buf_rdf [expr {$z1 - 2}]]
                incr c
        }
        if {$c < $n} {
@@ -421,7 +426,7 @@ proc read_ls_others {fd after} {
        set pck [split $buf_rlo "\0"]
        set buf_rlo [lindex $pck end]
        foreach p [lrange $pck 0 end-1] {
-               display_file $p ?O
+               merge_state $p ?O
        }
        rescan_done $fd buf_rlo $after
 }
@@ -539,7 +544,7 @@ files list, to prevent possible confusion.
 
 proc show_diff {path {w {}} {lno {}}} {
        global file_states file_lists
-       global diff_3way diff_active repo_config
+       global is_3way_diff diff_active repo_config
        global ui_diff current_diff ui_status_value
 
        if {$diff_active || ![lock_index read]} return
@@ -560,7 +565,7 @@ proc show_diff {path {w {}} {lno {}}} {
 
        set s $file_states($path)
        set m [lindex $s 0]
-       set diff_3way 0
+       set is_3way_diff 0
        set diff_active 1
        set current_diff $path
        set ui_status_value "Loading diff of [escape_path $path]..."
@@ -615,48 +620,52 @@ proc show_diff {path {w {}} {lno {}}} {
 }
 
 proc read_diff {fd} {
-       global ui_diff ui_status_value diff_3way diff_active
+       global ui_diff ui_status_value is_3way_diff diff_active
        global repo_config
 
+       $ui_diff conf -state normal
        while {[gets $fd line] >= 0} {
-               if {[string match {diff --git *} $line]} continue
+               # -- Cleanup uninteresting diff header lines.
+               #
+               if {[string match {diff --git *}      $line]} continue
                if {[string match {diff --combined *} $line]} continue
-               if {[string match {--- *} $line]} continue
-               if {[string match {+++ *} $line]} continue
-               if {[string match index* $line]} {
-                       if {[string first , $line] >= 0} {
-                               set diff_3way 1
-                       }
+               if {[string match {--- *}             $line]} continue
+               if {[string match {+++ *}             $line]} continue
+               if {$line eq {deleted file mode 120000}} {
+                       set line "deleted symlink"
                }
 
-               $ui_diff conf -state normal
-               if {!$diff_3way} {
-                       set x [string index $line 0]
-                       switch -- $x {
-                       "@" {set tags da}
-                       "+" {set tags dp}
-                       "-" {set tags dm}
+               # -- Automatically detect if this is a 3 way diff.
+               #
+               if {[string match {@@@ *} $line]} {set is_3way_diff 1}
+
+               # -- Reformat a 3 way diff, 'cause its too weird.
+               #
+               if {$is_3way_diff} {
+                       set op [string range $line 0 1]
+                       switch -- $op {
+                       {@@} {set tags d_@}
+                       {++} {set tags d_+ ; set op { +}}
+                       {--} {set tags d_- ; set op { -}}
+                       { +} {set tags d_++; set op {++}}
+                       { -} {set tags d_--; set op {--}}
+                       {+ } {set tags d_-+; set op {-+}}
+                       {- } {set tags d_+-; set op {+-}}
                        default {set tags {}}
                        }
+                       set line [string replace $line 0 1 $op]
                } else {
-                       set x [string range $line 0 1]
-                       switch -- $x {
-                       default {set tags {}}
-                       "@@" {set tags da}
-                       "++" {set tags dp; set x " +"}
-                       " +" {set tags {di bold}; set x "++"}
-                       "+ " {set tags dni; set x "-+"}
-                       "--" {set tags dm; set x " -"}
-                       " -" {set tags {dm bold}; set x "--"}
-                       "- " {set tags di; set x "+-"}
+                       switch -- [string index $line 0] {
+                       @ {set tags d_@}
+                       + {set tags d_+}
+                       - {set tags d_-}
                        default {set tags {}}
                        }
-                       set line [string replace $line 0 1 $x]
                }
                $ui_diff insert end $line $tags
-               $ui_diff insert end "\n"
-               $ui_diff conf -state disabled
+               $ui_diff insert end "\n" $tags
        }
+       $ui_diff conf -state disabled
 
        if {[eof $fd]} {
                close $fd
@@ -722,10 +731,41 @@ proc load_last_commit {} {
        rescan {set ui_status_value {Ready.}}
 }
 
+proc create_new_commit {} {
+       global commit_type ui_comm
+
+       set commit_type normal
+       $ui_comm delete 0.0 end
+       $ui_comm edit modified false
+       $ui_comm edit reset
+       rescan {set ui_status_value {Ready.}}
+}
+
+set GIT_COMMITTER_IDENT {}
+
+proc committer_ident {} {
+       global GIT_COMMITTER_IDENT
+
+       if {$GIT_COMMITTER_IDENT eq {}} {
+               if {[catch {set me [exec git var GIT_COMMITTER_IDENT]} err]} {
+                       error_popup "Unable to obtain your identity:\n\n$err"
+                       return {}
+               }
+               if {![regexp {^(.*) [0-9]+ [-+0-9]+$} \
+                       $me me GIT_COMMITTER_IDENT]} {
+                       error_popup "Invalid GIT_COMMITTER_IDENT:\n\n$me"
+                       return {}
+               }
+       }
+
+       return $GIT_COMMITTER_IDENT
+}
+
 proc commit_tree {} {
        global HEAD commit_type file_states ui_comm repo_config
 
        if {![lock_index update]} return
+       if {[committer_ident] eq {}} return
 
        # -- Our in memory state should match the repository.
        #
@@ -734,13 +774,13 @@ proc commit_tree {} {
                && $cur_type eq {normal}
                && $curHEAD eq $HEAD} {
        } elseif {$commit_type ne $cur_type || $HEAD ne $curHEAD} {
-               error_popup {Last scanned state does not match repository state.
+               info_popup {Last scanned state does not match repository state.
 
-Its highly likely that another Git program modified the
-repository since the last scan.  A rescan is required
-before committing.
+Another Git program has modified this repository
+since the last scan.  A rescan must be performed
+before another commit can be created.
 
-A rescan will be automatically started now.
+The rescan will be automatically started now.
 }
                unlock_index
                rescan {set ui_status_value {Ready.}}
@@ -880,7 +920,7 @@ proc commit_writetree {curHEAD msg} {
 
 proc commit_committree {fd_wt curHEAD msg} {
        global single_commit gitdir HEAD PARENT commit_type tcl_platform
-       global ui_status_value ui_comm
+       global ui_status_value ui_comm selected_commit_type
        global file_states selected_paths
 
        gets $fd_wt tree_id
@@ -980,6 +1020,7 @@ proc commit_committree {fd_wt curHEAD msg} {
        # -- Update status without invoking any git commands.
        #
        set commit_type normal
+       set selected_commit_type new
        set HEAD $cmt_id
        set PARENT $cmt_id
 
@@ -987,6 +1028,8 @@ proc commit_committree {fd_wt curHEAD msg} {
                set s $file_states($path)
                set m [lindex $s 0]
                switch -glob -- $m {
+               DD -
+               AO {set m __}
                A? -
                M? -
                D? {set m _[string index $m 1]}
@@ -1065,13 +1108,14 @@ Commit or throw away all changes before starting a pull operation.
 }
 
 proc post_pull_remote {remote branch success} {
-       global HEAD PARENT commit_type
+       global HEAD PARENT commit_type selected_commit_type
        global ui_status_value
 
        unlock_index
        if {$success} {
                repository_state HEAD commit_type
                set PARENT $HEAD
+               set selected_commit_type new
                set $ui_status_value "Pulling $branch from $remote complete."
        } else {
                set m "Conflicts detected while pulling $branch from $remote."
@@ -1131,9 +1175,10 @@ proc short_path {path} {
 }
 
 set next_icon_id 0
+set null_sha1 [string repeat 0 40]
 
-proc merge_state {path new_state} {
-       global file_states next_icon_id
+proc merge_state {path new_state {head_info {}} {index_info {}}} {
+       global file_states next_icon_id null_sha1
 
        set s0 [string index $new_state 0]
        set s1 [string index $new_state 1]
@@ -1144,30 +1189,33 @@ proc merge_state {path new_state} {
        } else {
                set state [lindex $info 0]
                set icon [lindex $info 1]
+               if {$head_info eq {}}  {set head_info  [lindex $info 2]}
+               if {$index_info eq {}} {set index_info [lindex $info 3]}
        }
 
-       if {$s0 eq {?}} {
-               set s0 [string index $state 0]
-       } elseif {$s0 eq {_}} {
-               set s0 _
-       }
+       if     {$s0 eq {?}} {set s0 [string index $state 0]} \
+       elseif {$s0 eq {_}} {set s0 _}
+
+       if     {$s1 eq {?}} {set s1 [string index $state 1]} \
+       elseif {$s1 eq {_}} {set s1 _}
 
-       if {$s1 eq {?}} {
-               set s1 [string index $state 1]
-       } elseif {$s1 eq {_}} {
-               set s1 _
+       if {$s0 eq {A} && $s1 eq {_} && $head_info eq {}} {
+               set head_info [list 0 $null_sha1]
+       } elseif {$s0 ne {_} && [string index $state 0] eq {_}
+               && $head_info eq {}} {
+               set head_info $index_info
        }
 
-       set file_states($path) [list $s0$s1 $icon]
+       set file_states($path) [list $s0$s1 $icon \
+               $head_info $index_info \
+               ]
        return $state
 }
 
 proc display_file {path state} {
-       global file_states file_lists selected_paths rescan_active
+       global file_states file_lists selected_paths
 
        set old_m [merge_state $path $state]
-       if {$rescan_active > 0} return
-
        set s $file_states($path)
        set new_m [lindex $s 0]
        set new_w [mapcol $new_m $path] 
@@ -1245,6 +1293,80 @@ proc display_all_files {} {
        $ui_other conf -state disabled
 }
 
+proc update_indexinfo {msg pathList after} {
+       global update_index_cp ui_status_value
+
+       if {![lock_index update]} return
+
+       set update_index_cp 0
+       set pathList [lsort $pathList]
+       set totalCnt [llength $pathList]
+       set batch [expr {int($totalCnt * .01) + 1}]
+       if {$batch > 25} {set batch 25}
+
+       set ui_status_value [format \
+               "$msg... %i/%i files (%.2f%%)" \
+               $update_index_cp \
+               $totalCnt \
+               0.0]
+       set fd [open "| git update-index -z --index-info" w]
+       fconfigure $fd \
+               -blocking 0 \
+               -buffering full \
+               -buffersize 512 \
+               -translation binary
+       fileevent $fd writable [list \
+               write_update_indexinfo \
+               $fd \
+               $pathList \
+               $totalCnt \
+               $batch \
+               $msg \
+               $after \
+               ]
+}
+
+proc write_update_indexinfo {fd pathList totalCnt batch msg after} {
+       global update_index_cp ui_status_value
+       global file_states current_diff
+
+       if {$update_index_cp >= $totalCnt} {
+               close $fd
+               unlock_index
+               uplevel #0 $after
+               return
+       }
+
+       for {set i $batch} \
+               {$update_index_cp < $totalCnt && $i > 0} \
+               {incr i -1} {
+               set path [lindex $pathList $update_index_cp]
+               incr update_index_cp
+
+               set s $file_states($path)
+               switch -glob -- [lindex $s 0] {
+               A? {set new _O}
+               M? {set new _M}
+               D? {set new _?}
+               ?? {continue}
+               }
+               set info [lindex $s 2]
+               if {$info eq {}} continue
+
+               puts -nonewline $fd $info
+               puts -nonewline $fd "\t"
+               puts -nonewline $fd $path
+               puts -nonewline $fd "\0"
+               display_file $path $new
+       }
+
+       set ui_status_value [format \
+               "$msg... %i/%i files (%.2f%%)" \
+               $update_index_cp \
+               $totalCnt \
+               [expr {100.0 * $update_index_cp / $totalCnt}]]
+}
+
 proc update_index {msg pathList after} {
        global update_index_cp ui_status_value
 
@@ -1298,7 +1420,7 @@ proc write_update_index {fd pathList totalCnt batch msg after} {
                switch -glob -- [lindex $file_states($path) 0] {
                AD -
                MD -
-               _D {set new D_}
+               _D {set new DD}
 
                _M -
                MM -
@@ -1848,6 +1970,49 @@ proc do_rescan {} {
        rescan {set ui_status_value {Ready.}}
 }
 
+proc remove_helper {txt paths} {
+       global file_states current_diff
+
+       if {![lock_index begin-update]} return
+
+       set pathList [list]
+       set after {}
+       foreach path $paths {
+               switch -glob -- [lindex $file_states($path) 0] {
+               A? -
+               M? -
+               D? {
+                       lappend pathList $path
+                       if {$path eq $current_diff} {
+                               set after {reshow_diff;}
+                       }
+               }
+               }
+       }
+       if {$pathList eq {}} {
+               unlock_index
+       } else {
+               update_indexinfo \
+                       $txt \
+                       $pathList \
+                       [concat $after {set ui_status_value {Ready.}}]
+       }
+}
+
+proc do_remove_selection {} {
+       global current_diff selected_paths
+
+       if {[array size selected_paths] > 0} {
+               remove_helper \
+                       {Removing selected files from commit} \
+                       [array names selected_paths]
+       } elseif {$current_diff ne {}} {
+               remove_helper \
+                       "Removing [short_path $current_diff] from commit" \
+                       [list $current_diff]
+       }
+}
+
 proc include_helper {txt paths} {
        global file_states current_diff
 
@@ -1858,9 +2023,13 @@ proc include_helper {txt paths} {
        foreach path $paths {
                switch -- [lindex $file_states($path) 0] {
                AM -
+               AD -
                MM -
+               UM -
+               U_ -
                _M -
-               _D {
+               _D -
+               _O {
                        lappend pathList $path
                        if {$path eq $current_diff} {
                                set after {reshow_diff;}
@@ -1894,29 +2063,29 @@ proc do_include_selection {} {
 
 proc do_include_all {} {
        global file_states
+
+       set paths [list]
+       foreach path [array names file_states] {
+               switch -- [lindex $file_states($path) 0] {
+               AM -
+               AD -
+               MM -
+               _M -
+               _D {lappend paths $path}
+               }
+       }
        include_helper \
                {Including all modified files} \
-               [array names file_states]
+               $paths
 }
 
-set GIT_COMMITTER_IDENT {}
-
 proc do_signoff {} {
-       global ui_comm GIT_COMMITTER_IDENT
+       global ui_comm
 
-       if {$GIT_COMMITTER_IDENT eq {}} {
-               if {[catch {set me [exec git var GIT_COMMITTER_IDENT]} err]} {
-                       error_popup "Unable to obtain your identity:\n\n$err"
-                       return
-               }
-               if {![regexp {^(.*) [0-9]+ [-+0-9]+$} \
-                       $me me GIT_COMMITTER_IDENT]} {
-                       error_popup "Invalid GIT_COMMITTER_IDENT:\n\n$me"
-                       return
-               }
-       }
+       set me [committer_ident]
+       if {$me eq {}} return
 
-       set sob "Signed-off-by: $GIT_COMMITTER_IDENT"
+       set sob "Signed-off-by: $me"
        set last [$ui_comm get {end -1c linestart} {end -1c}]
        if {$last ne $sob} {
                $ui_comm edit separator
@@ -1930,8 +2099,22 @@ proc do_signoff {} {
        }
 }
 
-proc do_amend_last {} {
-       load_last_commit
+proc do_select_commit_type {} {
+       global commit_type selected_commit_type
+
+       if {$selected_commit_type eq {new}
+               && [string match amend* $commit_type]} {
+               create_new_commit
+       } elseif {$selected_commit_type eq {amend}
+               && ![string match amend* $commit_type]} {
+               load_last_commit
+
+               # The amend request was rejected...
+               #
+               if {![string match amend* $commit_type]} {
+                       set selected_commit_type new
+               }
+       }
 }
 
 proc do_commit {} {
@@ -2165,10 +2348,6 @@ proc do_macosx_app {} {
 
                                file mkdir $MacOS
 
-                               set fd [open [file join $Contents PkgInfo] w]
-                               puts -nonewline $fd {APPL????}
-                               close $fd
-
                                set fd [open [file join $Contents Info.plist] w]
                                puts $fd {<?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
@@ -2219,7 +2398,7 @@ proc do_macosx_app {} {
 }
 
 proc toggle_or_diff {w x y} {
-       global file_lists current_diff ui_index ui_other
+       global file_states file_lists current_diff ui_index ui_other
        global last_clicked selected_paths
 
        set pos [split [$w index @$x,$y] .]
@@ -2242,10 +2421,24 @@ proc toggle_or_diff {w x y} {
                } else {
                        set after {}
                }
-               update_index \
-                       "Including [short_path $path]" \
-                       [list $path] \
-                       [concat $after {set ui_status_value {Ready.}}]
+               switch -glob -- [lindex $file_states($path) 0] {
+               A_ -
+               AO -
+               M_ -
+               DD -
+               D_ {
+                       update_indexinfo \
+                               "Removing [short_path $path] from commit" \
+                               [list $path] \
+                               [concat $after {set ui_status_value {Ready.}}]
+               }
+               ?? {
+                       update_index \
+                               "Including [short_path $path]" \
+                               [list $path] \
+                               [concat $after {set ui_status_value {Ready.}}]
+               }
+               }
        } else {
                show_diff $path $w $lno
        }
@@ -2450,32 +2643,60 @@ menu .mbar.edit
 # -- Commit Menu
 #
 menu .mbar.commit
+
+.mbar.commit add radiobutton \
+       -label {New Commit} \
+       -command do_select_commit_type \
+       -variable selected_commit_type \
+       -value new \
+       -font font_ui
+lappend disable_on_lock \
+       [list .mbar.commit entryconf [.mbar.commit index last] -state]
+
+.mbar.commit add radiobutton \
+       -label {Amend Last Commit} \
+       -command do_select_commit_type \
+       -variable selected_commit_type \
+       -value amend \
+       -font font_ui
+lappend disable_on_lock \
+       [list .mbar.commit entryconf [.mbar.commit index last] -state]
+
+.mbar.commit add separator
+
 .mbar.commit add command -label Rescan \
        -command do_rescan \
        -accelerator F5 \
        -font font_ui
 lappend disable_on_lock \
        [list .mbar.commit entryconf [.mbar.commit index last] -state]
-.mbar.commit add command -label {Amend Last Commit} \
-       -command do_amend_last \
+
+.mbar.commit add command -label {Remove From Commit} \
+       -command do_remove_selection \
        -font font_ui
 lappend disable_on_lock \
        [list .mbar.commit entryconf [.mbar.commit index last] -state]
-.mbar.commit add command -label {Include Selected Files} \
+
+.mbar.commit add command -label {Include In Commit} \
        -command do_include_selection \
        -font font_ui
 lappend disable_on_lock \
        [list .mbar.commit entryconf [.mbar.commit index last] -state]
-.mbar.commit add command -label {Include All Files} \
+
+.mbar.commit add command -label {Include All} \
        -command do_include_all \
        -accelerator $M1T-I \
        -font font_ui
 lappend disable_on_lock \
        [list .mbar.commit entryconf [.mbar.commit index last] -state]
+
+.mbar.commit add separator
+
 .mbar.commit add command -label {Sign Off} \
        -command do_signoff \
        -accelerator $M1T-S \
        -font font_ui
+
 .mbar.commit add command -label Commit \
        -command do_commit \
        -accelerator $M1T-Return \
@@ -2568,13 +2789,6 @@ pack .vpane.lower.commarea.buttons.rescan -side top -fill x
 lappend disable_on_lock \
        {.vpane.lower.commarea.buttons.rescan conf -state}
 
-button .vpane.lower.commarea.buttons.amend -text {Amend Last} \
-       -command do_amend_last \
-       -font font_ui
-pack .vpane.lower.commarea.buttons.amend -side top -fill x
-lappend disable_on_lock \
-       {.vpane.lower.commarea.buttons.amend conf -state}
-
 button .vpane.lower.commarea.buttons.incall -text {Include All} \
        -command do_include_all \
        -font font_ui
@@ -2597,8 +2811,25 @@ lappend disable_on_lock \
 # -- Commit Message Buffer
 #
 frame .vpane.lower.commarea.buffer
+frame .vpane.lower.commarea.buffer.header
 set ui_comm .vpane.lower.commarea.buffer.t
-set ui_coml .vpane.lower.commarea.buffer.l
+set ui_coml .vpane.lower.commarea.buffer.header.l
+radiobutton .vpane.lower.commarea.buffer.header.new \
+       -text {New Commit} \
+       -command do_select_commit_type \
+       -variable selected_commit_type \
+       -value new \
+       -font font_ui
+lappend disable_on_lock \
+       [list .vpane.lower.commarea.buffer.header.new conf -state]
+radiobutton .vpane.lower.commarea.buffer.header.amend \
+       -text {Amend Last Commit} \
+       -command do_select_commit_type \
+       -variable selected_commit_type \
+       -value amend \
+       -font font_ui
+lappend disable_on_lock \
+       [list .vpane.lower.commarea.buffer.header.amend conf -state]
 label $ui_coml \
        -anchor w \
        -justify left \
@@ -2615,6 +2846,10 @@ proc trace_commit_type {varname args} {
        $ui_coml conf -text $txt
 }
 trace add variable commit_type write trace_commit_type
+pack $ui_coml -side left -fill x
+pack .vpane.lower.commarea.buffer.header.amend -side right
+pack .vpane.lower.commarea.buffer.header.new -side right
+
 text $ui_comm -background white -borderwidth 1 \
        -undo true \
        -maxundo 20 \
@@ -2625,7 +2860,7 @@ text $ui_comm -background white -borderwidth 1 \
        -yscrollcommand {.vpane.lower.commarea.buffer.sby set}
 scrollbar .vpane.lower.commarea.buffer.sby \
        -command [list $ui_comm yview]
-pack $ui_coml -side top -fill x
+pack .vpane.lower.commarea.buffer.header -side top -fill x
 pack .vpane.lower.commarea.buffer.sby -side right -fill y
 pack $ui_comm -side left -fill y
 pack .vpane.lower.commarea.buffer -side left -fill y
@@ -2753,12 +2988,17 @@ pack $ui_diff -side left -fill both -expand 1
 pack .vpane.lower.diff.header -side top -fill x
 pack .vpane.lower.diff.body -side bottom -fill both -expand 1
 
-$ui_diff tag conf dm -foreground red
-$ui_diff tag conf dp -foreground blue
-$ui_diff tag conf di -foreground {#00a000}
-$ui_diff tag conf dni -foreground {#a000a0}
-$ui_diff tag conf da -font font_diffbold
-$ui_diff tag conf bold -font font_diffbold
+$ui_diff tag conf d_@ -font font_diffbold
+$ui_diff tag conf d_+  -foreground blue
+$ui_diff tag conf d_-  -foreground red
+$ui_diff tag conf d_++ -foreground {#00a000}
+$ui_diff tag conf d_-- -foreground {#a000a0}
+$ui_diff tag conf d_+- \
+       -foreground red \
+       -background {light goldenrod yellow}
+$ui_diff tag conf d_-+ \
+       -foreground blue \
+       -background azure2
 
 # -- Diff Body Context Menu
 #
@@ -2897,6 +3137,7 @@ set PARENT {}
 set commit_type {}
 set empty_tree {}
 set current_diff {}
+set selected_commit_type new
 
 wm title . "$appname ([file normalize [file dirname $gitdir]])"
 focus -force $ui_comm
@@ -2906,4 +3147,5 @@ if {!$single_commit} {
        populate_pull_menu .mbar.pull
        populate_push_menu .mbar.push
 }
+lock_index begin-read
 after 1 do_rescan