http-push: refactor request url creation

diff --git a/t/t3412-rebase-root.sh b/t/t3412-rebase-root.sh
index ef6f7a54ae23bc58198363b20019a58c54b021fc..9fc528fdea18409fa2871f62ec3b14577b1a55e4 100755 (executable)
--- a/t/t3412-rebase-root.sh
+++ b/t/t3412-rebase-root.sh
@@ -7,23 +7,13 @@ Tests if git rebase --root --onto <newparent> can rebase the root commit.
 . ./test-lib.sh
 
 test_expect_success 'prepare repository' '
-       echo 1 > A &&
-       git add A &&
-       git commit -m 1 &&
-       echo 2 > A &&
-       git add A &&
-       git commit -m 2 &&
+       test_commit 1 A &&
+       test_commit 2 A &&
        git symbolic-ref HEAD refs/heads/other &&
        rm .git/index &&
-       echo 3 > B &&
-       git add B &&
-       git commit -m 3 &&
-       echo 1 > A &&
-       git add A &&
-       git commit -m 1b &&
-       echo 4 > B &&
-       git add B &&
-       git commit -m 4
+       test_commit 3 B &&
+       test_commit 1b A 1 &&
+       test_commit 4 B
 '
 
 test_expect_success 'rebase --root expects --onto' '
@@ -103,9 +93,7 @@ test_expect_success 'pre-rebase got correct input (5)' '
 test_expect_success 'set up merge history' '
        git checkout other^ &&
        git checkout -b side &&
-       echo 5 > C &&
-       git add C &&
-       git commit -m 5 &&
+       test_commit 5 C &&
        git checkout other &&
        git merge side
 '
@@ -132,9 +120,7 @@ test_expect_success 'set up second root and merge' '
        git symbolic-ref HEAD refs/heads/third &&
        rm .git/index &&
        rm A B C &&
-       echo 6 > D &&
-       git add D &&
-       git commit -m 6 &&
+       test_commit 6 D &&
        git checkout other &&
        git merge third
 '
@@ -172,14 +158,22 @@ EOF
 
 test_expect_success 'pre-rebase hook stops rebase' '
        git checkout -b stops1 other &&
-       GIT_EDITOR=: test_must_fail git rebase --root --onto master &&
+       (
+               GIT_EDITOR=:
+               export GIT_EDITOR
+               test_must_fail git rebase --root --onto master
+       ) &&
        test "z$(git symbolic-ref HEAD)" = zrefs/heads/stops1
        test 0 = $(git rev-list other...stops1 | wc -l)
 '
 
 test_expect_success 'pre-rebase hook stops rebase -i' '
        git checkout -b stops2 other &&
-       GIT_EDITOR=: test_must_fail git rebase --root --onto master &&
+       (
+               GIT_EDITOR=:
+               export GIT_EDITOR
+               test_must_fail git rebase --root --onto master
+       ) &&
        test "z$(git symbolic-ref HEAD)" = zrefs/heads/stops2
        test 0 = $(git rev-list other...stops2 | wc -l)
 '
@@ -224,7 +218,11 @@ test_expect_success 'rebase --root with conflict (second part)' '
 
 test_expect_success 'rebase -i --root with conflict (first part)' '
        git checkout -b conflict2 other &&
-       GIT_EDITOR=: test_must_fail git rebase -i --root --onto master &&
+       (
+               GIT_EDITOR=:
+               export GIT_EDITOR
+               test_must_fail git rebase -i --root --onto master
+       ) &&
        git ls-files -u | grep "B$"
 '
 
@@ -262,7 +260,11 @@ EOF
 
 test_expect_success 'rebase -i -p --root with conflict (first part)' '
        git checkout -b conflict3 other &&
-       GIT_EDITOR=: test_must_fail git rebase -i -p --root --onto master &&
+       (
+               GIT_EDITOR=:
+               export GIT_EDITOR
+               test_must_fail git rebase -i -p --root --onto master
+       ) &&
        git ls-files -u | grep "B$"
 '