remote-hg: fix bad file paths
[gitweb.git] / combine-diff.c
index 7f6187f9cd2fc44540cddbcf4bb853231c57397c..6288485965b5f79c1311e48e8de5c1be97730977 100644 (file)
@@ -5,6 +5,7 @@
 #include "diffcore.h"
 #include "quote.h"
 #include "xdiff-interface.h"
+#include "xdiff/xmacros.h"
 #include "log-tree.h"
 #include "refs.h"
 #include "userdiff.h"
@@ -122,7 +123,47 @@ static char *grab_blob(const unsigned char *sha1, unsigned int mode,
        return blob;
 }
 
-static void append_lost(struct sline *sline, int n, const char *line, int len)
+static int match_string_spaces(const char *line1, int len1,
+                              const char *line2, int len2,
+                              long flags)
+{
+       if (flags & XDF_WHITESPACE_FLAGS) {
+               for (; len1 > 0 && XDL_ISSPACE(line1[len1 - 1]); len1--);
+               for (; len2 > 0 && XDL_ISSPACE(line2[len2 - 1]); len2--);
+       }
+
+       if (!(flags & (XDF_IGNORE_WHITESPACE | XDF_IGNORE_WHITESPACE_CHANGE)))
+               return (len1 == len2 && !memcmp(line1, line2, len1));
+
+       while (len1 > 0 && len2 > 0) {
+               len1--;
+               len2--;
+               if (XDL_ISSPACE(line1[len1]) || XDL_ISSPACE(line2[len2])) {
+                       if ((flags & XDF_IGNORE_WHITESPACE_CHANGE) &&
+                           (!XDL_ISSPACE(line1[len1]) || !XDL_ISSPACE(line2[len2])))
+                               return 0;
+
+                       for (; len1 > 0 && XDL_ISSPACE(line1[len1]); len1--);
+                       for (; len2 > 0 && XDL_ISSPACE(line2[len2]); len2--);
+               }
+               if (line1[len1] != line2[len2])
+                       return 0;
+       }
+
+       if (flags & XDF_IGNORE_WHITESPACE) {
+               /* Consume remaining spaces */
+               for (; len1 > 0 && XDL_ISSPACE(line1[len1 - 1]); len1--);
+               for (; len2 > 0 && XDL_ISSPACE(line2[len2 - 1]); len2--);
+       }
+
+       /* We matched full line1 and line2 */
+       if (!len1 && !len2)
+               return 1;
+
+       return 0;
+}
+
+static void append_lost(struct sline *sline, int n, const char *line, int len, long flags)
 {
        struct lline *lline;
        unsigned long this_mask = (1UL<<n);
@@ -133,8 +174,8 @@ static void append_lost(struct sline *sline, int n, const char *line, int len)
        if (sline->lost_head) {
                lline = sline->next_lost;
                while (lline) {
-                       if (lline->len == len &&
-                           !memcmp(lline->line, line, len)) {
+                       if (match_string_spaces(lline->line, lline->len,
+                                               line, len, flags)) {
                                lline->parent_map |= this_mask;
                                sline->next_lost = lline->next;
                                return;
@@ -162,6 +203,7 @@ struct combine_diff_state {
        int n;
        struct sline *sline;
        struct sline *lost_bucket;
+       long flags;
 };
 
 static void consume_line(void *state_, char *line, unsigned long len)
@@ -201,7 +243,7 @@ static void consume_line(void *state_, char *line, unsigned long len)
                return; /* not in any hunk yet */
        switch (line[0]) {
        case '-':
-               append_lost(state->lost_bucket, state->n, line+1, len-1);
+               append_lost(state->lost_bucket, state->n, line+1, len-1, state->flags);
                break;
        case '+':
                state->sline[state->lno-1].flag |= state->nmask;
@@ -215,7 +257,7 @@ static void combine_diff(const unsigned char *parent, unsigned int mode,
                         struct sline *sline, unsigned int cnt, int n,
                         int num_parent, int result_deleted,
                         struct userdiff_driver *textconv,
-                        const char *path)
+                        const char *path, long flags)
 {
        unsigned int p_lno, lno;
        unsigned long nmask = (1UL << n);
@@ -231,9 +273,10 @@ static void combine_diff(const unsigned char *parent, unsigned int mode,
        parent_file.ptr = grab_blob(parent, mode, &sz, textconv, path);
        parent_file.size = sz;
        memset(&xpp, 0, sizeof(xpp));
-       xpp.flags = 0;
+       xpp.flags = flags;
        memset(&xecfg, 0, sizeof(xecfg));
        memset(&state, 0, sizeof(state));
+       state.flags = flags;
        state.nmask = nmask;
        state.sline = sline;
        state.lno = 1;
@@ -526,7 +569,8 @@ static void show_line_to_eol(const char *line, int len, const char *reset)
               saw_cr_at_eol ? "\r" : "");
 }
 
-static void dump_sline(struct sline *sline, unsigned long cnt, int num_parent,
+static void dump_sline(struct sline *sline, const char *line_prefix,
+                      unsigned long cnt, int num_parent,
                       int use_color, int result_deleted)
 {
        unsigned long mark = (1UL<<num_parent);
@@ -582,7 +626,7 @@ static void dump_sline(struct sline *sline, unsigned long cnt, int num_parent,
                        rlines -= null_context;
                }
 
-               fputs(c_frag, stdout);
+               printf("%s%s", line_prefix, c_frag);
                for (i = 0; i <= num_parent; i++) putchar(combine_marker);
                for (i = 0; i < num_parent; i++)
                        show_parent_lno(sline, lno, hunk_end, i, null_context);
@@ -614,7 +658,7 @@ static void dump_sline(struct sline *sline, unsigned long cnt, int num_parent,
                        struct sline *sl = &sline[lno++];
                        ll = (sl->flag & no_pre_delete) ? NULL : sl->lost_head;
                        while (ll) {
-                               fputs(c_old, stdout);
+                               printf("%s%s", line_prefix, c_old);
                                for (j = 0; j < num_parent; j++) {
                                        if (ll->parent_map & (1UL<<j))
                                                putchar('-');
@@ -627,6 +671,7 @@ static void dump_sline(struct sline *sline, unsigned long cnt, int num_parent,
                        if (cnt < lno)
                                break;
                        p_mask = 1;
+                       fputs(line_prefix, stdout);
                        if (!(sl->flag & (mark-1))) {
                                /*
                                 * This sline was here to hang the
@@ -680,11 +725,13 @@ static void reuse_combine_diff(struct sline *sline, unsigned long cnt,
 static void dump_quoted_path(const char *head,
                             const char *prefix,
                             const char *path,
+                            const char *line_prefix,
                             const char *c_meta, const char *c_reset)
 {
        static struct strbuf buf = STRBUF_INIT;
 
        strbuf_reset(&buf);
+       strbuf_addstr(&buf, line_prefix);
        strbuf_addstr(&buf, c_meta);
        strbuf_addstr(&buf, head);
        quote_two_c_style(&buf, prefix, path, 0);
@@ -696,6 +743,7 @@ static void show_combined_header(struct combine_diff_path *elem,
                                 int num_parent,
                                 int dense,
                                 struct rev_info *rev,
+                                const char *line_prefix,
                                 int mode_differs,
                                 int show_file_header)
 {
@@ -714,8 +762,8 @@ static void show_combined_header(struct combine_diff_path *elem,
                show_log(rev);
 
        dump_quoted_path(dense ? "diff --cc " : "diff --combined ",
-                        "", elem->path, c_meta, c_reset);
-       printf("%sindex ", c_meta);
+                        "", elem->path, line_prefix, c_meta, c_reset);
+       printf("%s%sindex ", line_prefix, c_meta);
        for (i = 0; i < num_parent; i++) {
                abb = find_unique_abbrev(elem->parent[i].sha1,
                                         abbrev);
@@ -734,11 +782,12 @@ static void show_combined_header(struct combine_diff_path *elem,
                            DIFF_STATUS_ADDED)
                                added = 0;
                if (added)
-                       printf("%snew file mode %06o",
-                              c_meta, elem->mode);
+                       printf("%s%snew file mode %06o",
+                              line_prefix, c_meta, elem->mode);
                else {
                        if (deleted)
-                               printf("%sdeleted file ", c_meta);
+                               printf("%s%sdeleted file ",
+                                      line_prefix, c_meta);
                        printf("mode ");
                        for (i = 0; i < num_parent; i++) {
                                printf("%s%06o", i ? "," : "",
@@ -755,16 +804,16 @@ static void show_combined_header(struct combine_diff_path *elem,
 
        if (added)
                dump_quoted_path("--- ", "", "/dev/null",
-                                c_meta, c_reset);
+                                line_prefix, c_meta, c_reset);
        else
                dump_quoted_path("--- ", a_prefix, elem->path,
-                                c_meta, c_reset);
+                                line_prefix, c_meta, c_reset);
        if (deleted)
                dump_quoted_path("+++ ", "", "/dev/null",
-                                c_meta, c_reset);
+                                line_prefix, c_meta, c_reset);
        else
                dump_quoted_path("+++ ", b_prefix, elem->path,
-                                c_meta, c_reset);
+                                line_prefix, c_meta, c_reset);
 }
 
 static void show_patch_diff(struct combine_diff_path *elem, int num_parent,
@@ -782,6 +831,7 @@ static void show_patch_diff(struct combine_diff_path *elem, int num_parent,
        struct userdiff_driver *userdiff;
        struct userdiff_driver *textconv = NULL;
        int is_binary;
+       const char *line_prefix = diff_line_prefix(opt);
 
        context = opt->context;
        userdiff = userdiff_find_by_path(elem->path);
@@ -901,7 +951,7 @@ static void show_patch_diff(struct combine_diff_path *elem, int num_parent,
        }
        if (is_binary) {
                show_combined_header(elem, num_parent, dense, rev,
-                                    mode_differs, 0);
+                                    line_prefix, mode_differs, 0);
                printf("Binary files differ\n");
                free(result);
                return;
@@ -955,15 +1005,15 @@ static void show_patch_diff(struct combine_diff_path *elem, int num_parent,
                                     elem->parent[i].mode,
                                     &result_file, sline,
                                     cnt, i, num_parent, result_deleted,
-                                    textconv, elem->path);
+                                    textconv, elem->path, opt->xdl_opts);
        }
 
        show_hunks = make_hunks(sline, cnt, num_parent, dense);
 
        if (show_hunks || mode_differs || working_tree_file) {
                show_combined_header(elem, num_parent, dense, rev,
-                                    mode_differs, 1);
-               dump_sline(sline, cnt, num_parent,
+                                    line_prefix, mode_differs, 1);
+               dump_sline(sline, line_prefix, cnt, num_parent,
                           opt->use_color, result_deleted);
        }
        free(result);
@@ -986,6 +1036,7 @@ static void show_raw_diff(struct combine_diff_path *p, int num_parent, struct re
 {
        struct diff_options *opt = &rev->diffopt;
        int line_termination, inter_name_termination, i;
+       const char *line_prefix = diff_line_prefix(opt);
 
        line_termination = opt->line_termination;
        inter_name_termination = '\t';
@@ -995,7 +1046,10 @@ static void show_raw_diff(struct combine_diff_path *p, int num_parent, struct re
        if (rev->loginfo && !rev->no_commit_id)
                show_log(rev);
 
+
        if (opt->output_format & DIFF_FORMAT_RAW) {
+               printf("%s", line_prefix);
+
                /* As many colons as there are parents */
                for (i = 0; i < num_parent; i++)
                        putchar(':');
@@ -1033,6 +1087,7 @@ void show_combined_diff(struct combine_diff_path *p,
                       struct rev_info *rev)
 {
        struct diff_options *opt = &rev->diffopt;
+
        if (!p->len)
                return;
        if (opt->output_format & (DIFF_FORMAT_RAW |
@@ -1143,8 +1198,10 @@ void diff_tree_combined(const unsigned char *sha1,
 
                if (show_log_first && i == 0) {
                        show_log(rev);
+
                        if (rev->verbose_header && opt->output_format)
-                               putchar(opt->line_termination);
+                               printf("%s%c", diff_line_prefix(opt),
+                                      opt->line_termination);
                }
                diff_flush(&diffopts);
        }
@@ -1172,7 +1229,8 @@ void diff_tree_combined(const unsigned char *sha1,
 
                if (opt->output_format & DIFF_FORMAT_PATCH) {
                        if (needsep)
-                               putchar(opt->line_termination);
+                               printf("%s%c", diff_line_prefix(opt),
+                                      opt->line_termination);
                        for (p = paths; p; p = p->next) {
                                if (p->len)
                                        show_patch_diff(p, num_parent, dense,