Clean-up read-tree error condition.

diff --git a/builtin-diff-tree.c b/builtin-diff-tree.c
index 1e66fcac2186d0946b5d15a5825eb400b2e67003..0b591c87169ff4b8c2173bedb26d6ed1a8a84b68 100644 (file)
--- a/builtin-diff-tree.c
+++ b/builtin-diff-tree.c
@@ -59,7 +59,7 @@ static const char diff_tree_usage[] =
 "  --root        include the initial commit as diff against /dev/null\n"
 COMMON_DIFF_OPTIONS_HELP;
 
-int cmd_diff_tree(int argc, const char **argv, char **envp)
+int cmd_diff_tree(int argc, const char **argv, const char *prefix)
 {
        int nr_sha1;
        char line[1000];
@@ -67,12 +67,11 @@ int cmd_diff_tree(int argc, const char **argv, char **envp)
        static struct rev_info *opt = &log_tree_opt;
        int read_stdin = 0;
 
-       git_config(git_diff_config);
+       init_revisions(opt, prefix);
+       git_config(git_default_config); /* no "diff" UI options */
        nr_sha1 = 0;
-       init_revisions(opt);
        opt->abbrev = 0;
        opt->diff = 1;
-       opt->diffopt.msg_sep = "---\n";
        argc = setup_revisions(argc, argv, opt, NULL);
 
        while (--argc > 0) {
@@ -119,7 +118,8 @@ int cmd_diff_tree(int argc, const char **argv, char **envp)
        }
 
        if (!read_stdin)
-               return 0;
+               return opt->diffopt.exit_with_status ?
+                   opt->diffopt.has_changes: 0;
 
        if (opt->diffopt.detect_rename)
                opt->diffopt.setup |= (DIFF_SETUP_USE_SIZE_CACHE |
@@ -134,5 +134,5 @@ int cmd_diff_tree(int argc, const char **argv, char **envp)
                else
                        diff_tree_stdin(line);
        }
-       return 0;
+       return opt->diffopt.exit_with_status ? opt->diffopt.has_changes: 0;
 }