Merge branch 'dl/complete-cherry-pick-revert-skip'

diff --git a/commit-slab-impl.h b/commit-slab-impl.h
index 234d9ee5f08c1585272c841fabd42658f0880a93..5c0eb91a5d175ddb079459a0ba13b9be1f74b1ab 100644 (file)
--- a/commit-slab-impl.h
+++ b/commit-slab-impl.h
@@ -1,13 +1,17 @@
 #ifndef COMMIT_SLAB_IMPL_H
 #define COMMIT_SLAB_IMPL_H
 
-#define MAYBE_UNUSED __attribute__((__unused__))
+#include "git-compat-util.h"
 
-#define implement_commit_slab(slabname, elemtype)                      \
-                                                                       \
-static int stat_ ##slabname## realloc;                                 \
+#define implement_static_commit_slab(slabname, elemtype) \
+       implement_commit_slab(slabname, elemtype, MAYBE_UNUSED static)
+
+#define implement_shared_commit_slab(slabname, elemtype) \
+       implement_commit_slab(slabname, elemtype, )
+
+#define implement_commit_slab(slabname, elemtype, scope)               \
                                                                        \
-static MAYBE_UNUSED void init_ ##slabname## _with_stride(struct slabname *s, \
+scope void init_ ##slabname## _with_stride(struct slabname *s,         \
                                                   unsigned stride)     \
 {                                                                      \
        unsigned int elem_size;                                         \
@@ -20,12 +24,12 @@ static MAYBE_UNUSED void init_ ##slabname## _with_stride(struct slabname *s, \
        s->slab = NULL;                                                 \
 }                                                                      \
                                                                        \
-static MAYBE_UNUSED void init_ ##slabname(struct slabname *s)          \
+scope void init_ ##slabname(struct slabname *s)                                \
 {                                                                      \
        init_ ##slabname## _with_stride(s, 1);                          \
 }                                                                      \
                                                                        \
-static MAYBE_UNUSED void clear_ ##slabname(struct slabname *s)         \
+scope void clear_ ##slabname(struct slabname *s)                       \
 {                                                                      \
        unsigned int i;                                                 \
        for (i = 0; i < s->slab_count; i++)                             \
@@ -34,7 +38,7 @@ static MAYBE_UNUSED void clear_ ##slabname(struct slabname *s)                \
        FREE_AND_NULL(s->slab);                                         \
 }                                                                      \
                                                                        \
-static MAYBE_UNUSED elemtype *slabname## _at_peek(struct slabname *s,  \
+scope elemtype *slabname## _at_peek(struct slabname *s,                        \
                                                  const struct commit *c, \
                                                  int add_if_missing)   \
 {                                                                      \
@@ -48,7 +52,6 @@ static MAYBE_UNUSED elemtype *slabname## _at_peek(struct slabname *s, \
                if (!add_if_missing)                                    \
                        return NULL;                                    \
                REALLOC_ARRAY(s->slab, nth_slab + 1);                   \
-               stat_ ##slabname## realloc++;                           \
                for (i = s->slab_count; i <= nth_slab; i++)             \
                        s->slab[i] = NULL;                              \
                s->slab_count = nth_slab + 1;                           \
@@ -62,13 +65,13 @@ static MAYBE_UNUSED elemtype *slabname## _at_peek(struct slabname *s,       \
        return &s->slab[nth_slab][nth_slot * s->stride];                \
 }                                                                      \
                                                                        \
-static MAYBE_UNUSED elemtype *slabname## _at(struct slabname *s,       \
+scope elemtype *slabname## _at(struct slabname *s,                     \
                                             const struct commit *c)    \
 {                                                                      \
        return slabname##_at_peek(s, c, 1);                             \
 }                                                                      \
                                                                        \
-static MAYBE_UNUSED elemtype *slabname## _peek(struct slabname *s,     \
+scope elemtype *slabname## _peek(struct slabname *s,                   \
                                             const struct commit *c)    \
 {                                                                      \
        return slabname##_at_peek(s, c, 0);                             \
@@ -81,7 +84,7 @@ struct slabname
  * to allow a terminating semicolon, which makes instantiations look
  * like function declarations.  I.e., the expansion of
  *
- *    implement_commit_slab(indegree, int);
+ *    implement_commit_slab(indegree, int, static);
  *
  * ends in 'struct indegree;'.  This would otherwise
  * be a syntax error according (at least) to ISO C.  It's hard to