general improvements

diff --git a/transport-helper.c b/transport-helper.c
index 1fb31e1a6e31d8f5c383116a8abb0c43c87c528b..9e1279b928bb3eadf110e43c091b4a3ba789fe3b 100644 (file)
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -700,13 +700,9 @@ static int fetch(struct transport *transport,
                set_helper_option(transport, "update-shallow", "true");
 
        if (data->transport_options.filter_options.choice) {
-               struct strbuf expanded_filter_spec = STRBUF_INIT;
-               expand_list_objects_filter_spec(
-                       &data->transport_options.filter_options,
-                       &expanded_filter_spec);
-               set_helper_option(transport, "filter",
-                                 expanded_filter_spec.buf);
-               strbuf_release(&expanded_filter_spec);
+               const char *spec = expand_list_objects_filter_spec(
+                       &data->transport_options.filter_options);
+               set_helper_option(transport, "filter", spec);
        }
 
        if (data->transport_options.negotiation_tips)
@@ -1146,7 +1142,6 @@ static struct ref *get_refs_list_using_list(struct transport *transport,
 }
 
 static struct transport_vtable vtable = {
-       1,
        set_helper_option,
        get_refs_list,
        fetch,