{
struct object *obj = lookup_object(sha1);
if (!obj) {
- struct commit *ret = malloc(sizeof(struct commit));
+ struct commit *ret = xmalloc(sizeof(struct commit));
memset(ret, 0, sizeof(struct commit));
created_object(sha1, &ret->object);
+ ret->object.type = commit_type;
return ret;
}
- if (obj->parsed && obj->type != commit_type) {
+ if (obj->type != commit_type) {
error("Object %s is a %s, not a commit",
sha1_to_hex(sha1), obj->type);
return NULL;
if (!buffer)
return error("Could not read %s",
sha1_to_hex(item->object.sha1));
- if (strcmp(type, commit_type))
+ if (strcmp(type, commit_type)) {
+ free(buffer);
return error("Object %s not a commit",
sha1_to_hex(item->object.sha1));
- item->object.type = commit_type;
+ }
get_sha1_hex(bufptr + 5, parent);
item->tree = lookup_tree(parent);
- add_ref(&item->object, &item->tree->object);
+ if (item->tree)
+ add_ref(&item->object, &item->tree->object);
bufptr += 46; /* "tree " + "hex sha1" + "\n" */
while (!memcmp(bufptr, "parent ", 7) &&
!get_sha1_hex(bufptr + 7, parent)) {
- struct commit_list *new_parent =
- malloc(sizeof(struct commit_list));
- new_parent->next = item->parents;
- new_parent->item = lookup_commit(parent);
- add_ref(&item->object, &new_parent->item->object);
- item->parents = new_parent;
+ struct commit *new_parent = lookup_commit(parent);
+ if (new_parent) {
+ commit_list_insert(new_parent, &item->parents);
+ add_ref(&item->object, &new_parent->object);
+ }
bufptr += 48;
}
item->date = parse_commit_date(bufptr);
return 0;
}
+void commit_list_insert(struct commit *item, struct commit_list **list_p)
+{
+ struct commit_list *new_list = xmalloc(sizeof(struct commit_list));
+ new_list->item = item;
+ new_list->next = *list_p;
+ *list_p = new_list;
+}
+
void free_commit_list(struct commit_list *list)
{
while (list) {
free(temp);
}
}
+
+static void insert_by_date(struct commit_list **list, struct commit *item)
+{
+ struct commit_list **pp = list;
+ struct commit_list *p;
+ while ((p = *pp) != NULL) {
+ if (p->item->date < item->date) {
+ break;
+ }
+ pp = &p->next;
+ }
+ commit_list_insert(item, pp);
+}
+
+
+void sort_by_date(struct commit_list **list)
+{
+ struct commit_list *ret = NULL;
+ while (*list) {
+ insert_by_date(&ret, (*list)->item);
+ *list = (*list)->next;
+ }
+ *list = ret;
+}
+
+struct commit *pop_most_recent_commit(struct commit_list **list,
+ unsigned int mark)
+{
+ struct commit *ret = (*list)->item;
+ struct commit_list *parents = ret->parents;
+ struct commit_list *old = *list;
+
+ *list = (*list)->next;
+ free(old);
+
+ while (parents) {
+ struct commit *commit = parents->item;
+ parse_commit(commit);
+ if (!(commit->object.flags & mark)) {
+ commit->object.flags |= mark;
+ insert_by_date(list, commit);
+ }
+ parents = parents->next;
+ }
+ return ret;
+}