write-tree: Avoid leak when index refers to an invalid object

diff --git a/transport-helper.c b/transport-helper.c
index 0381de536846e6fef958ece86f07bbc5b4cf7e09..191fbf798a5e5db1abeafc719e8ec0d986a1050c 100644 (file)
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -727,10 +727,10 @@ static int push_refs_with_export(struct transport *transport,
                private = apply_refspecs(data->refspecs, data->refspec_nr, ref->name);
                if (private && !get_sha1(private, sha1)) {
                        strbuf_addf(&buf, "^%s", private);
-                       string_list_append(strbuf_detach(&buf, NULL), &revlist_args);
+                       string_list_append(&revlist_args, strbuf_detach(&buf, NULL));
                }
 
-               string_list_append(ref->name, &revlist_args);
+               string_list_append(&revlist_args, ref->name);
 
        }