rev-parse: better error message for ambiguous arguments

diff --git a/rev-list.c b/rev-list.c
index ee88f567a7c9413376669c01050a210241701012..a8fe83c5d805ea8944a07be3832977487b41080d 100644 (file)
--- a/rev-list.c
+++ b/rev-list.c
@@ -5,11 +5,12 @@
 #include "tree.h"
 #include "blob.h"
 #include "tree-walk.h"
+#include "diff.h"
 #include "revision.h"
 
-/* bits #0-5 in revision.h */
+/* bits #0-15 in revision.h */
 
-#define COUNTED                (1u<<6)
+#define COUNTED                (1u<<16)
 
 static const char rev_list_usage[] =
 "git-rev-list [OPTION] <commit-id>... [ -- paths... ]\n"
@@ -30,6 +31,7 @@ static const char rev_list_usage[] =
 "    --unpacked\n"
 "    --header | --pretty\n"
 "    --abbrev=nr | --no-abbrev\n"
+"    --abbrev-commit\n"
 "  special purpose:\n"
 "    --bisect"
 ;
@@ -39,7 +41,7 @@ struct rev_info revs;
 static int bisect_list = 0;
 static int verbose_header = 0;
 static int abbrev = DEFAULT_ABBREV;
-static int show_parents = 0;
+static int abbrev_commit = 0;
 static int show_timestamp = 0;
 static int hdr_termination = 0;
 static const char *commit_prefix = "";
@@ -53,8 +55,11 @@ static void show_commit(struct commit *commit)
                fputs(commit_prefix, stdout);
        if (commit->object.flags & BOUNDARY)
                putchar('-');
-       fputs(sha1_to_hex(commit->object.sha1), stdout);
-       if (show_parents) {
+       if (abbrev_commit && abbrev)
+               fputs(find_unique_abbrev(commit->object.sha1, abbrev), stdout);
+       else
+               fputs(sha1_to_hex(commit->object.sha1), stdout);
+       if (revs.parents) {
                struct commit_list *parents = commit->parents;
                while (parents) {
                        struct object *o = &(parents->item->object);
@@ -320,6 +325,14 @@ int main(int argc, const char **argv)
                        abbrev = 0;
                        continue;
                }
+               if (!strcmp(arg, "--abbrev")) {
+                       abbrev = DEFAULT_ABBREV;
+                       continue;
+               }
+               if (!strcmp(arg, "--abbrev-commit")) {
+                       abbrev_commit = 1;
+                       continue;
+               }
                if (!strncmp(arg, "--abbrev=", 9)) {
                        abbrev = strtoul(arg + 9, NULL, 10);
                        if (abbrev && abbrev < MINIMUM_ABBREV)
@@ -338,10 +351,6 @@ int main(int argc, const char **argv)
                                commit_prefix = "commit ";
                        continue;
                }
-               if (!strcmp(arg, "--parents")) {
-                       show_parents = 1;
-                       continue;
-               }
                if (!strcmp(arg, "--timestamp")) {
                        show_timestamp = 1;
                        continue;
@@ -362,6 +371,8 @@ int main(int argc, const char **argv)
 
        save_commit_buffer = verbose_header;
        track_object_refs = 0;
+       if (bisect_list)
+               revs.limited = 1;
 
        prepare_revision_walk(&revs);
        if (revs.tree_objects)