t6022: Add testcase for spurious "refusing to lose untracked" messages
[gitweb.git] / merge-recursive.c
index 500efffb34b6723cb2d4560af022a7595b93cc2a..c7d5a4591bdf16cb2d2b639e37192a1532fb26f1 100644 (file)
@@ -1037,24 +1037,97 @@ static void conflict_rename_delete(struct merge_options *o,
                                   const char *rename_branch,
                                   const char *other_branch)
 {
-       char *dest_name = pair->two->path;
-       int df_conflict = 0;
+       const struct diff_filespec *orig = pair->one;
+       const struct diff_filespec *dest = pair->two;
+       const char *path;
+       const unsigned char *a_sha = NULL;
+       const unsigned char *b_sha = NULL;
+       int a_mode = 0;
+       int b_mode = 0;
+
+       if (rename_branch == o->branch1) {
+               a_sha = dest->sha1;
+               a_mode = dest->mode;
+       } else {
+               b_sha = dest->sha1;
+               b_mode = dest->mode;
+       }
 
-       output(o, 1, "CONFLICT (rename/delete): Rename %s->%s in %s "
-              "and deleted in %s",
-              pair->one->path, pair->two->path, rename_branch,
-              other_branch);
-       if (!o->call_depth)
-               update_stages(dest_name, NULL,
-                             rename_branch == o->branch1 ? pair->two : NULL,
-                             rename_branch == o->branch1 ? NULL : pair->two);
-       if (dir_in_way(dest_name, !o->call_depth)) {
-               dest_name = unique_path(o, dest_name, rename_branch);
-               df_conflict = 1;
+       if (o->call_depth) {
+               remove_file_from_cache(dest->path);
+               path = orig->path;
+       } else {
+               path = dest->path;
+               update_stages(dest->path, NULL,
+                             rename_branch == o->branch1 ? dest : NULL,
+                             rename_branch == o->branch1 ? NULL : dest);
        }
-       update_file(o, 0, pair->two->sha1, pair->two->mode, dest_name);
-       if (df_conflict)
-               free(dest_name);
+
+       handle_change_delete(o,
+                            path,
+                            orig->sha1, orig->mode,
+                            a_sha, a_mode,
+                            b_sha, b_mode,
+                            "rename", "renamed");
+}
+
+static struct diff_filespec *filespec_from_entry(struct diff_filespec *target,
+                                                struct stage_data *entry,
+                                                int stage)
+{
+       unsigned char *sha = entry->stages[stage].sha;
+       unsigned mode = entry->stages[stage].mode;
+       if (mode == 0 || is_null_sha1(sha))
+               return NULL;
+       hashcpy(target->sha1, sha);
+       target->mode = mode;
+       return target;
+}
+
+static void handle_file(struct merge_options *o,
+                       struct diff_filespec *rename,
+                       int stage,
+                       struct rename_conflict_info *ci)
+{
+       char *dst_name = rename->path;
+       struct stage_data *dst_entry;
+       const char *cur_branch, *other_branch;
+       struct diff_filespec other;
+       struct diff_filespec *add;
+
+       if (stage == 2) {
+               dst_entry = ci->dst_entry1;
+               cur_branch = ci->branch1;
+               other_branch = ci->branch2;
+       } else {
+               dst_entry = ci->dst_entry2;
+               cur_branch = ci->branch2;
+               other_branch = ci->branch1;
+       }
+
+       add = filespec_from_entry(&other, dst_entry, stage ^ 1);
+       if (stage == 2)
+               update_stages(rename->path, NULL, rename, add);
+       else
+               update_stages(rename->path, NULL, add, rename);
+
+       if (add) {
+               char *add_name = unique_path(o, rename->path, other_branch);
+               update_file(o, 0, add->sha1, add->mode, add_name);
+
+               remove_file(o, 0, rename->path, 0);
+               dst_name = unique_path(o, rename->path, cur_branch);
+       } else {
+               if (dir_in_way(rename->path, !o->call_depth)) {
+                       dst_name = unique_path(o, rename->path, cur_branch);
+                       output(o, 1, "%s is a directory in %s adding as %s instead",
+                              rename->path, other_branch, dst_name);
+               }
+       }
+       update_file(o, 0, rename->sha1, rename->mode, dst_name);
+
+       if (dst_name != rename->path)
+               free(dst_name);
 }
 
 static void conflict_rename_rename_1to2(struct merge_options *o,
@@ -1064,10 +1137,6 @@ static void conflict_rename_rename_1to2(struct merge_options *o,
        struct diff_filespec *one = ci->pair1->one;
        struct diff_filespec *a = ci->pair1->two;
        struct diff_filespec *b = ci->pair2->two;
-       const char *dst_name_a = a->path;
-       const char *dst_name_b = b->path;
-       char *del[2];
-       int delp = 0;
 
        output(o, 1, "CONFLICT (rename/rename): "
               "Rename \"%s\"->\"%s\" in branch \"%s\" "
@@ -1075,16 +1144,6 @@ static void conflict_rename_rename_1to2(struct merge_options *o,
               one->path, a->path, ci->branch1,
               one->path, b->path, ci->branch2,
               o->call_depth ? " (left unresolved)" : "");
-       if (dir_in_way(a->path, !o->call_depth)) {
-               dst_name_a = del[delp++] = unique_path(o, a->path, ci->branch1);
-               output(o, 1, "%s is a directory in %s adding as %s instead",
-                      a->path, ci->branch2, dst_name_a);
-       }
-       if (dir_in_way(b->path, !o->call_depth)) {
-               dst_name_b = del[delp++] = unique_path(o, b->path, ci->branch2);
-               output(o, 1, "%s is a directory in %s adding as %s instead",
-                      b->path, ci->branch1, dst_name_b);
-       }
        if (o->call_depth) {
                struct merge_file_info mfi;
                mfi = merge_file(o, one->path,
@@ -1102,14 +1161,9 @@ static void conflict_rename_rename_1to2(struct merge_options *o,
                remove_file_from_cache(a->path);
                remove_file_from_cache(b->path);
        } else {
-               update_stages(a->path, NULL, a, NULL);
-               update_stages(b->path, NULL, NULL, b);
-
-               update_file(o, 0, a->sha1, a->mode, dst_name_a);
-               update_file(o, 0, b->sha1, b->mode, dst_name_b);
+               handle_file(o, a, 2, ci);
+               handle_file(o, b, 3, ci);
        }
-       while (delp--)
-               free(del[delp]);
 }
 
 static void conflict_rename_rename_2to1(struct merge_options *o,