Andrew's git / gitweb.git / blobdiff
?
Use xmalloc instead of malloc
[gitweb.git] / send-pack.c
diff --git a/send-pack.c b/send-pack.c
index b7cc1a90891328912e93e1d545d9b56269661b18..ac4501d34154301030cf98ff122eb233095417b7 100644 (file)
--- a/send-pack.c
+++ b/send-pack.c
@@ -9,10 +9,10 @@ static const char send_pack_usage[] =
 "git-send-pack [--all] [--exec=git-receive-pack] <remote> [<head>...]\n"
 "  --all and explicit <head> specification are mutually exclusive.";
 static const char *exec = "git-receive-pack";
-static int verbose = 0;
-static int send_all = 0;
-static int force_update = 0;
-static int use_thin_pack = 0;
+static int verbose;
+static int send_all;
+static int force_update;
+static int use_thin_pack;
 
 static int is_zero_sha1(const unsigned char *sha1)
 {
@@ -53,7 +53,7 @@ static void exec_rev_list(struct ref *refs)
                if (900 < i)
                        die("git-rev-list environment overflow");
                if (!is_zero_sha1(ref->new_sha1)) {
-                       char *buf = malloc(100);
+                       char *buf = xmalloc(100);
                        args[i++] = buf;
                        snprintf(buf, 50, "%s", sha1_to_hex(ref->new_sha1));
                        buf += 50;
@@ -75,7 +75,7 @@ static void exec_rev_list(struct ref *refs)
                if (is_zero_sha1(ref->new_sha1) &&
                    !is_zero_sha1(ref->old_sha1) &&
                    has_sha1_file(ref->old_sha1)) {
-                       char *buf = malloc(42);
+                       char *buf = xmalloc(42);
                        args[i++] = buf;
                        snprintf(buf, 42, "^%s", sha1_to_hex(ref->old_sha1));
                }
@@ -185,7 +185,7 @@ static int one_local_ref(const char *refname, const unsigned char *sha1)
        struct ref *ref;
        int len = strlen(refname) + 1;
        ref = xcalloc(1, sizeof(*ref) + len);
-       memcpy(ref->new_sha1, sha1, 20);
+       hashcpy(ref->new_sha1, sha1);
        memcpy(ref->name, refname, len);
        *local_tail = ref;
        local_tail = &ref->next;
@@ -265,7 +265,7 @@ static int send_pack(int in, int out, int nr_refspec, char **refspec)
                char old_hex[60], *new_hex;
                if (!ref->peer_ref)
                        continue;
-               if (!memcmp(ref->old_sha1, ref->peer_ref->new_sha1, 20)) {
+               if (!hashcmp(ref->old_sha1, ref->peer_ref->new_sha1)) {
                        if (verbose)
                                fprintf(stderr, "'%s': up-to-date\n", ref->name);
                        continue;
@@ -310,7 +310,7 @@ static int send_pack(int in, int out, int nr_refspec, char **refspec)
                                continue;
                        }
                }
-               memcpy(ref->new_sha1, ref->peer_ref->new_sha1, 20);
+               hashcpy(ref->new_sha1, ref->peer_ref->new_sha1);
                if (is_zero_sha1(ref->new_sha1)) {
                        error("cannot happen anymore");
                        ret = -3;