Limit the size of the new delta_base_cache
[gitweb.git] / builtin-describe.c
index e38c899251c7959720bc45cd0c63ef643d6b9580..165917e40db78e7105a16d6e7a1653862a29fdc5 100644 (file)
@@ -16,60 +16,27 @@ static int tags;    /* But allow any tags if --tags is specified */
 static int abbrev = DEFAULT_ABBREV;
 static int max_candidates = 10;
 
-static unsigned int names[256], allocs[256];
-static struct commit_name {
-       struct commit *commit;
+struct commit_name {
        int prio; /* annotated tag = 2, tag = 1, head = 0 */
        char path[FLEX_ARRAY]; /* more */
-} **name_array[256];
+};
 static const char *prio_names[] = {
        "head", "lightweight", "annotated",
 };
 
-static struct commit_name *match(struct commit *cmit)
-{
-       unsigned char level0 = cmit->object.sha1[0];
-       struct commit_name **p = name_array[level0];
-       unsigned int hi = names[level0];
-       unsigned int lo = 0;
-
-       while (lo < hi) {
-               unsigned int mi = (lo + hi) / 2;
-               int cmp = hashcmp(p[mi]->commit->object.sha1,
-                       cmit->object.sha1);
-               if (!cmp) {
-                       while (mi && p[mi - 1]->commit == cmit)
-                               mi--;
-                       return p[mi];
-               }
-               if (cmp > 0)
-                       hi = mi;
-               else
-                       lo = mi+1;
-       }
-       return NULL;
-}
-
 static void add_to_known_names(const char *path,
                               struct commit *commit,
                               int prio)
 {
-       int idx;
-       int len = strlen(path)+1;
-       struct commit_name *name = xmalloc(sizeof(struct commit_name) + len);
-       unsigned char m = commit->object.sha1[0];
-
-       name->commit = commit;
-       name->prio = prio;
-       memcpy(name->path, path, len);
-       idx = names[m];
-       if (idx >= allocs[m]) {
-               allocs[m] = (idx + 50) * 3 / 2;
-               name_array[m] = xrealloc(name_array[m],
-                       allocs[m] * sizeof(*name_array));
+       struct commit_name *e = commit->util;
+       if (!e || e->prio < prio) {
+               size_t len = strlen(path)+1;
+               free(e);
+               e = xmalloc(sizeof(struct commit_name) + len);
+               e->prio = prio;
+               memcpy(e->path, path, len);
+               commit->util = e;
        }
-       name_array[m][idx] = name;
-       names[m] = ++idx;
 }
 
 static int get_name(const char *path, const unsigned char *sha1, int flag, void *cb_data)
@@ -85,7 +52,7 @@ static int get_name(const char *path, const unsigned char *sha1, int flag, void
         * If --tags, then any tags are used.
         * Otherwise only annotated tags are used.
         */
-       if (!strncmp(path, "refs/tags/", 10)) {
+       if (!prefixcmp(path, "refs/tags/")) {
                if (object->type == OBJ_TAG)
                        prio = 2;
                else
@@ -104,21 +71,6 @@ static int get_name(const char *path, const unsigned char *sha1, int flag, void
        return 0;
 }
 
-static int compare_names(const void *_a, const void *_b)
-{
-       struct commit_name *a = *(struct commit_name **)_a;
-       struct commit_name *b = *(struct commit_name **)_b;
-       unsigned long a_date = a->commit->date;
-       unsigned long b_date = b->commit->date;
-       int cmp = hashcmp(a->commit->object.sha1, b->commit->object.sha1);
-
-       if (cmp)
-               return cmp;
-       if (a->prio != b->prio)
-               return b->prio - a->prio;
-       return (a_date > b_date) ? -1 : (a_date == b_date) ? 0 : 1;
-}
-
 struct possible_tag {
        struct commit_name *name;
        int depth;
@@ -139,6 +91,39 @@ static int compare_pt(const void *a_, const void *b_)
        return 0;
 }
 
+static unsigned long finish_depth_computation(
+       struct commit_list **list,
+       struct possible_tag *best)
+{
+       unsigned long seen_commits = 0;
+       while (*list) {
+               struct commit *c = pop_commit(list);
+               struct commit_list *parents = c->parents;
+               seen_commits++;
+               if (c->object.flags & best->flag_within) {
+                       struct commit_list *a = *list;
+                       while (a) {
+                               struct commit *i = a->item;
+                               if (!(i->object.flags & best->flag_within))
+                                       break;
+                               a = a->next;
+                       }
+                       if (!a)
+                               break;
+               } else
+                       best->depth++;
+               while (parents) {
+                       struct commit *p = parents->item;
+                       parse_commit(p);
+                       if (!(p->object.flags & SEEN))
+                               insert_by_date(p, list);
+                       p->object.flags |= c->object.flags;
+                       parents = parents->next;
+               }
+       }
+       return seen_commits;
+}
+
 static void describe(const char *arg, int last_one)
 {
        unsigned char sha1[20];
@@ -149,7 +134,6 @@ static void describe(const char *arg, int last_one)
        struct possible_tag all_matches[MAX_TAGS];
        unsigned int match_cnt = 0, annotated_cnt = 0, cur_match;
        unsigned long seen_commits = 0;
-       int found = 0;
 
        if (get_sha1(arg, sha1))
                die("Not a valid object name %s", arg);
@@ -158,15 +142,11 @@ static void describe(const char *arg, int last_one)
                die("%s is not a valid '%s' object", arg, commit_type);
 
        if (!initialized) {
-               unsigned int m;
                initialized = 1;
                for_each_ref(get_name, NULL);
-               for (m = 0; m < ARRAY_SIZE(name_array); m++)
-                       qsort(name_array[m], names[m],
-                               sizeof(*name_array[m]), compare_names);
        }
 
-       n = match(cmit);
+       n = cmit->util;
        if (n) {
                printf("%s\n", n->path);
                return;
@@ -182,14 +162,14 @@ static void describe(const char *arg, int last_one)
                struct commit *c = pop_commit(&list);
                struct commit_list *parents = c->parents;
                seen_commits++;
-               n = match(c);
+               n = c->util;
                if (n) {
                        if (match_cnt < max_candidates) {
                                struct possible_tag *t = &all_matches[match_cnt++];
                                t->name = n;
                                t->depth = seen_commits - 1;
                                t->flag_within = 1u << match_cnt;
-                               t->found_order = found++;
+                               t->found_order = match_cnt;
                                c->object.flags |= t->flag_within;
                                if (n->prio == 2)
                                        annotated_cnt++;
@@ -219,12 +199,19 @@ static void describe(const char *arg, int last_one)
                        parents = parents->next;
                }
        }
-       free_commit_list(list);
 
        if (!match_cnt)
                die("cannot describe '%s'", sha1_to_hex(cmit->object.sha1));
 
        qsort(all_matches, match_cnt, sizeof(all_matches[0]), compare_pt);
+
+       if (gave_up_on) {
+               insert_by_date(gave_up_on, &list);
+               seen_commits--;
+       }
+       seen_commits += finish_depth_computation(&list, &all_matches[0]);
+       free_commit_list(list);
+
        if (debug) {
                for (cur_match = 0; cur_match < match_cnt; cur_match++) {
                        struct possible_tag *t = &all_matches[cur_match];
@@ -241,8 +228,12 @@ static void describe(const char *arg, int last_one)
                                sha1_to_hex(gave_up_on->object.sha1));
                }
        }
-       printf("%s-g%s\n", all_matches[0].name->path,
-                  find_unique_abbrev(cmit->object.sha1, abbrev));
+       if (abbrev == 0)
+               printf("%s\n", all_matches[0].name->path );
+       else
+               printf("%s-%d-g%s\n", all_matches[0].name->path,
+                      all_matches[0].depth,
+                      find_unique_abbrev(cmit->object.sha1, abbrev));
 
        if (!last_one)
                clear_commit_marks(cmit, -1);
@@ -263,12 +254,12 @@ int cmd_describe(int argc, const char **argv, const char *prefix)
                        all = 1;
                else if (!strcmp(arg, "--tags"))
                        tags = 1;
-               else if (!strncmp(arg, "--abbrev=", 9)) {
+               else if (!prefixcmp(arg, "--abbrev=")) {
                        abbrev = strtoul(arg + 9, NULL, 10);
-                       if (abbrev < MINIMUM_ABBREV || 40 < abbrev)
+                       if (abbrev != 0 && (abbrev < MINIMUM_ABBREV || 40 < abbrev))
                                abbrev = DEFAULT_ABBREV;
                }
-               else if (!strncmp(arg, "--candidates=", 13)) {
+               else if (!prefixcmp(arg, "--candidates=")) {
                        max_candidates = strtoul(arg + 13, NULL, 10);
                        if (max_candidates < 1)
                                max_candidates = 1;