bisect: print an error message when "git rev-list --bisect-vars" fails

diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
index 09d56e0839f042a74bee5c13ab251f19fcc2c76e..1a7141ecd7ad1ffcd5081181548920b6a199ab2c 100755 (executable)
--- a/t/t7004-tag.sh
+++ b/t/t7004-tag.sh
@@ -26,8 +26,8 @@ test_expect_success 'listing all tags in an empty tree should output nothing' '
        test `git-tag | wc -l` -eq 0
 '
 
-test_expect_failure 'looking for a tag in an empty tree should fail' \
-       'tag_exists mytag'
+test_expect_success 'looking for a tag in an empty tree should fail' \
+       '! (tag_exists mytag)'
 
 test_expect_success 'creating a tag in an empty tree should fail' '
        ! git-tag mynotag &&
@@ -83,9 +83,9 @@ test_expect_success \
 
 # special cases for creating tags:
 
-test_expect_failure \
+test_expect_success \
        'trying to create a tag with the name of one existing should fail' \
-       'git tag mytag'
+       '! git tag mytag'
 
 test_expect_success \
        'trying to create a tag with a non-valid name should fail' '
@@ -146,8 +146,8 @@ test_expect_success \
        ! tag_exists myhead
 '
 
-test_expect_failure 'trying to delete an already deleted tag should fail' \
-       'git-tag -d mytag'
+test_expect_success 'trying to delete an already deleted tag should fail' \
+       '! git-tag -d mytag'
 
 # listing various tags with pattern matching:
 
@@ -265,16 +265,16 @@ test_expect_success \
        test $(git rev-parse non-annotated-tag) = $(git rev-parse HEAD)
 '
 
-test_expect_failure 'trying to verify an unknown tag should fail' \
-       'git-tag -v unknown-tag'
+test_expect_success 'trying to verify an unknown tag should fail' \
+       '! git-tag -v unknown-tag'
 
-test_expect_failure \
+test_expect_success \
        'trying to verify a non-annotated and non-signed tag should fail' \
-       'git-tag -v non-annotated-tag'
+       '! git-tag -v non-annotated-tag'
 
-test_expect_failure \
+test_expect_success \
        'trying to verify many non-annotated or unknown tags, should fail' \
-       'git-tag -v unknown-tag1 non-annotated-tag unknown-tag2'
+       '! git-tag -v unknown-tag1 non-annotated-tag unknown-tag2'
 
 # creating annotated tags:
 
@@ -491,25 +491,21 @@ test_expect_success \
        echo "tag-one-line" >expect &&
        git-tag -l | grep "^tag-one-line" >actual &&
        git diff expect actual &&
-       git-tag -n 0 -l | grep "^tag-one-line" >actual &&
+       git-tag -n0 -l | grep "^tag-one-line" >actual &&
        git diff expect actual &&
-       git-tag -n 0 -l tag-one-line >actual &&
+       git-tag -n0 -l tag-one-line >actual &&
        git diff expect actual &&
 
        echo "tag-one-line    A msg" >expect &&
-       git-tag -n xxx -l | grep "^tag-one-line" >actual &&
-       git diff expect actual &&
-       git-tag -n "" -l | grep "^tag-one-line" >actual &&
-       git diff expect actual &&
-       git-tag -n 1 -l | grep "^tag-one-line" >actual &&
+       git-tag -n1 -l | grep "^tag-one-line" >actual &&
        git diff expect actual &&
        git-tag -n -l | grep "^tag-one-line" >actual &&
        git diff expect actual &&
-       git-tag -n 1 -l tag-one-line >actual &&
+       git-tag -n1 -l tag-one-line >actual &&
        git diff expect actual &&
-       git-tag -n 2 -l tag-one-line >actual &&
+       git-tag -n2 -l tag-one-line >actual &&
        git diff expect actual &&
-       git-tag -n 999 -l tag-one-line >actual &&
+       git-tag -n999 -l tag-one-line >actual &&
        git diff expect actual
 '
 
@@ -520,21 +516,21 @@ test_expect_success \
        echo "tag-zero-lines" >expect &&
        git-tag -l | grep "^tag-zero-lines" >actual &&
        git diff expect actual &&
-       git-tag -n 0 -l | grep "^tag-zero-lines" >actual &&
+       git-tag -n0 -l | grep "^tag-zero-lines" >actual &&
        git diff expect actual &&
-       git-tag -n 0 -l tag-zero-lines >actual &&
+       git-tag -n0 -l tag-zero-lines >actual &&
        git diff expect actual &&
 
        echo "tag-zero-lines  " >expect &&
-       git-tag -n 1 -l | grep "^tag-zero-lines" >actual &&
+       git-tag -n1 -l | grep "^tag-zero-lines" >actual &&
        git diff expect actual &&
        git-tag -n -l | grep "^tag-zero-lines" >actual &&
        git diff expect actual &&
-       git-tag -n 1 -l tag-zero-lines >actual &&
+       git-tag -n1 -l tag-zero-lines >actual &&
        git diff expect actual &&
-       git-tag -n 2 -l tag-zero-lines >actual &&
+       git-tag -n2 -l tag-zero-lines >actual &&
        git diff expect actual &&
-       git-tag -n 999 -l tag-zero-lines >actual &&
+       git-tag -n999 -l tag-zero-lines >actual &&
        git diff expect actual
 '
 
@@ -548,40 +544,48 @@ test_expect_success \
        echo "tag-lines" >expect &&
        git-tag -l | grep "^tag-lines" >actual &&
        git diff expect actual &&
-       git-tag -n 0 -l | grep "^tag-lines" >actual &&
+       git-tag -n0 -l | grep "^tag-lines" >actual &&
        git diff expect actual &&
-       git-tag -n 0 -l tag-lines >actual &&
+       git-tag -n0 -l tag-lines >actual &&
        git diff expect actual &&
 
        echo "tag-lines       tag line one" >expect &&
-       git-tag -n 1 -l | grep "^tag-lines" >actual &&
+       git-tag -n1 -l | grep "^tag-lines" >actual &&
        git diff expect actual &&
        git-tag -n -l | grep "^tag-lines" >actual &&
        git diff expect actual &&
-       git-tag -n 1 -l tag-lines >actual &&
+       git-tag -n1 -l tag-lines >actual &&
        git diff expect actual &&
 
        echo "    tag line two" >>expect &&
-       git-tag -n 2 -l | grep "^ *tag.line" >actual &&
+       git-tag -n2 -l | grep "^ *tag.line" >actual &&
        git diff expect actual &&
-       git-tag -n 2 -l tag-lines >actual &&
+       git-tag -n2 -l tag-lines >actual &&
        git diff expect actual &&
 
        echo "    tag line three" >>expect &&
-       git-tag -n 3 -l | grep "^ *tag.line" >actual &&
+       git-tag -n3 -l | grep "^ *tag.line" >actual &&
        git diff expect actual &&
-       git-tag -n 3 -l tag-lines >actual &&
+       git-tag -n3 -l tag-lines >actual &&
        git diff expect actual &&
-       git-tag -n 4 -l | grep "^ *tag.line" >actual &&
+       git-tag -n4 -l | grep "^ *tag.line" >actual &&
        git diff expect actual &&
-       git-tag -n 4 -l tag-lines >actual &&
+       git-tag -n4 -l tag-lines >actual &&
        git diff expect actual &&
-       git-tag -n 99 -l | grep "^ *tag.line" >actual &&
+       git-tag -n99 -l | grep "^ *tag.line" >actual &&
        git diff expect actual &&
-       git-tag -n 99 -l tag-lines >actual &&
+       git-tag -n99 -l tag-lines >actual &&
        git diff expect actual
 '
 
+# subsequent tests require gpg; check if it is available
+gpg --version >/dev/null
+if [ $? -eq 127 ]; then
+       echo "gpg not found - skipping tag signing and verification tests"
+       test_done
+       exit
+fi
+
 # trying to verify annotated non-signed tags:
 
 test_expect_success \
@@ -604,13 +608,6 @@ test_expect_success \
 
 # creating and verifying signed tags:
 
-gpg --version >/dev/null
-if [ $? -eq 127 ]; then
-       echo "Skipping signed tags tests, because gpg was not found"
-       test_done
-       exit
-fi
-
 # As said here: http://www.gnupg.org/documentation/faqs.html#q6.19
 # the gpg version 1.0.6 didn't parse trust packets correctly, so for
 # that version, creation of signed tags using the generated key fails.
@@ -906,25 +903,21 @@ test_expect_success \
        echo "stag-one-line" >expect &&
        git-tag -l | grep "^stag-one-line" >actual &&
        git diff expect actual &&
-       git-tag -n 0 -l | grep "^stag-one-line" >actual &&
+       git-tag -n0 -l | grep "^stag-one-line" >actual &&
        git diff expect actual &&
-       git-tag -n 0 -l stag-one-line >actual &&
+       git-tag -n0 -l stag-one-line >actual &&
        git diff expect actual &&
 
        echo "stag-one-line   A message line signed" >expect &&
-       git-tag -n xxx -l | grep "^stag-one-line" >actual &&
-       git diff expect actual &&
-       git-tag -n "" -l | grep "^stag-one-line" >actual &&
-       git diff expect actual &&
-       git-tag -n 1 -l | grep "^stag-one-line" >actual &&
+       git-tag -n1 -l | grep "^stag-one-line" >actual &&
        git diff expect actual &&
        git-tag -n -l | grep "^stag-one-line" >actual &&
        git diff expect actual &&
-       git-tag -n 1 -l stag-one-line >actual &&
+       git-tag -n1 -l stag-one-line >actual &&
        git diff expect actual &&
-       git-tag -n 2 -l stag-one-line >actual &&
+       git-tag -n2 -l stag-one-line >actual &&
        git diff expect actual &&
-       git-tag -n 999 -l stag-one-line >actual &&
+       git-tag -n999 -l stag-one-line >actual &&
        git diff expect actual
 '
 
@@ -935,21 +928,21 @@ test_expect_success \
        echo "stag-zero-lines" >expect &&
        git-tag -l | grep "^stag-zero-lines" >actual &&
        git diff expect actual &&
-       git-tag -n 0 -l | grep "^stag-zero-lines" >actual &&
+       git-tag -n0 -l | grep "^stag-zero-lines" >actual &&
        git diff expect actual &&
-       git-tag -n 0 -l stag-zero-lines >actual &&
+       git-tag -n0 -l stag-zero-lines >actual &&
        git diff expect actual &&
 
        echo "stag-zero-lines " >expect &&
-       git-tag -n 1 -l | grep "^stag-zero-lines" >actual &&
+       git-tag -n1 -l | grep "^stag-zero-lines" >actual &&
        git diff expect actual &&
        git-tag -n -l | grep "^stag-zero-lines" >actual &&
        git diff expect actual &&
-       git-tag -n 1 -l stag-zero-lines >actual &&
+       git-tag -n1 -l stag-zero-lines >actual &&
        git diff expect actual &&
-       git-tag -n 2 -l stag-zero-lines >actual &&
+       git-tag -n2 -l stag-zero-lines >actual &&
        git diff expect actual &&
-       git-tag -n 999 -l stag-zero-lines >actual &&
+       git-tag -n999 -l stag-zero-lines >actual &&
        git diff expect actual
 '
 
@@ -963,37 +956,37 @@ test_expect_success \
        echo "stag-lines" >expect &&
        git-tag -l | grep "^stag-lines" >actual &&
        git diff expect actual &&
-       git-tag -n 0 -l | grep "^stag-lines" >actual &&
+       git-tag -n0 -l | grep "^stag-lines" >actual &&
        git diff expect actual &&
-       git-tag -n 0 -l stag-lines >actual &&
+       git-tag -n0 -l stag-lines >actual &&
        git diff expect actual &&
 
        echo "stag-lines      stag line one" >expect &&
-       git-tag -n 1 -l | grep "^stag-lines" >actual &&
+       git-tag -n1 -l | grep "^stag-lines" >actual &&
        git diff expect actual &&
        git-tag -n -l | grep "^stag-lines" >actual &&
        git diff expect actual &&
-       git-tag -n 1 -l stag-lines >actual &&
+       git-tag -n1 -l stag-lines >actual &&
        git diff expect actual &&
 
        echo "    stag line two" >>expect &&
-       git-tag -n 2 -l | grep "^ *stag.line" >actual &&
+       git-tag -n2 -l | grep "^ *stag.line" >actual &&
        git diff expect actual &&
-       git-tag -n 2 -l stag-lines >actual &&
+       git-tag -n2 -l stag-lines >actual &&
        git diff expect actual &&
 
        echo "    stag line three" >>expect &&
-       git-tag -n 3 -l | grep "^ *stag.line" >actual &&
+       git-tag -n3 -l | grep "^ *stag.line" >actual &&
        git diff expect actual &&
-       git-tag -n 3 -l stag-lines >actual &&
+       git-tag -n3 -l stag-lines >actual &&
        git diff expect actual &&
-       git-tag -n 4 -l | grep "^ *stag.line" >actual &&
+       git-tag -n4 -l | grep "^ *stag.line" >actual &&
        git diff expect actual &&
-       git-tag -n 4 -l stag-lines >actual &&
+       git-tag -n4 -l stag-lines >actual &&
        git diff expect actual &&
-       git-tag -n 99 -l | grep "^ *stag.line" >actual &&
+       git-tag -n99 -l | grep "^ *stag.line" >actual &&
        git diff expect actual &&
-       git-tag -n 99 -l stag-lines >actual &&
+       git-tag -n99 -l stag-lines >actual &&
        git diff expect actual
 '
 
@@ -1035,21 +1028,21 @@ test_expect_success \
 
 # try to sign with bad user.signingkey
 git config user.signingkey BobTheMouse
-test_expect_failure \
+test_expect_success \
        'git-tag -s fails if gpg is misconfigured' \
-       'git tag -s -m tail tag-gpg-failure'
+       '! git tag -s -m tail tag-gpg-failure'
 git config --unset user.signingkey
 
 # try to verify without gpg:
 
 rm -rf gpghome
-test_expect_failure \
+test_expect_success \
        'verify signed tag fails when public key is not present' \
-       'git-tag -v signed-tag'
+       '! git-tag -v signed-tag'
 
-test_expect_failure \
+test_expect_success \
        'git-tag -a fails if tag annotation is empty' '
-       GIT_EDITOR=cat git tag -a initial-comment
+       ! (GIT_EDITOR=cat git tag -a initial-comment)
 '
 
 test_expect_success \