GIT v1.5.3-rc2

diff --git a/builtin-check-attr.c b/builtin-check-attr.c
index 47b07210d61ad53c5d68e6c5dea767e2f52a131a..9d77f76ff1230df76278b528ef44d6837edb2741 100644 (file)
--- a/builtin-check-attr.c
+++ b/builtin-check-attr.c
@@ -29,8 +29,12 @@ int cmd_check_attr(int argc, const char **argv, const char *prefix)
        check = xcalloc(cnt, sizeof(*check));
        for (i = 0; i < cnt; i++) {
                const char *name;
+               struct git_attr *a;
                name = argv[i + 1];
-               check[i].attr = git_attr(name, strlen(name));
+               a = git_attr(name, strlen(name));
+               if (!a)
+                       return error("%s: not a valid attribute name", name);
+               check[i].attr = a;
        }
 
        for (i = doubledash; i < argc; i++) {
@@ -38,11 +42,17 @@ int cmd_check_attr(int argc, const char **argv, const char *prefix)
                if (git_checkattr(argv[i], cnt, check))
                        die("git_checkattr died");
                for (j = 0; j < cnt; j++) {
+                       const char *value = check[j].value;
+
+                       if (ATTR_TRUE(value))
+                               value = "set";
+                       else if (ATTR_FALSE(value))
+                               value = "unset";
+                       else if (ATTR_UNSET(value))
+                               value = "unspecified";
+
                        write_name_quoted("", 0, argv[i], 1, stdout);
-                       printf(": %s: %s\n", argv[j+1],
-                              (check[j].isset < 0) ? "unspecified" :
-                              (check[j].isset == 0) ? "unset" :
-                              "set");
+                       printf(": %s: %s\n", argv[j+1], value);
                }
        }
        return 0;