revision: replace "struct cmdline_pathspec" with argv_array

diff --git a/transport-helper.c b/transport-helper.c
index 8f68d69a86bd919162b62514af0b1d1d55e204a1..42b960ff86d24c9e2659f01a63a8f7a5efbc853c 100644 (file)
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -604,6 +604,7 @@ static int process_connect_service(struct transport *transport,
                        cmdbuf.buf);
 
 exit:
+       strbuf_release(&cmdbuf);
        fclose(input);
        return ret;
 }
@@ -1117,6 +1118,13 @@ int transport_helper_init(struct transport *transport, const char *name)
 __attribute__((format (printf, 1, 2)))
 static void transfer_debug(const char *fmt, ...)
 {
+       /*
+        * NEEDSWORK: This function is sometimes used from multiple threads, and
+        * we end up using debug_enabled racily. That "should not matter" since
+        * we always write the same value, but it's still wrong. This function
+        * is listed in .tsan-suppressions for the time being.
+        */
+
        va_list args;
        char msgbuf[PBUFFERSIZE];
        static int debug_enabled = -1;