Merge branch 'nd/completion-no-cache-failure' into maint

diff --git a/submodule.c b/submodule.c
index 150d95589949addfe06af32564748e5b4f1346c6..2cfaba059993e356e11eeabfaf5f67e9e26a3519 100644 (file)
--- a/submodule.c
+++ b/submodule.c
@@ -1548,6 +1548,13 @@ static int fetch_finish(int retvalue, struct strbuf *err,
        struct oid_array *commits;
 
        if (retvalue)
+               /*
+                * NEEDSWORK: This indicates that the overall fetch
+                * failed, even though there may be a subsequent fetch
+                * by commit hash that might work. It may be a good
+                * idea to not indicate failure in this case, and only
+                * indicate failure if the subsequent fetch fails.
+                */
                spf->result = 1;
 
        if (!task || !task->sub)