git-gui: Allow adding untracked files in selection.
[gitweb.git] / git-gui
diff --git a/git-gui b/git-gui
index c35c73c8c3a603efb3ec8580e3bbea51721d8fb7..d1054f6632794dc35e80c993033062aa0da45f95 100755 (executable)
--- a/git-gui
+++ b/git-gui
@@ -130,12 +130,15 @@ proc error_popup {msg} {
                        end]
                append title {)}
        }
-       tk_messageBox \
-               -parent . \
+       set cmd [list tk_messageBox \
                -icon error \
                -type ok \
                -title "$title: error" \
-               -message $msg
+               -message $msg]
+       if {[winfo ismapped .]} {
+               lappend cmd -parent .
+       }
+       eval $cmd
 }
 
 proc info_popup {msg} {
@@ -199,10 +202,6 @@ set last_clicked {}
 set disable_on_lock [list]
 set index_lock_type none
 
-set HEAD {}
-set PARENT {}
-set commit_type {}
-
 proc lock_index {type} {
        global index_lock_type disable_on_lock
 
@@ -212,7 +211,7 @@ proc lock_index {type} {
                        uplevel #0 $w disabled
                }
                return 1
-       } elseif {$index_lock_type eq {begin-update} && $type eq {update}} {
+       } elseif {$index_lock_type eq "begin-$type"} {
                set index_lock_type $type
                return 1
        }
@@ -237,6 +236,7 @@ proc repository_state {hdvar ctvar} {
        upvar $hdvar hd $ctvar ct
 
        if {[catch {set hd [exec git rev-parse --verify HEAD]}]} {
+               set hd {}
                set ct initial
        } elseif {[file exists [file join $gitdir MERGE_HEAD]]} {
                set ct merge
@@ -245,6 +245,18 @@ proc repository_state {hdvar ctvar} {
        }
 }
 
+proc PARENT {} {
+       global PARENT empty_tree
+
+       if {$PARENT ne {}} {
+               return $PARENT
+       }
+       if {$empty_tree eq {}} {
+               set empty_tree [exec git mktree << {}]
+       }
+       return $empty_tree
+}
+
 proc rescan {after} {
        global HEAD PARENT commit_type
        global ui_index ui_other ui_status_value ui_comm
@@ -254,7 +266,7 @@ proc rescan {after} {
        if {$rescan_active > 0 || ![lock_index read]} return
 
        repository_state new_HEAD new_type
-       if {$commit_type eq {amend}
+       if {[string match amend* $commit_type]
                && $new_type eq {normal}
                && $new_HEAD eq $HEAD} {
        } else {
@@ -293,10 +305,8 @@ proc rescan {after} {
 }
 
 proc rescan_stage2 {fd after} {
-       global gitdir PARENT commit_type
-       global ui_index ui_other ui_status_value ui_comm
-       global rescan_active
-       global buf_rdi buf_rdf buf_rlo
+       global gitdir ui_status_value
+       global rescan_active buf_rdi buf_rdf buf_rlo
 
        if {$fd ne {}} {
                read $fd
@@ -317,7 +327,7 @@ proc rescan_stage2 {fd after} {
 
        set rescan_active 3
        set ui_status_value {Scanning for modified files ...}
-       set fd_di [open "| git diff-index --cached -z $PARENT" r]
+       set fd_di [open "| git diff-index --cached -z [PARENT]" r]
        set fd_df [open "| git diff-files -z" r]
        set fd_lo [open $ls_others r]
 
@@ -363,7 +373,7 @@ proc read_diff_index {fd after} {
                incr z2 -1
                display_file \
                        [string range $buf_rdi $z1 $z2] \
-                       [string index $buf_rdi [expr {$z1 - 2}]]_
+                       [string index $buf_rdi [expr {$z1 - 2}]]?
                incr c
        }
        if {$c < $n} {
@@ -392,7 +402,7 @@ proc read_diff_files {fd after} {
                incr z2 -1
                display_file \
                        [string range $buf_rdf $z1 $z2] \
-                       _[string index $buf_rdf [expr {$z1 - 2}]]
+                       ?[string index $buf_rdf [expr {$z1 - 2}]]
                incr c
        }
        if {$c < $n} {
@@ -411,7 +421,7 @@ proc read_ls_others {fd after} {
        set pck [split $buf_rlo "\0"]
        set buf_rlo [lindex $pck end]
        foreach p [lrange $pck 0 end-1] {
-               display_file $p _O
+               display_file $p ?O
        }
        rescan_done $fd buf_rlo $after
 }
@@ -529,7 +539,7 @@ files list, to prevent possible confusion.
 
 proc show_diff {path {w {}} {lno {}}} {
        global file_states file_lists
-       global PARENT diff_3way diff_active repo_config
+       global diff_3way diff_active repo_config
        global ui_diff current_diff ui_status_value
 
        if {$diff_active || ![lock_index read]} return
@@ -588,7 +598,7 @@ proc show_diff {path {w {}} {lno {}}} {
        }
        }
 
-       lappend cmd $PARENT
+       lappend cmd [PARENT]
        lappend cmd --
        lappend cmd $path
 
@@ -668,7 +678,7 @@ proc read_diff {fd} {
 proc load_last_commit {} {
        global HEAD PARENT commit_type ui_comm
 
-       if {$commit_type eq {amend}} return
+       if {[string match amend* $commit_type]} return
        if {$commit_type ne {normal}} {
                error_popup "Can't amend a $commit_type commit."
                return
@@ -692,44 +702,76 @@ proc load_last_commit {} {
                return
        }
 
+       if {$parent_count > 1} {
+               error_popup {Can't amend a merge commit.}
+               return
+       }
+
        if {$parent_count == 0} {
-               set commit_type amend
-               set HEAD {}
+               set commit_type amend-initial
                set PARENT {}
-               rescan {set ui_status_value {Ready.}}
        } elseif {$parent_count == 1} {
                set commit_type amend
                set PARENT $parent
-               $ui_comm delete 0.0 end
-               $ui_comm insert end $msg
-               $ui_comm edit modified false
-               $ui_comm edit reset
-               rescan {set ui_status_value {Ready.}}
-       } else {
-               error_popup {You can't amend a merge commit.}
-               return
        }
+
+       $ui_comm delete 0.0 end
+       $ui_comm insert end $msg
+       $ui_comm edit modified false
+       $ui_comm edit reset
+       rescan {set ui_status_value {Ready.}}
+}
+
+proc create_new_commit {} {
+       global commit_type ui_comm
+
+       set commit_type normal
+       $ui_comm delete 0.0 end
+       $ui_comm edit modified false
+       $ui_comm edit reset
+       rescan {set ui_status_value {Ready.}}
+}
+
+set GIT_COMMITTER_IDENT {}
+
+proc committer_ident {} {
+       global GIT_COMMITTER_IDENT
+
+       if {$GIT_COMMITTER_IDENT eq {}} {
+               if {[catch {set me [exec git var GIT_COMMITTER_IDENT]} err]} {
+                       error_popup "Unable to obtain your identity:\n\n$err"
+                       return {}
+               }
+               if {![regexp {^(.*) [0-9]+ [-+0-9]+$} \
+                       $me me GIT_COMMITTER_IDENT]} {
+                       error_popup "Invalid GIT_COMMITTER_IDENT:\n\n$me"
+                       return {}
+               }
+       }
+
+       return $GIT_COMMITTER_IDENT
 }
 
 proc commit_tree {} {
        global HEAD commit_type file_states ui_comm repo_config
 
        if {![lock_index update]} return
+       if {[committer_ident] eq {}} return
 
        # -- Our in memory state should match the repository.
        #
        repository_state curHEAD cur_type
-       if {$commit_type eq {amend}
+       if {[string match amend* $commit_type]
                && $cur_type eq {normal}
                && $curHEAD eq $HEAD} {
        } elseif {$commit_type ne $cur_type || $HEAD ne $curHEAD} {
-               error_popup {Last scanned state does not match repository state.
+               info_popup {Last scanned state does not match repository state.
 
-Its highly likely that another Git program modified the
-repository since the last scan.  A rescan is required
-before committing.
+Another Git program has modified this repository
+since the last scan.  A rescan must be performed
+before another commit can be created.
 
-A rescan will be automatically started now.
+The rescan will be automatically started now.
 }
                unlock_index
                rescan {set ui_status_value {Ready.}}
@@ -869,7 +911,7 @@ proc commit_writetree {curHEAD msg} {
 
 proc commit_committree {fd_wt curHEAD msg} {
        global single_commit gitdir HEAD PARENT commit_type tcl_platform
-       global ui_status_value ui_comm
+       global ui_status_value ui_comm selected_commit_type
        global file_states selected_paths
 
        gets $fd_wt tree_id
@@ -969,6 +1011,7 @@ proc commit_committree {fd_wt curHEAD msg} {
        # -- Update status without invoking any git commands.
        #
        set commit_type normal
+       set selected_commit_type new
        set HEAD $cmt_id
        set PARENT $cmt_id
 
@@ -1054,13 +1097,14 @@ Commit or throw away all changes before starting a pull operation.
 }
 
 proc post_pull_remote {remote branch success} {
-       global HEAD PARENT commit_type
+       global HEAD PARENT commit_type selected_commit_type
        global ui_status_value
 
        unlock_index
        if {$success} {
                repository_state HEAD commit_type
                set PARENT $HEAD
+               set selected_commit_type new
                set $ui_status_value "Pulling $branch from $remote complete."
        } else {
                set m "Conflicts detected while pulling $branch from $remote."
@@ -1135,15 +1179,15 @@ proc merge_state {path new_state} {
                set icon [lindex $info 1]
        }
 
-       if {$s0 eq {_}} {
+       if {$s0 eq {?}} {
                set s0 [string index $state 0]
-       } elseif {$s0 eq {*}} {
+       } elseif {$s0 eq {_}} {
                set s0 _
        }
 
-       if {$s1 eq {_}} {
+       if {$s1 eq {?}} {
                set s1 [string index $state 1]
-       } elseif {$s1 eq {*}} {
+       } elseif {$s1 eq {_}} {
                set s1 _
        }
 
@@ -1235,12 +1279,11 @@ proc display_all_files {} {
 }
 
 proc update_index {msg pathList after} {
-       global update_index_cp update_index_rsd ui_status_value
+       global update_index_cp ui_status_value
 
        if {![lock_index update]} return
 
        set update_index_cp 0
-       set update_index_rsd 0
        set pathList [lsort $pathList]
        set totalCnt [llength $pathList]
        set batch [expr {int($totalCnt * .01) + 1}]
@@ -1269,13 +1312,12 @@ proc update_index {msg pathList after} {
 }
 
 proc write_update_index {fd pathList totalCnt batch msg after} {
-       global update_index_cp update_index_rsd ui_status_value
+       global update_index_cp ui_status_value
        global file_states current_diff
 
        if {$update_index_cp >= $totalCnt} {
                close $fd
                unlock_index
-               if {$update_index_rsd} reshow_diff
                uplevel #0 $after
                return
        }
@@ -1289,15 +1331,15 @@ proc write_update_index {fd pathList totalCnt batch msg after} {
                switch -glob -- [lindex $file_states($path) 0] {
                AD -
                MD -
-               _D {set new D*}
+               _D {set new D_}
 
                _M -
                MM -
-               M_ {set new M*}
+               M_ {set new M_}
 
                _O -
                AM -
-               A_ {set new A*}
+               A_ {set new A_}
 
                ?? {continue}
                }
@@ -1305,9 +1347,6 @@ proc write_update_index {fd pathList totalCnt batch msg after} {
                puts -nonewline $fd $path
                puts -nonewline $fd "\0"
                display_file $path $new
-               if {$current_diff eq $path} {
-                       set update_index_rsd 1
-               }
        }
 
        set ui_status_value [format \
@@ -1343,13 +1382,65 @@ proc load_all_remotes {} {
        set all_remotes [lsort -unique $all_remotes]
 }
 
-proc populate_remote_menu {m pfx op} {
-       global all_remotes
+proc populate_fetch_menu {m} {
+       global gitdir all_remotes repo_config
 
-       foreach remote $all_remotes {
-               $m add command -label "$pfx $remote..." \
-                       -command [list $op $remote] \
-                       -font font_ui
+       foreach r $all_remotes {
+               set enable 0
+               if {![catch {set a $repo_config(remote.$r.url)}]} {
+                       if {![catch {set a $repo_config(remote.$r.fetch)}]} {
+                               set enable 1
+                       }
+               } else {
+                       catch {
+                               set fd [open [file join $gitdir remotes $r] r]
+                               while {[gets $fd n] >= 0} {
+                                       if {[regexp {^Pull:[ \t]*([^:]+):} $n]} {
+                                               set enable 1
+                                               break
+                                       }
+                               }
+                               close $fd
+                       }
+               }
+
+               if {$enable} {
+                       $m add command \
+                               -label "Fetch from $r..." \
+                               -command [list fetch_from $r] \
+                               -font font_ui
+               }
+       }
+}
+
+proc populate_push_menu {m} {
+       global gitdir all_remotes repo_config
+
+       foreach r $all_remotes {
+               set enable 0
+               if {![catch {set a $repo_config(remote.$r.url)}]} {
+                       if {![catch {set a $repo_config(remote.$r.push)}]} {
+                               set enable 1
+                       }
+               } else {
+                       catch {
+                               set fd [open [file join $gitdir remotes $r] r]
+                               while {[gets $fd n] >= 0} {
+                                       if {[regexp {^Push:[ \t]*([^:]+):} $n]} {
+                                               set enable 1
+                                               break
+                                       }
+                               }
+                               close $fd
+                       }
+               }
+
+               if {$enable} {
+                       $m add command \
+                               -label "Push to $r..." \
+                               -command [list push_to $r] \
+                               -font font_ui
+               }
        }
 }
 
@@ -1790,50 +1881,79 @@ proc do_rescan {} {
        rescan {set ui_status_value {Ready.}}
 }
 
-proc do_include_all {} {
-       global file_states
+proc include_helper {txt paths} {
+       global file_states current_diff
 
        if {![lock_index begin-update]} return
 
        set pathList [list]
-       foreach path [array names file_states] {
-               set s $file_states($path)
-               set m [lindex $s 0]
-               switch -- $m {
+       set after {}
+       foreach path $paths {
+               switch -- [lindex $file_states($path) 0] {
                AM -
+               AD -
                MM -
+               UM -
+               U_ -
                _M -
-               _D {lappend pathList $path}
+               _D -
+               _O {
+                       lappend pathList $path
+                       if {$path eq $current_diff} {
+                               set after {reshow_diff;}
+                       }
+               }
                }
        }
        if {$pathList eq {}} {
                unlock_index
        } else {
                update_index \
-                       "Including all modified files" \
+                       $txt \
                        $pathList \
-                       {set ui_status_value {Ready to commit.}}
+                       [concat $after {set ui_status_value {Ready to commit.}}]
        }
 }
 
-set GIT_COMMITTER_IDENT {}
+proc do_include_selection {} {
+       global current_diff selected_paths
 
-proc do_signoff {} {
-       global ui_comm GIT_COMMITTER_IDENT
+       if {[array size selected_paths] > 0} {
+               include_helper \
+                       {Including selected files} \
+                       [array names selected_paths]
+       } elseif {$current_diff ne {}} {
+               include_helper \
+                       "Including [short_path $current_diff]" \
+                       [list $current_diff]
+       }
+}
 
-       if {$GIT_COMMITTER_IDENT eq {}} {
-               if {[catch {set me [exec git var GIT_COMMITTER_IDENT]} err]} {
-                       error_popup "Unable to obtain your identity:\n\n$err"
-                       return
-               }
-               if {![regexp {^(.*) [0-9]+ [-+0-9]+$} \
-                       $me me GIT_COMMITTER_IDENT]} {
-                       error_popup "Invalid GIT_COMMITTER_IDENT:\n\n$me"
-                       return
+proc do_include_all {} {
+       global file_states
+
+       set paths [list]
+       foreach path [array names file_states] {
+               switch -- [lindex $file_states($path) 0] {
+               AM -
+               AD -
+               MM -
+               _M -
+               _D {lappend paths $path}
                }
        }
+       include_helper \
+               {Including all modified files} \
+               $paths
+}
+
+proc do_signoff {} {
+       global ui_comm
+
+       set me [committer_ident]
+       if {$me eq {}} return
 
-       set sob "Signed-off-by: $GIT_COMMITTER_IDENT"
+       set sob "Signed-off-by: $me"
        set last [$ui_comm get {end -1c linestart} {end -1c}]
        if {$last ne $sob} {
                $ui_comm edit separator
@@ -1847,8 +1967,22 @@ proc do_signoff {} {
        }
 }
 
-proc do_amend_last {} {
-       load_last_commit
+proc do_select_commit_type {} {
+       global commit_type selected_commit_type
+
+       if {$selected_commit_type eq {new}
+               && [string match amend* $commit_type]} {
+               create_new_commit
+       } elseif {$selected_commit_type eq {amend}
+               && ![string match amend* $commit_type]} {
+               load_last_commit
+
+               # The amend request was rejected...
+               #
+               if {![string match amend* $commit_type]} {
+                       set selected_commit_type new
+               }
+       }
 }
 
 proc do_commit {} {
@@ -2049,6 +2183,8 @@ proc do_windows_shortcut {} {
                                        --unix \
                                        --absolute \
                                        $gitdir]
+                               regsub -all ' $me "'\\''" me
+                               regsub -all ' $gd "'\\''" gd
                                puts -nonewline $fd "\"$sh\" --login -c \""
                                puts -nonewline $fd "GIT_DIR='$gd'"
                                puts -nonewline $fd " '$me'"
@@ -2060,8 +2196,81 @@ proc do_windows_shortcut {} {
        }
 }
 
+proc do_macosx_app {} {
+       global gitdir appname argv0 env
+
+       set reponame [lindex [file split \
+               [file normalize [file dirname $gitdir]]] \
+               end]
+
+       set fn [tk_getSaveFile \
+               -parent . \
+               -title "$appname ($reponame): Create Desktop Icon" \
+               -initialdir [file join $env(HOME) Desktop] \
+               -initialfile "Git $reponame.app"]
+       if {$fn != {}} {
+               if {[catch {
+                               set Contents [file join $fn Contents]
+                               set MacOS [file join $Contents MacOS]
+                               set exe [file join $MacOS git-gui]
+
+                               file mkdir $MacOS
+
+                               set fd [open [file join $Contents PkgInfo] w]
+                               puts -nonewline $fd {APPL????}
+                               close $fd
+
+                               set fd [open [file join $Contents Info.plist] w]
+                               puts $fd {<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+       <key>CFBundleDevelopmentRegion</key>
+       <string>English</string>
+       <key>CFBundleExecutable</key>
+       <string>git-gui</string>
+       <key>CFBundleIdentifier</key>
+       <string>org.spearce.git-gui</string>
+       <key>CFBundleInfoDictionaryVersion</key>
+       <string>6.0</string>
+       <key>CFBundlePackageType</key>
+       <string>APPL</string>
+       <key>CFBundleSignature</key>
+       <string>????</string>
+       <key>CFBundleVersion</key>
+       <string>1.0</string>
+       <key>NSPrincipalClass</key>
+       <string>NSApplication</string>
+</dict>
+</plist>}
+                               close $fd
+
+                               set fd [open $exe w]
+                               set gd [file normalize $gitdir]
+                               set ep [file normalize [exec git --exec-path]]
+                               regsub -all ' $gd "'\\''" gd
+                               regsub -all ' $ep "'\\''" ep
+                               puts $fd "#!/bin/sh"
+                               foreach name [array names env] {
+                                       if {[string match GIT_* $name]} {
+                                               regsub -all ' $env($name) "'\\''" v
+                                               puts $fd "export $name='$v'"
+                                       }
+                               }
+                               puts $fd "export PATH='$ep':\$PATH"
+                               puts $fd "export GIT_DIR='$gd'"
+                               puts $fd "exec [file normalize $argv0]"
+                               close $fd
+
+                               file attributes $exe -permissions u+x,g+x,o+x
+                       } err]} {
+                       error_popup "Cannot write icon:\n\n$err"
+               }
+       }
+}
+
 proc toggle_or_diff {w x y} {
-       global file_lists ui_index ui_other
+       global file_lists current_diff ui_index ui_other
        global last_clicked selected_paths
 
        set pos [split [$w index @$x,$y] .]
@@ -2079,10 +2288,15 @@ proc toggle_or_diff {w x y} {
        $ui_other tag remove in_sel 0.0 end
 
        if {$col == 0} {
+               if {$current_diff eq $path} {
+                       set after {reshow_diff;}
+               } else {
+                       set after {}
+               }
                update_index \
                        "Including [short_path $path]" \
                        [list $path] \
-                       {set ui_status_value {Ready.}}
+                       [concat $after {set ui_status_value {Ready.}}]
        } else {
                show_diff $path $w $lno
        }
@@ -2206,6 +2420,7 @@ apply_config
 ## ui construction
 
 # -- Menu Bar
+#
 menu .mbar -tearoff 0
 .mbar add cascade -label Project -menu .mbar.project
 .mbar add cascade -label Edit -menu .mbar.edit
@@ -2218,6 +2433,7 @@ if {!$single_commit} {
 . configure -menu .mbar
 
 # -- Project Menu
+#
 menu .mbar.project
 .mbar.project add command -label Visualize \
        -command do_gitk \
@@ -2232,6 +2448,11 @@ if {!$single_commit} {
                        -label {Create Desktop Icon} \
                        -command do_windows_shortcut \
                        -font font_ui
+       } elseif {[is_MacOSX]} {
+               .mbar.project add command \
+                       -label {Create Desktop Icon} \
+                       -command do_macosx_app \
+                       -font font_ui
        }
 }
 .mbar.project add command -label Quit \
@@ -2278,28 +2499,54 @@ menu .mbar.edit
        -font font_ui
 
 # -- Commit Menu
+#
 menu .mbar.commit
+
+.mbar.commit add radiobutton \
+       -label {New Commit} \
+       -command do_select_commit_type \
+       -variable selected_commit_type \
+       -value new \
+       -font font_ui
+lappend disable_on_lock \
+       [list .mbar.commit entryconf [.mbar.commit index last] -state]
+
+.mbar.commit add radiobutton \
+       -label {Amend Last Commit} \
+       -command do_select_commit_type \
+       -variable selected_commit_type \
+       -value amend \
+       -font font_ui
+lappend disable_on_lock \
+       [list .mbar.commit entryconf [.mbar.commit index last] -state]
+
+.mbar.commit add separator
+
 .mbar.commit add command -label Rescan \
        -command do_rescan \
        -accelerator F5 \
        -font font_ui
 lappend disable_on_lock \
        [list .mbar.commit entryconf [.mbar.commit index last] -state]
-.mbar.commit add command -label {Amend Last Commit} \
-       -command do_amend_last \
+
+.mbar.commit add command -label {Include Selected Files} \
+       -command do_include_selection \
        -font font_ui
 lappend disable_on_lock \
        [list .mbar.commit entryconf [.mbar.commit index last] -state]
+
 .mbar.commit add command -label {Include All Files} \
        -command do_include_all \
        -accelerator $M1T-I \
        -font font_ui
 lappend disable_on_lock \
        [list .mbar.commit entryconf [.mbar.commit index last] -state]
+
 .mbar.commit add command -label {Sign Off} \
        -command do_signoff \
        -accelerator $M1T-S \
        -font font_ui
+
 .mbar.commit add command -label Commit \
        -command do_commit \
        -accelerator $M1T-Return \
@@ -2307,24 +2554,23 @@ lappend disable_on_lock \
 lappend disable_on_lock \
        [list .mbar.commit entryconf [.mbar.commit index last] -state]
 
+# -- Transport menus
+#
 if {!$single_commit} {
-       # -- Fetch Menu
        menu .mbar.fetch
-
-       # -- Pull Menu
        menu .mbar.pull
-
-       # -- Push Menu
        menu .mbar.push
 }
 
 # -- Main Window Layout
+#
 panedwindow .vpane -orient vertical
 panedwindow .vpane.files -orient horizontal
 .vpane add .vpane.files -sticky nsew -height 100 -width 400
 pack .vpane -anchor n -side top -fill both -expand 1
 
 # -- Index File List
+#
 frame .vpane.files.index -height 100 -width 400
 label .vpane.files.index.title -text {Modified Files} \
        -background green \
@@ -2342,6 +2588,7 @@ pack $ui_index -side left -fill both -expand 1
 .vpane.files add .vpane.files.index -sticky nsew
 
 # -- Other (Add) File List
+#
 frame .vpane.files.other -height 100 -width 100
 label .vpane.files.other.title -text {Untracked Files} \
        -background red \
@@ -2367,6 +2614,7 @@ foreach i [list $ui_index $ui_other] {
 unset i
 
 # -- Diff and Commit Area
+#
 frame .vpane.lower -height 300 -width 400
 frame .vpane.lower.commarea
 frame .vpane.lower.diff -relief sunken -borderwidth 1
@@ -2375,6 +2623,7 @@ pack .vpane.lower.diff -side bottom -fill both -expand 1
 .vpane add .vpane.lower -stick nsew
 
 # -- Commit Area Buttons
+#
 frame .vpane.lower.commarea.buttons
 label .vpane.lower.commarea.buttons.l -text {} \
        -anchor w \
@@ -2390,13 +2639,6 @@ pack .vpane.lower.commarea.buttons.rescan -side top -fill x
 lappend disable_on_lock \
        {.vpane.lower.commarea.buttons.rescan conf -state}
 
-button .vpane.lower.commarea.buttons.amend -text {Amend Last} \
-       -command do_amend_last \
-       -font font_ui
-pack .vpane.lower.commarea.buttons.amend -side top -fill x
-lappend disable_on_lock \
-       {.vpane.lower.commarea.buttons.amend conf -state}
-
 button .vpane.lower.commarea.buttons.incall -text {Include All} \
        -command do_include_all \
        -font font_ui
@@ -2417,20 +2659,47 @@ lappend disable_on_lock \
        {.vpane.lower.commarea.buttons.commit conf -state}
 
 # -- Commit Message Buffer
+#
 frame .vpane.lower.commarea.buffer
+frame .vpane.lower.commarea.buffer.header
 set ui_comm .vpane.lower.commarea.buffer.t
-set ui_coml .vpane.lower.commarea.buffer.l
-label $ui_coml -text {Commit Message:} \
+set ui_coml .vpane.lower.commarea.buffer.header.l
+radiobutton .vpane.lower.commarea.buffer.header.new \
+       -text {New Commit} \
+       -command do_select_commit_type \
+       -variable selected_commit_type \
+       -value new \
+       -font font_ui
+lappend disable_on_lock \
+       [list .vpane.lower.commarea.buffer.header.new conf -state]
+radiobutton .vpane.lower.commarea.buffer.header.amend \
+       -text {Amend Last Commit} \
+       -command do_select_commit_type \
+       -variable selected_commit_type \
+       -value amend \
+       -font font_ui
+lappend disable_on_lock \
+       [list .vpane.lower.commarea.buffer.header.amend conf -state]
+label $ui_coml \
        -anchor w \
        -justify left \
        -font font_ui
-trace add variable commit_type write {uplevel #0 {
-       switch -glob $commit_type \
-       initial {$ui_coml conf -text {Initial Commit Message:}} \
-       amend   {$ui_coml conf -text {Amended Commit Message:}} \
-       merge   {$ui_coml conf -text {Merge Commit Message:}} \
-       *       {$ui_coml conf -text {Commit Message:}}
-}}
+proc trace_commit_type {varname args} {
+       global ui_coml commit_type
+       switch -glob -- $commit_type {
+       initial       {set txt {Initial Commit Message:}}
+       amend         {set txt {Amended Commit Message:}}
+       amend-initial {set txt {Amended Initial Commit Message:}}
+       merge         {set txt {Merge Commit Message:}}
+       *             {set txt {Commit Message:}}
+       }
+       $ui_coml conf -text $txt
+}
+trace add variable commit_type write trace_commit_type
+pack $ui_coml -side left -fill x
+pack .vpane.lower.commarea.buffer.header.amend -side right
+pack .vpane.lower.commarea.buffer.header.new -side right
+
 text $ui_comm -background white -borderwidth 1 \
        -undo true \
        -maxundo 20 \
@@ -2441,7 +2710,7 @@ text $ui_comm -background white -borderwidth 1 \
        -yscrollcommand {.vpane.lower.commarea.buffer.sby set}
 scrollbar .vpane.lower.commarea.buffer.sby \
        -command [list $ui_comm yview]
-pack $ui_coml -side top -fill x
+pack .vpane.lower.commarea.buffer.header -side top -fill x
 pack .vpane.lower.commarea.buffer.sby -side right -fill y
 pack $ui_comm -side left -fill y
 pack .vpane.lower.commarea.buffer -side left -fill y
@@ -2487,9 +2756,10 @@ $ctxm add command \
 bind_button3 $ui_comm "tk_popup $ctxm %X %Y"
 
 # -- Diff Header
+#
 set current_diff {}
 set diff_actions [list]
-proc current_diff_trace {varname args} {
+proc trace_current_diff {varname args} {
        global current_diff diff_actions file_states
        if {$current_diff eq {}} {
                set s {}
@@ -2511,7 +2781,7 @@ proc current_diff_trace {varname args} {
                uplevel #0 $w $o
        }
 }
-trace add variable current_diff write current_diff_trace
+trace add variable current_diff write trace_current_diff
 
 frame .vpane.lower.diff.header -background orange
 label .vpane.lower.diff.header.status \
@@ -2549,6 +2819,7 @@ lappend diff_actions [list $ctxm entryconf [$ctxm index last] -state]
 bind_button3 .vpane.lower.diff.header.path "tk_popup $ctxm %X %Y"
 
 # -- Diff Body
+#
 frame .vpane.lower.diff.body
 set ui_diff .vpane.lower.diff.body.t
 text $ui_diff -background white -borderwidth 0 \
@@ -2705,14 +2976,21 @@ unset i
 
 set file_lists($ui_index) [list]
 set file_lists($ui_other) [list]
+
+set HEAD {}
+set PARENT {}
+set commit_type {}
+set empty_tree {}
 set current_diff {}
+set selected_commit_type new
 
 wm title . "$appname ([file normalize [file dirname $gitdir]])"
 focus -force $ui_comm
 if {!$single_commit} {
        load_all_remotes
-       populate_remote_menu .mbar.fetch From fetch_from
-       populate_remote_menu .mbar.push To push_to
+       populate_fetch_menu .mbar.fetch
        populate_pull_menu .mbar.pull
+       populate_push_menu .mbar.push
 }
+lock_index begin-read
 after 1 do_rescan