Don't die in git-http-fetch when fetching packs.

diff --git a/write_or_die.c b/write_or_die.c
index 613c0c3f6e90cc6a1b7ae9c0ade4e5c10dc25029..a119e1d208445093dd1d2869729eca9435aa020e 100644 (file)
--- a/write_or_die.c
+++ b/write_or_die.c
@@ -1,60 +1,72 @@
 #include "cache.h"
 
-void read_or_die(int fd, void *buf, size_t count)
+int read_in_full(int fd, void *buf, size_t count)
 {
        char *p = buf;
-       ssize_t loaded;
+       ssize_t total = 0;
+       ssize_t loaded = 0;
 
        while (count > 0) {
                loaded = xread(fd, p, count);
-               if (loaded == 0)
-                       die("unexpected end of file");
-               else if (loaded < 0)
-                       die("read error (%s)", strerror(errno));
+               if (loaded <= 0) {
+                       if (total)
+                               return total;
+                       else
+                               return loaded;
+               }
                count -= loaded;
                p += loaded;
+               total += loaded;
        }
+
+       return total;
 }
 
-void write_or_die(int fd, const void *buf, size_t count)
+void read_or_die(int fd, void *buf, size_t count)
 {
-       const char *p = buf;
-       ssize_t written;
+       ssize_t loaded;
 
-       while (count > 0) {
-               written = xwrite(fd, p, count);
-               if (written == 0)
-                       die("disk full?");
-               else if (written < 0) {
-                       if (errno == EPIPE)
-                               exit(0);
-                       die("write error (%s)", strerror(errno));
-               }
-               count -= written;
-               p += written;
-       }
+       loaded = read_in_full(fd, buf, count);
+       if (loaded == 0)
+               die("unexpected end of file");
+       else if (loaded < 0)
+               die("read error (%s)", strerror(errno));
 }
 
 int write_in_full(int fd, const void *buf, size_t count)
 {
        const char *p = buf;
        ssize_t total = 0;
-       ssize_t wcount = 0;
+       ssize_t written = 0;
 
        while (count > 0) {
-               wcount = xwrite(fd, p, count);
-               if (wcount <= 0) {
+               written = xwrite(fd, p, count);
+               if (written <= 0) {
                        if (total)
                                return total;
                        else
-                               return wcount;
+                               return written;
                }
-               count -= wcount;
-               p += wcount;
-               total += wcount;
+               count -= written;
+               p += written;
+               total += written;
        }
 
-       return wcount;
+       return total;
+}
+
+void write_or_die(int fd, const void *buf, size_t count)
+{
+       ssize_t written;
+
+       written = write_in_full(fd, buf, count);
+       if (written == 0)
+               die("disk full?");
+       else if (written < 0) {
+               if (errno == EPIPE)
+                       exit(0);
+               die("write error (%s)", strerror(errno));
+       }
 }
 
 int write_or_whine_pipe(int fd, const void *buf, size_t count, const char *msg)