Git.pm: Introduce ident() and ident_person() methods

diff --git a/git-mv.perl b/git-mv.perl
index f3e859ae48af05d0b982a159c2197bab7e5da996..322b9fdcb36367934e5409f2f825d7d782787289 100755 (executable)
--- a/git-mv.perl
+++ b/git-mv.perl
@@ -6,10 +6,10 @@
 # This file is licensed under the GPL v2, or a later version
 # at the discretion of Linus Torvalds.
 
-
 use warnings;
 use strict;
 use Getopt::Std;
+use Git;
 
 sub usage() {
        print <<EOT;
@@ -24,9 +24,7 @@ ()
 usage() if $opt_h;
 @ARGV >= 1 or usage;
 
-my $GIT_DIR = `git rev-parse --git-dir`;
-exit 1 if $?; # rev-parse would have given "not a git dir" message.
-chomp($GIT_DIR);
+my $repo = Git->repository();
 
 my (@srcArgs, @dstArgs, @srcs, @dsts);
 my ($src, $dst, $base, $dstDir);
@@ -62,9 +60,17 @@ ()
     $dstDir = "";
 }
 
+my $subdir_prefix = $repo->wc_subdir();
+
+# run in git base directory, so that git-ls-files lists all revisioned files
+chdir $repo->wc_path();
+$repo->wc_chdir('');
+
 # normalize paths, needed to compare against versioned files and update-index
 # also, this is nicer to end-users by doing ".//a/./b/.//./c" ==> "a/b/c"
 for (@srcArgs, @dstArgs) {
+    # prepend git prefix as we run from base directory
+    $_ = $subdir_prefix.$_;
     s|^\./||;
     s|/\./|/| while (m|/\./|);
     s|//+|/|g;
@@ -76,12 +82,10 @@ ()
 my $safesrc;
 my (%overwritten, %srcForDst);
 
-$/ = "\0";
-open(F, 'git-ls-files -z |')
-        or die "Failed to open pipe from git-ls-files: " . $!;
-
-@allfiles = map { chomp; $_; } <F>;
-close(F);
+{
+       local $/ = "\0";
+       @allfiles = $repo->command('ls-files', '-z');
+}
 
 
 my ($i, $bad);
@@ -90,6 +94,15 @@ ()
     $dst = shift @dstArgs;
     $bad = "";
 
+    for ($src, $dst) {
+       # Be nicer to end-users by doing ".//a/./b/.//./c" ==> "a/b/c"
+       s|^\./||;
+       s|/\./|/| while (m|/\./|);
+       s|//+|/|g;
+       # Also "a/b/../c" ==> "a/c"
+       1 while (s,(^|/)[^/]+/\.\./,$1,);
+    }
+
     if ($opt_v) {
        print "Checking rename of '$src' to '$dst'\n";
     }
@@ -202,28 +215,28 @@ ()
 }
 else {
     if (@changedfiles) {
-       open(H, "| git-update-index -z --stdin")
-               or die "git-update-index failed to update changed files with code $!\n";
+       my ($fd, $ctx) = $repo->command_input_pipe('update-index', '-z', '--stdin');
        foreach my $fileName (@changedfiles) {
-               print H "$fileName\0";
+               print $fd "$fileName\0";
        }
-       close(H);
+       git_cmd_try { $repo->command_close_pipe($fd, $ctx); }
+               'git-update-index failed to update changed files with code %d';
     }
     if (@addedfiles) {
-       open(H, "| git-update-index --add -z --stdin")
-               or die "git-update-index failed to add new names with code $!\n";
+       my ($fd, $ctx) = $repo->command_input_pipe('update-index', '--add', '-z', '--stdin');
        foreach my $fileName (@addedfiles) {
-               print H "$fileName\0";
+               print $fd "$fileName\0";
        }
-       close(H);
+       git_cmd_try { $repo->command_close_pipe($fd, $ctx); }
+               'git-update-index failed to add new files with code %d';
     }
     if (@deletedfiles) {
-       open(H, "| git-update-index --remove -z --stdin")
-               or die "git-update-index failed to remove old names with code $!\n";
+       my ($fd, $ctx) = $repo->command_input_pipe('update-index', '--remove', '-z', '--stdin');
        foreach my $fileName (@deletedfiles) {
-               print H "$fileName\0";
+               print $fd "$fileName\0";
        }
-       close(H);
+       git_cmd_try { $repo->command_close_pipe($fd, $ctx); }
+               'git-update-index failed to remove old files with code %d';
     }
 }