get_sha1_oneline: make callers prepare the commit list to traverse

diff --git a/t/lib-terminal.sh b/t/lib-terminal.sh
index 3258b8f0d5c36e0450ac5421b39b1ff4b3c379d0..c383b57ed9d995f530004923962c45ab38c7fc8b 100644 (file)
--- a/t/lib-terminal.sh
+++ b/t/lib-terminal.sh
@@ -1,28 +1,19 @@
 #!/bin/sh
 
 test_expect_success 'set up terminal for tests' '
-       if test -t 1 && test -t 2
-       then
-               >have_tty
-       elif
+       if
                test_have_prereq PERL &&
                "$PERL_PATH" "$TEST_DIRECTORY"/test-terminal.perl \
                        sh -c "test -t 1 && test -t 2"
        then
-               >test_terminal_works
+               test_set_prereq TTY &&
+               test_terminal () {
+                       if ! test_declared_prereq TTY
+                       then
+                               echo >&4 "test_terminal: need to declare TTY prerequisite"
+                               return 127
+                       fi
+                       "$PERL_PATH" "$TEST_DIRECTORY"/test-terminal.perl "$@"
+               }
        fi
 '
-
-if test -e have_tty
-then
-       test_terminal() { "$@"; }
-       test_set_prereq TTY
-elif test -e test_terminal_works
-then
-       test_terminal() {
-               "$PERL_PATH" "$TEST_DIRECTORY"/test-terminal.perl "$@"
-       }
-       test_set_prereq TTY
-else
-       say "# no usable terminal, so skipping some tests"
-fi