ref-filter: make "--contains <id>" less chatty if <id> is invalid

diff --git a/builtin/branch.c b/builtin/branch.c
index 8dcc2ed058be6e653f885e48c9aa5f465a5f9749..43442c12e0499e266e68612e43d93172699a355c 100644 (file)
--- a/builtin/branch.c
+++ b/builtin/branch.c
@@ -596,10 +596,10 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
                OPT__COLOR(&branch_use_color, N_("use colored output")),
                OPT_SET_INT('r', "remotes",     &filter.kind, N_("act on remote-tracking branches"),
                        FILTER_REFS_REMOTES),
-               OPT_CONTAINS(&filter.with_commit, N_("print only branches that contain the commit")),
-               OPT_NO_CONTAINS(&filter.no_commit, N_("print only branches that don't contain the commit")),
-               OPT_WITH(&filter.with_commit, N_("print only branches that contain the commit")),
-               OPT_WITHOUT(&filter.no_commit, N_("print only branches that don't contain the commit")),
+               OPT_CONTAINS(&filter.with_commit_strs, N_("print only branches that contain the commit")),
+               OPT_NO_CONTAINS(&filter.no_commit_strs, N_("print only branches that don't contain the commit")),
+               OPT_WITH(&filter.with_commit_strs, N_("print only branches that contain the commit")),
+               OPT_WITHOUT(&filter.no_commit_strs, N_("print only branches that don't contain the commit")),
                OPT__ABBREV(&filter.abbrev),
 
                OPT_GROUP(N_("Specific git-branch actions:")),
@@ -657,8 +657,8 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
        if (!delete && !rename && !copy && !edit_description && !new_upstream && !unset_upstream && argc == 0)
                list = 1;
 
-       if (filter.with_commit || filter.merge != REF_FILTER_MERGED_NONE || filter.points_at.nr ||
-           filter.no_commit)
+       if (filter.with_commit_strs.nr || filter.merge != REF_FILTER_MERGED_NONE || filter.points_at.nr ||
+           filter.no_commit_strs.nr)
                list = 1;
 
        if (!!delete + !!rename + !!copy + !!new_upstream +