commit: convert to use parse_pathspec

diff --git a/builtin/check-ref-format.c b/builtin/check-ref-format.c
index 72959547b31ccf0239a146b91a06d92332b901f6..28a7320271a9555356170bfdb06ffb4b07bc9b92 100644 (file)
--- a/builtin/check-ref-format.c
+++ b/builtin/check-ref-format.c
@@ -8,29 +8,32 @@
 #include "strbuf.h"
 
 static const char builtin_check_ref_format_usage[] =
-"git check-ref-format [--print] [options] <refname>\n"
+"git check-ref-format [--normalize] [options] <refname>\n"
 "   or: git check-ref-format --branch <branchname-shorthand>";
 
 /*
- * Remove leading slashes and replace each run of adjacent slashes in
- * src with a single slash, and write the result to dst.
+ * Return a copy of refname but with leading slashes removed and runs
+ * of adjacent slashes replaced with single slashes.
  *
  * This function is similar to normalize_path_copy(), but stripped down
  * to meet check_ref_format's simpler needs.
  */
-static void collapse_slashes(char *dst, const char *src)
+static char *collapse_slashes(const char *refname)
 {
+       char *ret = xmalloc(strlen(refname) + 1);
        char ch;
        char prev = '/';
+       char *cp = ret;
 
-       while ((ch = *src++) != '\0') {
+       while ((ch = *refname++) != '\0') {
                if (prev == '/' && ch == prev)
                        continue;
 
-               *dst++ = ch;
+               *cp++ = ch;
                prev = ch;
        }
-       *dst = '\0';
+       *cp = '\0';
+       return ret;
 }
 
 static int check_ref_format_branch(const char *arg)
@@ -45,22 +48,12 @@ static int check_ref_format_branch(const char *arg)
        return 0;
 }
 
-static void refname_format_print(const char *arg)
-{
-       char *refname = xmalloc(strlen(arg) + 1);
-
-       collapse_slashes(refname, arg);
-       printf("%s\n", refname);
-}
-
-#define REFNAME_ALLOW_ONELEVEL 1
-#define REFNAME_REFSPEC_PATTERN 2
-
 int cmd_check_ref_format(int argc, const char **argv, const char *prefix)
 {
        int i;
-       int print = 0;
+       int normalize = 0;
        int flags = 0;
+       const char *refname;
 
        if (argc == 2 && !strcmp(argv[1], "-h"))
                usage(builtin_check_ref_format_usage);
@@ -69,8 +62,8 @@ int cmd_check_ref_format(int argc, const char **argv, const char *prefix)
                return check_ref_format_branch(argv[2]);
 
        for (i = 1; i < argc && argv[i][0] == '-'; i++) {
-               if (!strcmp(argv[i], "--print"))
-                       print = 1;
+               if (!strcmp(argv[i], "--normalize") || !strcmp(argv[i], "--print"))
+                       normalize = 1;
                else if (!strcmp(argv[i], "--allow-onelevel"))
                        flags |= REFNAME_ALLOW_ONELEVEL;
                else if (!strcmp(argv[i], "--no-allow-onelevel"))
@@ -83,27 +76,13 @@ int cmd_check_ref_format(int argc, const char **argv, const char *prefix)
        if (! (i == argc - 1))
                usage(builtin_check_ref_format_usage);
 
-       switch (check_ref_format(argv[i])) {
-       case CHECK_REF_FORMAT_OK:
-               break;
-       case CHECK_REF_FORMAT_ERROR:
+       refname = argv[i];
+       if (normalize)
+               refname = collapse_slashes(refname);
+       if (check_refname_format(refname, flags))
                return 1;
-       case CHECK_REF_FORMAT_ONELEVEL:
-               if (!(flags & REFNAME_ALLOW_ONELEVEL))
-                       return 1;
-               else
-                       break;
-       case CHECK_REF_FORMAT_WILDCARD:
-               if (!(flags & REFNAME_REFSPEC_PATTERN))
-                       return 1;
-               else
-                       break;
-       default:
-               die("internal error: unexpected value from check_ref_format()");
-       }
-
-       if (print)
-               refname_format_print(argv[i]);
+       if (normalize)
+               printf("%s\n", refname);
 
        return 0;
 }