[PATCH] local-fetch.c: some error printing cleanup

diff --git a/run-command.c b/run-command.c
index a866a0669426f0f1c94bee92d3b78d191209c28b..bef9775e0807200e07c9780c69e3e1bda0c6c874 100644 (file)
--- a/run-command.c
+++ b/run-command.c
@@ -2,17 +2,44 @@
 #include "run-command.h"
 #include "exec_cmd.h"
 
+static inline void close_pair(int fd[2])
+{
+       close(fd[0]);
+       close(fd[1]);
+}
+
 int start_command(struct child_process *cmd)
 {
+       int need_in = !cmd->no_stdin && cmd->in < 0;
+       int fdin[2];
+
+       if (need_in) {
+               if (pipe(fdin) < 0)
+                       return -ERR_RUN_COMMAND_PIPE;
+               cmd->in = fdin[1];
+               cmd->close_in = 1;
+       }
+
        cmd->pid = fork();
-       if (cmd->pid < 0)
+       if (cmd->pid < 0) {
+               if (need_in)
+                       close_pair(fdin);
                return -ERR_RUN_COMMAND_FORK;
+       }
+
        if (!cmd->pid) {
                if (cmd->no_stdin) {
                        int fd = open("/dev/null", O_RDWR);
                        dup2(fd, 0);
                        close(fd);
+               } else if (need_in) {
+                       dup2(fdin[0], 0);
+                       close_pair(fdin);
+               } else if (cmd->in) {
+                       dup2(cmd->in, 0);
+                       close(cmd->in);
                }
+
                if (cmd->stdout_to_stderr)
                        dup2(2, 1);
                if (cmd->git_cmd) {
@@ -22,11 +49,20 @@ int start_command(struct child_process *cmd)
                }
                die("exec %s failed.", cmd->argv[0]);
        }
+
+       if (need_in)
+               close(fdin[0]);
+       else if (cmd->in)
+               close(cmd->in);
+
        return 0;
 }
 
 int finish_command(struct child_process *cmd)
 {
+       if (cmd->close_in)
+               close(cmd->in);
+
        for (;;) {
                int status, code;
                pid_t waiting = waitpid(cmd->pid, &status, 0);